This repository was archived by the owner on Aug 7, 2021. It is now read-only.

Commit 5a42e32

author

Dimitar Kerezov

committed

Minor fix

Fix `cwd` parameter name. Remove `shell: true` becuase it causes issues on windows.

1 parent 3507346 commit 5a42e32Copy full SHA for 5a42e32

File tree

-5

lines changed

-5

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -225,7 +225,7 @@ function spawnChildProcess(command, ...args) {`
`225`	`225`
`226`	`226`	`const childProcess = spawn(command, escapedArgs, {`
`227`	`227`	`stdio: "inherit",`
`228`		`- pwd: PROJECT_DIR,`
	`228`	`+ cwd: PROJECT_DIR,`
`229`	`229`	`shell: true,`
`230`	`230`	`});`
`231`	`231`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -70,8 +70,7 @@ exports.runWebpackCompiler = function runWebpackCompiler(config, $mobileHelper,`
`70`	`70`	`// These will notify us for the webpack compilation states.`
`71`	`71`	// Enables `childProcess.on("message", msg => ...)` kind of communication.
`72`	`72`	`stdio: config.watch ? ["inherit", "inherit", "inherit", "ipc"] : "inherit",`
`73`		`- pwd: $projectData.projectDir,`
`74`		`- shell: true,`
	`73`	`+ cwd: $projectData.projectDir`
`75`	`74`	`});`
`76`	`75`
`77`	`76`	`function resolveOnWebpackCompilationComplete(message) {`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ function execute(command) {`
`69`	`69`	`return new Promise((resolve, reject) => {`
`70`	`70`	`const args = command.split(" ");`
`71`	`71`	`spawnChildProcess(...args)`
`72`		`- .then(resolve)`
	`72`	`+ .then(resolve)`
`73`	`73`	`.catch(throwError)`
`74`	`74`	`});`
`75`	`75`	`}`
`@@ -80,7 +80,7 @@ function spawnChildProcess(command, ...args) {`
`80`	`80`
`81`	`81`	`const childProcess = spawn(command, escapedArgs, {`
`82`	`82`	`stdio: "inherit",`
`83`		`- pwd: PROJECT_DIR,`
	`83`	`+ cwd: PROJECT_DIR,`
`84`	`84`	`shell: true,`
`85`	`85`	`});`
`86`	`86`

Comments

(0)