Commit ac694d7

Zdravko BranzovZdravko Branzov

Zdravko Branzov

authored and

Zdravko Branzov

committed

chore: add the ability to set global tolerance and toleranceType

1 parent ebe92e0 commit ac694d7Copy full SHA for ac694d7

File tree

2 files changed

+25

-3

lines changed

lib
- appium-driver.d.ts
- appium-driver.ts

2 files changed

+25

-3

lines changed

`‎lib/appium-driver.d.ts`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,8 @@ export declare class AppiumDriver {`
`23`	`23`	`private _isAlive;`
`24`	`24`	`private _locators;`
`25`	`25`	`private _storageByPlatform;`
	`26`	`+ private _defaultToleranceType;`
	`27`	`+ private _defaultTolerance;`
`26`	`28`	`private constructor();`
`27`	`29`	`readonly imageHelper: ImageHelper;`
`28`	`30`	`defaultWaitTime: number;`
`@@ -36,6 +38,8 @@ export declare class AppiumDriver {`
`36`	`38`	`readonly isAndroid: boolean;`
`37`	`39`	`readonly isIOS: boolean;`
`38`	`40`	`readonly driver: any;`
	`41`	`+ defaultToleranceType: ImageOptions;`
	`42`	`+ defaultTolerance: number;`
`39`	`43`	`/**`
`40`	`44`	`* Get the storage where test results from image comparison is logged. The path should be reports/app nam/device name`
`41`	`45`	`*/`

`‎lib/appium-driver.ts`

Lines changed: 21 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,8 @@ export class AppiumDriver {`
`57`	`57`	`private _isAlive: boolean = false;`
`58`	`58`	`private _locators: Locator;`
`59`	`59`	`private _storageByPlatform: string;`
	`60`	`+ private _defaultToleranceType: ImageOptions = ImageOptions.percent;`
	`61`	`+ private _defaultTolerance: number = 0;`
`60`	`62`
`61`	`63`	`private constructor(private _driver: any, private _wd, private _webio: any, private _driverConfig, private _args: INsCapabilities) {`
`62`	`64`	`this._elementHelper = new ElementHelper(this._args);`
`@@ -118,6 +120,22 @@ export class AppiumDriver {`
`118`	`120`	`return this._driver;`
`119`	`121`	`}`
`120`	`122`
	`123`	`+ get defaultToleranceType(): ImageOptions {`
	`124`	`+ return this._defaultToleranceType;`
	`125`	`+ }`
	`126`	`+`
	`127`	`+ set defaultToleranceType(toleranceType: ImageOptions) {`
	`128`	`+ this._defaultToleranceType = toleranceType;`
	`129`	`+ }`
	`130`	`+`
	`131`	`+ get defaultTolerance(): number {`
	`132`	`+ return this._defaultTolerance;`
	`133`	`+ }`
	`134`	`+`
	`135`	`+ set defaultTolerance(tolerance: number) {`
	`136`	`+ this._defaultTolerance = tolerance;`
	`137`	`+ }`
	`138`	`+`
`121`	`139`	`/**`
`122`	`140`	`* Get the storage where test results from image comparison is logged. The path should be reports/app nam/device name`
`123`	`141`	`*/`
`@@ -601,11 +619,11 @@ export class AppiumDriver {`
`601`	`619`	`return await this.driver.getSessionId();`
`602`	`620`	`}`
`603`	`621`
`604`		`- public async compareElement(element: UIElement, imageName?: string, tolerance: number = 0, timeOutSeconds: number = 3, toleranceType: ImageOptions = ImageOptions.percent) {`
	`622`	`+ public async compareElement(element: UIElement, imageName?: string, tolerance: number = this._defaultTolerance, timeOutSeconds: number = 3, toleranceType: ImageOptions = this._defaultToleranceType) {`
`605`	`623`	`return await this.compareRectangle(await element.getActualRectangle(), imageName, timeOutSeconds, tolerance, toleranceType);`
`606`	`624`	`}`
`607`	`625`
`608`		`- public async compareRectangle(rect: IRectangle, imageName?: string, timeOutSeconds: number = 3, tolerance: number = 0, toleranceType: ImageOptions = ImageOptions.percent) {`
	`626`	`+ public async compareRectangle(rect: IRectangle, imageName?: string, timeOutSeconds: number = 3, tolerance: number = this._defaultTolerance, toleranceType: ImageOptions = this._defaultToleranceType) {`
`609`	`627`	`imageName = imageName \|\| this.imageHelper.testName;`
`610`	`628`	`const options = this.imageHelper.extendOptions({`
`611`	`629`	`imageName: imageName,`
`@@ -619,7 +637,7 @@ export class AppiumDriver {`
`619`	`637`	`return await this.imageHelper.compare(options);`
`620`	`638`	`}`
`621`	`639`
`622`		`- public async compareScreen(imageName?: string, timeOutSeconds: number = 3, tolerance: number = 0, toleranceType: ImageOptions = ImageOptions.percent) {`
	`640`	`+ public async compareScreen(imageName?: string, timeOutSeconds: number = 3, tolerance: number = this._defaultTolerance, toleranceType: ImageOptions = this._defaultToleranceType) {`
`623`	`641`	`imageName = imageName \|\| this.imageHelper.testName;`
`624`	`642`	`const options = this.imageHelper.extendOptions({`
`625`	`643`	`imageName: imageName,`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit ac694d7

File tree

2 files changed

2 files changed

`‎lib/appium-driver.d.ts`

`‎lib/appium-driver.ts`

0 commit comments