Commit 70730d9

NathanWalkerAlexander Vakrilov

authored and

Alexander Vakrilov

committed

fix(modal): throw from tns-core-modules is now properly caught and rejected

1 parent dc8080b commit 70730d9Copy full SHA for 70730d9

File tree

+19

-13

lines changed

+19

-13

lines changed

Lines changed: 19 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -76,19 +76,25 @@ export class ModalDialogService {`
`76`	`76`
`77`	`77`	`this.location._beginModalNavigation();`
`78`	`78`
`79`		`- return new Promise(resolve => {`
`80`		`- setTimeout(() => this._showDialog({`
`81`		`- containerRef: viewContainerRef,`
`82`		`- context,`
`83`		`- doneCallback: resolve,`
`84`		`- fullscreen,`
`85`		`- animated,`
`86`		`- stretched,`
`87`		`- pageFactory,`
`88`		`- parentView,`
`89`		`- resolver,`
`90`		`- type,`
`91`		`- }), 10);`
	`79`	`+ return new Promise((resolve, reject) => {`
	`80`	`+ setTimeout(() => {`
	`81`	`+ try {`
	`82`	`+ this._showDialog({`
	`83`	`+ containerRef: viewContainerRef,`
	`84`	`+ context,`
	`85`	`+ doneCallback: resolve,`
	`86`	`+ fullscreen,`
	`87`	`+ animated,`
	`88`	`+ stretched,`
	`89`	`+ pageFactory,`
	`90`	`+ parentView,`
	`91`	`+ resolver,`
	`92`	`+ type,`
	`93`	`+ });`
	`94`	`+ } catch (err) {`
	`95`	`+ reject(err);`
	`96`	`+ }`
	`97`	`+ }, 10);`
`92`	`98`	`});`
`93`	`99`	`}`
`94`	`100`

Comments

(0)