Commit 1dca81b

authored

fix(detached-loader): detach loadWithFactory (#2260)

1 parent bcde284 commit 1dca81bCopy full SHA for 1dca81b

File tree

-1

lines changed

-1

lines changed

Lines changed: 8 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,13 @@ export class DetachedLoader implements OnDestroy {`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`public loadWithFactory<T>(factory: ComponentFactory<T>): ComponentRef<T> {`
`52`		`- return this.containerRef.createComponent(factory, this.containerRef.length, this.containerRef.injector, null);`
	`52`	`+ const componentRef = factory.create(this.containerRef.injector);`
	`53`	`+ this.appRef.attachView(componentRef.hostView);`
	`54`	`+`
	`55`	`+ this.disposeFunctions.push(() => {`
	`56`	`+ this.appRef.detachView(componentRef.hostView);`
	`57`	`+ componentRef.destroy();`
	`58`	`+ });`
	`59`	`+ return componentRef;`
`53`	`60`	`}`
`54`	`61`	`}`

Comments

(0)