Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 0bd2ba5

Browse files
authored
refactor: stop exporting NativeScriptModule from platform (#701)
Importing NativeScriptModule from "nativescript-angular/platform" leads to including @angular/compiler in the bundle when doing AoT compilation with webpack. Import from "nativescript-angular/nativescript.module" should be used instead. BREAKING CHANGE: User applications cannot import NativeScriptModule from "nativescript-angular/platform" anymore. Migration: Before: ``` import { NativeScriptModule } from "nativescript-angular/platform"; ``` After ``` import { NativeScriptModule } from "nativescript-angular/nativescript.module"; ```
1 parent 9beea98 commit 0bd2ba5

File tree

5 files changed

+7
-6
lines changed

5 files changed

+7
-6
lines changed

‎nativescript-angular/platform.ts‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ import "./dom-adapter";
3333
import { NativeScriptElementSchemaRegistry } from "./schema-registry";
3434
import { FileSystemResourceLoader } from "./resource-loader";
3535

36-
export { NativeScriptModule } from "./nativescript.module";
37-
3836
export const NS_COMPILER_PROVIDERS = [
3937
COMPILER_PROVIDERS,
4038
{

‎tests/app/lazy-loaded.module.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { NgModule } from '@angular/core';
2-
import { NativeScriptModule } from "nativescript-angular";
2+
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
33
import { NativeScriptRouterModule } from "nativescript-angular/router";
44

55
import { SecondComponent } from './second.component';

‎tests/app/main.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
// "nativescript-angular/platform" import should be first in order to load some required settings (like globals and reflect-metadata)
2-
import { NativeScriptModule, platformNativeScriptDynamic } from "nativescript-angular/platform";
2+
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
3+
import { platformNativeScriptDynamic } from "nativescript-angular/platform";
34
import { NativeScriptRouterModule, NSModuleFactoryLoader } from "nativescript-angular/router";
45
import { NativeScriptFormsModule } from "nativescript-angular/forms";
56
import { AppComponent } from "./app.component";

‎tests/app/snippets/navigation/page-outlet.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@ import { TestApp, registerTestApp } from "../../tests/test-app";
22
import { ApplicationRef } from '@angular/core';
33
import { Router, NavigationStart, NavigationEnd } from "@angular/router";
44
// >> page-outlet-example
5-
import { platformNativeScriptDynamic, NativeScriptModule } from "nativescript-angular/platform";
5+
import { platformNativeScriptDynamic } from "nativescript-angular/platform";
6+
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
67
import { Component, NgModule } from '@angular/core';
78
import { NativeScriptRouterModule } from "nativescript-angular/router";
89
import { routes } from "./app.routes";

‎tests/app/tests/test-app.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import { NativeScriptModule, platformNativeScriptDynamic } from "nativescript-angular/platform";
1+
import { platformNativeScriptDynamic } from "nativescript-angular/platform";
2+
import { NativeScriptModule } from "nativescript-angular/nativescript.module";
23
import { NativeScriptRouterModule } from "nativescript-angular/router";
34
import {
45
Type, Component, ComponentRef,

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /