add additional type_traits methods#66

Open

jglaser wants to merge 1 commit intoNVIDIA:master from

jglaser:make_signed

Open

add additional type_traits methods #66
jglaser wants to merge 1 commit intoNVIDIA:master from
jglaser:make_signed

Conversation

@jglaser

Copy link

Contributor

@jglaser jglaser commented May 12, 2020

To enable compilation of code which includes the Random123 RNG library, we need the std::make_signed<> templates, which I am adding in this PR.

@jglaser


 add additional type_traits methods

96ae58a

benbarsdell

benbarsdell suggested changes

May 12, 2020

View reviewed changes

Copy link

Contributor

@benbarsdell benbarsdell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

Just a few small additions needed.

jitify.hpp

template<class Ret, class... Args> struct is_function<Ret(Args......)> : true_type {}; // variadic

template<typename T> struct make_signed { typedef T type; };

template<> struct make_signed<unsigned char> { typedef signed char type; };

Copy link

Contributor

@benbarsdell benbarsdell May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a separate specialization for char (which is a distinct type and not necessarily signed or unsigned).

jitify.hpp

template<> struct make_signed<unsigned long long> { typedef signed long long type; };

template<typename T> struct make_unsigned { typedef T type; };

template<> struct make_unsigned<char> { typedef unsigned char type; };

Copy link

Contributor

@benbarsdell benbarsdell May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a separate specialization for signed char.

jitify.hpp

template<> struct make_signed<unsigned int> { typedef signed int type; };

template<> struct make_signed<unsigned long> { typedef signed long type; };

template<> struct make_signed<unsigned long long> { typedef signed long long type; };

Copy link

Contributor

@benbarsdell benbarsdell May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need specializations to preserve CV-qualifiers.

Suggested change

template<typename T> structmake_signed<const T> { typedefconsttypename make_signed<T>::type type; };

template<typename T> struct make_signed<volatile T> { typedef volatile typename make_signed<T>::type type; };

template<typename T> struct make_signed<const volatile T> { typedef const volatile typename make_signed<T>::type type; };

jitify.hpp

template<> struct make_unsigned<int> { typedef unsigned int type; };

template<> struct make_unsigned<long> { typedef unsigned long type; };

template<> struct make_unsigned<long long> { typedef unsigned long long type; };

Copy link

Contributor

@benbarsdell benbarsdell May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need specializations to preserve CV-qualifiers.

Suggested change

template<typename T> structmake_unsigned<const T> { typedefconsttypename make_unsigned<T>::type type; };

template<typename T> struct make_unsigned<volatile T> { typedef volatile typename make_unsigned<T>::type type; };

template<typename T> struct make_unsigned<const volatile T> { typedef const volatile typename make_unsigned<T>::type type; };

jitify.hpp

template<class Ret, class... Args> struct is_function<Ret(Args...)> : true_type {}; //regular

template<class Ret, class... Args> struct is_function<Ret(Args......)> : true_type {}; // variadic

template<typename T> struct make_signed { typedef T type; };

Copy link

Contributor

@benbarsdell benbarsdell May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a specialization for bool with no implementation.

jitify.hpp

template<> struct make_signed<unsigned long> { typedef signed long type; };

template<> struct make_signed<unsigned long long> { typedef signed long long type; };

template<typename T> struct make_unsigned { typedef T type; };

Copy link

Contributor

@benbarsdell benbarsdell May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a specialization for bool with no implementation.

jitify.hpp

template<class Ret, class... Args> struct is_function<Ret(Args...)> : true_type {}; //regular

template<class Ret, class... Args> struct is_function<Ret(Args......)> : true_type {}; // variadic

template<typename T> struct make_signed { typedef T type; };

Copy link

Contributor

@benbarsdell benbarsdell May 12, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can you add a TODO noting that there are more complicated rules for enums, char, wchar_t etc. that aren't implemented here.

@maddyscientist

Copy link

Collaborator

maddyscientist commented May 28, 2020

@jglaser just wondering if you'll get round to making the requested changes for this nice PR? Thanks.

Conversation

@jglaser jglaser commented May 12, 2020

Uh oh!

@benbarsdell benbarsdell left a comment

Choose a reason for hiding this comment

Uh oh!

@benbarsdell benbarsdell May 12, 2020

Choose a reason for hiding this comment

Uh oh!

@benbarsdell benbarsdell May 12, 2020

Choose a reason for hiding this comment

Uh oh!

@benbarsdell benbarsdell May 12, 2020

Choose a reason for hiding this comment

Uh oh!

@benbarsdell benbarsdell May 12, 2020

Choose a reason for hiding this comment

Uh oh!

@benbarsdell benbarsdell May 12, 2020

Choose a reason for hiding this comment

Uh oh!

@benbarsdell benbarsdell May 12, 2020

Choose a reason for hiding this comment

Uh oh!

@benbarsdell benbarsdell May 12, 2020

Choose a reason for hiding this comment

Uh oh!

maddyscientist commented May 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Comments