-
Notifications
You must be signed in to change notification settings - Fork 18
-
This thread is meant to be a general place for open discussion concerning the state of SIP-3 (Transaction Insights).
The SIP is meant to define the transaction insight API
Beta Was this translation helpful? Give feedback.
All reactions
Replies: 3 comments 2 replies
-
How should the insights interact with the UI in terms of blocking?
Say an insight takes 30 seconds to calculate, will that mean that the pop-up won't show up during that time, or will the insight tab have a loading indicator?
Beta Was this translation helpful? Give feedback.
All reactions
-
The insight tab will have a loading indicator
Beta Was this translation helpful? Give feedback.
All reactions
-
👍 1
-
I think extending insights into message signing would be useful as well.
For example, we could have an insight that checks eth_signTypedData message for inclusion of a nonce property and warn that this kind of signature can result in replay attacks.
Beta Was this translation helpful? Give feedback.
All reactions
-
This is a great proposal. Can you elaborate on whether the tx information that is passed along also contains information about the URL of the Dapp? I think this would be extremely useful in context of a security snap plug in that warns users from txs that relate to scams/ phishing attacks.
Beta Was this translation helpful? Give feedback.
All reactions
-
Hi Christian, the tx object does not contain information about the referring dapp. The tx-insights API is not meant to be used to get that information anyway. There may be an API in the future that would allow this, but we do not have plans to implement it yet.
Beta Was this translation helpful? Give feedback.