-
-
Notifications
You must be signed in to change notification settings - Fork 38
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: samber/oops
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Could not load branches
Nothing to show
Loading
...
head repository: MathGaps/oops
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Could not load branches
Nothing to show
Loading
- 2 commits
- 3 files changed
- 1 contributor
Commits on Aug 4, 2025
-
fix: improve OopsError.Is() method to properly handle error comparisons
This commit improves the Is() method to correctly handle error comparisons without causing panics. The key improvements are: 1. Compare underlying errors when both OopsError instances have them 2. Only compare messages when neither has underlying errors 3. Handle mixed cases (one with underlying error, one without) correctly 4. Add proper recursive error chain traversal via errors.Is() 5. Remove redundant checks and simplify comparison logic 6. Add comprehensive test coverage for all comparison scenarios The fix ensures that: - errors.Is(wrappedErr, originalErr) works correctly for wrapped oops errors - Multiple levels of wrapping are handled properly - Different error instances with same messages are correctly distinguished - Standard error comparisons work as expected - No panics occur during error comparisons All existing tests pass, ensuring backward compatibility.
shubham030 committedAug 4, 2025 -
fix: update module path to github.com/MathGaps/oops
shubham030 committedAug 4, 2025
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...main