Commit 96b7ed3

cjwatsonfantix

and

authored

test: fix task name for Python 3.13.3/3.14 (#662)

* also fixed CI not to use Cython 3.1beta, which is breaking many uvloop tests --------- Co-authored-by: Fantix King <fantix.king@gmail.com>

1 parent 5680792 commit 96b7ed3Copy full SHA for 96b7ed3

File tree

-5

lines changed

-5

lines changed

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -57,8 +57,6 @@ jobs:`
`57`	`57`
`58`	`58`	`- name: Install Python Deps`
`59`	`59`	`if: steps.release.outputs.version == 0`
`60`		`- env:`
`61`		`- PIP_PRE: ${{ matrix.python-version == '3.13' && '1' \|\| '0' }}`
`62`	`60`	`run: \|`
`63`	`61`	`pip install -e .[test,dev]`
`64`	`62`

Lines changed: 8 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -576,9 +576,14 @@ def get_name(self):`
`576`	`576`	`async def coro():`
`577`	`577`	`pass`
`578`	`578`
`579`		`- factory = lambda loop, coro, **kwargs: MyTask(`
`580`		`- coro, loop=loop, **kwargs`
`581`		`- )`
	`579`	`+ def factory(loop, coro, **kwargs):`
	`580`	`+ task = MyTask(coro, loop=loop, **kwargs)`
	`581`	`+ # Python moved the responsibility to set the name to the Task`
	`582`	`+ # class constructor, so MyTask.set_name is never called by`
	`583`	`+ # Python's create_task. Compensate for that here.`
	`584`	`+ if self.is_asyncio_loop() and "name" in kwargs:`
	`585`	`+ task.set_name(kwargs["name"])`
	`586`	`+ return task`
`582`	`587`
`583`	`588`	`self.assertIsNone(self.loop.get_task_factory())`
`584`	`589`	`task = self.loop.create_task(coro(), name="mytask")`

Comments

(0)