Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit c52fd79

Browse files
Adding src atributte to Photo class
1 parent 596ea5a commit c52fd79

File tree

13 files changed

+27
-19
lines changed

13 files changed

+27
-19
lines changed

‎app/js/script.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,11 @@ const generateId = () => {
2020

2121
// Creamos un array que simule la base de datos donde se almacenan las fotos.
2222
const photos = [
23-
new Photo(generateId(), 'ejemploURL', 'ejemploSRC', 'Jose Molina', 'Caballos en montaña'),
24-
new Photo(generateId(), 'ejemploURL', 'ejemploSRC', 'Ignacio Fernandez', 'Gato saltando'),
25-
new Photo(generateId(), 'ejemploURL', 'ejemploSRC', 'Martin Caro', 'Autos de Formula 1'),
26-
new Photo(generateId(), 'ejemploURL', 'ejemploSRC', 'Beatriz Quiroga', 'Buenos Aires'),
27-
new Photo(generateId(), 'ejemploURL', 'ejemploSRC', 'Jose Molina', 'Persona en montaña')
23+
new Photo(generateId(), 'ejemploURL', '/dist/assets/images/caballomontaña.jpg', 'Jose Molina', 'Caballos en montaña'),
24+
new Photo(generateId(), 'ejemploURL', '/dist/assets/images/gatosaltando.jpg', 'Ignacio Fernandez', 'Gato saltando'),
25+
new Photo(generateId(), 'ejemploURL', '/dist/assets/images/formula1.jpg', 'Martin Caro', 'Autos de Formula 1'),
26+
new Photo(generateId(), 'ejemploURL', '/dist/assets/images/buenosaires.jpg', 'Beatriz Quiroga', 'Buenos Aires'),
27+
new Photo(generateId(), 'ejemploURL', '/dist/assets/images/personamontaña.jpg', 'Jose Molina', 'Persona en montaña')
2828
];
2929

3030
let errorAlert = document.getElementById('errorAlert');
@@ -82,7 +82,7 @@ const filterPhotos = (search) => {
8282
// Aplicando la función 'forEach' de orden superior. Por cada foto filtrada devolvemos un nuevo elemento para la galería.
8383
filteredPhotos.forEach((photo) => {
8484
// Llamamos la función que crea un nuevo elemento de la galería.
85-
createNewGalleryItem(`<h2>${photo.alt}</h2>`);
85+
createNewGalleryItem(`<img src="${photo.src}" alt="${photo.alt}"></img>`);
8686
});
8787
}
8888
}
@@ -91,7 +91,7 @@ const filterPhotos = (search) => {
9191
const getInitialRandomPhotos = () => {
9292
for (let i=1; i <= 8; i++){
9393
// Llamamos la función que crea un nuevo elemento de la galería.
94-
createNewGalleryItem(`<h2>Foto ${i}</h2>`);
94+
createNewGalleryItem(`<img src="/dist/assets/images/example (${i}).jpeg" alt="Foto(${i})"></img>`);
9595
}
9696
}
9797

‎app/scss/components/header.scss

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@ header{
99
background-size: cover;
1010
background-attachment: fixed;
1111

12+
@include mq-down(small){
13+
height: 50vh;
14+
}
15+
1216
.topbar{
1317
padding-block: 1rem;
1418

@@ -94,6 +98,10 @@ header{
9498
width: 100%;
9599
height: calc(100% - 225px);
96100

101+
@include mq-down(small){
102+
height: calc(100% - 118px);
103+
}
104+
97105
&__content{
98106
width: min(100% - 5rem, 500px);
99107
margin-inline: auto;

‎app/scss/util/theme.scss

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
// Header
2727
--clr-bg-header: #17191f;
2828
--clr-text-header: #e8e8e8;
29-
--clr-social-1: #182830;
29+
--clr-social-1: #1a1c22;
3030
--clr-social-2: #b8c8c8;
3131
--clr-social-3: #e8e8e8;
3232
// Gallery

‎dist/assets/images/buenosaires.jpg

535 KB
Loading[フレーム]

‎dist/assets/images/caballomontaña.jpg

659 KB
Loading[フレーム]

‎dist/assets/images/formula1.jpg

213 KB
Loading[フレーム]

‎dist/assets/images/gatosaltando.jpg

42.6 KB
Loading[フレーム]

‎dist/assets/images/personamontaña.jpg

113 KB
Loading[フレーム]

‎dist/script.js

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/script.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /