Commit 88e816c

Yupeng-liYupeng Li

and

Yupeng Li

authored

fix: Open YouTube video on a browser or YouTube app (iOS only) (#300)

* fix: Open YouTube video on a browser or YouTube app when tapping on the title or the YouTube logo on the player * Use console.warn instead of console.error when a youtube link cannot be opened. #codereviewchanges --------- Co-authored-by: Yupeng Li <yupeng.li@livingwith.health>

1 parent 2a3234c commit 88e816cCopy full SHA for 88e816c

File tree

1 file changed

+15

-5

lines changed

src
- YoutubeIframe.js

1 file changed

+15

-5

lines changed

`‎src/YoutubeIframe.js`

Lines changed: 15 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ import React, {`
`7`	`7`	`useCallback,`
`8`	`8`	`useImperativeHandle,`
`9`	`9`	`} from 'react';`
`10`		`-import {Platform, StyleSheet, View} from 'react-native';`
	`10`	`+import {Linking,Platform, StyleSheet, View} from 'react-native';`
`11`	`11`	`import {EventEmitter} from 'events';`
`12`	`12`	`import {WebView} from './WebView';`
`13`	`13`	`import {`
`@@ -211,10 +211,20 @@ const YoutubeIframe = (props, ref) => {`
`211`	`211`	`request => {`
`212`	`212`	`try {`
`213`	`213`	`const url = request.mainDocumentURL \|\| request.url;`
`214`		`- const iosFirstLoad = Platform.OS === 'ios' && url === 'about:blank';`
`215`		`- const shouldLoad =`
`216`		`- iosFirstLoad \|\| url.startsWith(baseUrlOverride \|\| DEFAULT_BASE_URL);`
`217`		`- return shouldLoad;`
	`214`	`+ if (Platform.OS === 'ios') {`
	`215`	`+ const iosFirstLoad = url === 'about:blank';`
	`216`	`+ if (iosFirstLoad) {`
	`217`	`+ return true;`
	`218`	`+ }`
	`219`	`+ const isYouTubeLink = url.startsWith('https://www.youtube.com/');`
	`220`	`+ if (isYouTubeLink) {`
	`221`	`+ Linking.openURL(url).catch(error => {`
	`222`	`+ console.warn('Error opening URL:', error);`
	`223`	`+ });`
	`224`	`+ return false;`
	`225`	`+ }`
	`226`	`+ }`
	`227`	`+ return url.startsWith(baseUrlOverride \|\| DEFAULT_BASE_URL);`
`218`	`228`	`} catch (error) {`
`219`	`229`	`// defaults to true in case of error`
`220`	`230`	`// returning false stops the video from loading`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 88e816c

File tree

1 file changed

1 file changed

`‎src/YoutubeIframe.js`

0 commit comments