Commit 584798d

YannickLeRouxLonelyCpp

authored and

committed

make videoId props optional

Shouldnt we make videoId optional if we want to pass just a playList? Ideally a conditional type should probably be created so we must have videoId or playList, but not both?

1 parent 7a627de commit 584798dCopy full SHA for 584798d

File tree

1 file changed

-1

lines changed

index.d.ts

1 file changed

-1

lines changed

`‎index.d.ts`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -60,7 +60,7 @@ export interface YoutubeIframeProps {`
`60`	`60`	`/**`
`61`	`61`	`* Specifies the YouTube Video ID of the video to be played.`
`62`	`62`	`*/`
`63`		`- videoId: string;`
	`63`	`+ videoId?: string;`
`64`	`64`	`/**`
`65`	`65`	`* Specifies the playlist to play. It can be either the playlist ID or a list of video IDs`
`66`	`66`	`*`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 584798d

File tree

1 file changed

1 file changed

`‎index.d.ts`

0 commit comments