Commit eef7106

committed

change progress location from window to notification

1 parent ac20b6c commit eef7106Copy full SHA for eef7106

File tree

-7

lines changed

-7

lines changed

Lines changed: 3 additions & 3 deletions

Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Lines changed: 1 addition & 1 deletion

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@ import * as vscode from "vscode";`
`5`	`5`	`import { LeetCodeNode } from "../leetCodeExplorer";`
`6`	`6`	`import { leetCodeManager } from "../leetCodeManager";`
`7`	`7`	`import { IQuickItemEx, languages, leetCodeBinaryPath, ProblemState } from "../shared";`
`8`		`-import { executeCommand } from "../utils/cpUtils";`
	`8`	`+import { executeCommandWithProgress } from "../utils/cpUtils";`
`9`	`9`	`import { DialogOptions, DialogType, promptForOpenOutputChannel, promptForSignIn } from "../utils/uiUtils";`
`10`	`10`	`import { selectWorkspaceFolder } from "../utils/workspaceUtils";`
`11`	`11`	`import * as wsl from "../utils/wslUtils";`
`@@ -50,7 +50,7 @@ async function showProblemInternal(id: string): Promise<void> {`
`50`	`50`
`51`	`51`	`const outdir: string = await selectWorkspaceFolder();`
`52`	`52`	`await fse.ensureDir(outdir);`
`53`		- const result: string = await executeCommand("node", [leetCodeBinaryPath, "show", id, "-gx", "-l", language, "-o", `"${outdir}"`]);
	`53`	+ const result: string = await executeCommandWithProgress("Fetching problem data...","node", [leetCodeBinaryPath, "show", id, "-gx", "-l", language, "-o", `"${outdir}"`]);
`54`	`54`	`const reg: RegExp = /\SourceCode:\s(.*)/;`
`55`	`55`	`const match: RegExpMatchArray \| null = result.match(reg);`
`56`	`56`	`if (match && match.length >= 2) {`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ export async function executeCommand(command: string, args: string[], options: c`
`34`	`34`
`35`	`35`	`export async function executeCommandWithProgress(message: string, command: string, args: string[], options: cp.SpawnOptions = { shell: true }): Promise<string> {`
`36`	`36`	`let result: string = "";`
`37`		`- await vscode.window.withProgress({ location: vscode.ProgressLocation.Window }, async (p: vscode.Progress<{}>) => {`
	`37`	`+ await vscode.window.withProgress({ location: vscode.ProgressLocation.Notification }, async (p: vscode.Progress<{}>) => {`
`38`	`38`	`return new Promise(async (resolve: () => void, reject: (e: Error) => void): Promise<void> => {`
`39`	`39`	`p.report({ message });`
`40`	`40`	`try {`

Comments

(0)