Commit 33b306b

SevInfmzgoddard

authored and

committed

fix: memory leak in TransformNormalModuleFactoryPlugin (mzgoddard#414)

Problem: plugin wraps createLoaderContext without checking if it was already done before. As a result, in a watch mode more and more wrappers get added on top of the function and eat more and more memory. Fixed by saving original function on module instance itself and wrapping saved function instead.

1 parent e370f1f commit 33b306bCopy full SHA for 33b306b

File tree

1 file changed

-3

lines changed

lib
- TransformNormalModuleFactoryPlugin.js

1 file changed

-3

lines changed

`‎lib/TransformNormalModuleFactoryPlugin.js`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,11 +38,12 @@ class NormalModuleFactoryPlugin {`
`38`	`38`	`'HardSource - TransformNormalModuleFactoryPlugin',`
`39`	`39`	`module => {`
`40`	`40`	`if (module.constructor.name === 'NormalModule') {`
`41`		`- const _createLoaderContext = module.createLoaderContext;`
	`41`	`+ module.__originalCreateLoaderContext =`
	`42`	`+ module.__originalCreateLoaderContext \|\|`
	`43`	`+ module.createLoaderContext;`
`42`	`44`	`module.__hardSource_resolved = {};`
`43`	`45`	`module.createLoaderContext = (...args) => {`
`44`		`- const loaderContext = _createLoaderContext.call(`
`45`		`- module,`
	`46`	`+ const loaderContext = module.__originalCreateLoaderContext(`
`46`	`47`	`...args,`
`47`	`48`	`);`
`48`	`49`	`const _resolve = loaderContext.resolve;`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 33b306b

File tree

1 file changed

1 file changed

`‎lib/TransformNormalModuleFactoryPlugin.js`

0 commit comments