This repository was archived by the owner on Feb 28, 2020. It is now read-only.

Commit ecf4f31

committed

fix: add Title case 'Revert' in header check

1 parent 735d7d3 commit ecf4f31Copy full SHA for ecf4f31

File tree

-2

lines changed

-2

lines changed

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -140,21 +140,22 @@ def check_header(header):`
`140`	`140`
`141`	`141`	`match = re.match(HEADER_PATTERN, header)`
`142`	`142`	`if not match:`
	`143`	+ # `.` not match newline in python, so `or not match.group(5).strip()` not necessary
`143`	`144`	`print_error_msg(ErrorEnum.BAD_HEADER_FORMAT, header=header)`
`144`	`145`	`return False`
`145`	`146`
`146`	`147`	`fixup_or_squash = bool(match.group(2))`
`147`	`148`	`type_ = match.group(3)`
`148`	`149`	`# scope = match.group(4) # TODO: 根据配置对scope检查`
`149`		`- # subject = bool(match.group(5)) # TODO: 根据规则对subject检查`
	`150`	`+ # subject = match.group(5) # TODO: 根据规则对subject检查`
`150`	`151`
`151`	`152`	`if type_ not in TYPE_LIST:`
`152`	`153`	`print_error_msg(ErrorEnum.WRONG_TYPE, type=type_)`
`153`	`154`
`154`	`155`	`# print(match.group(0, 1, 2, 3, 4, 5))`
`155`	`156`
`156`	`157`	`length = len(header)`
`157`		`- if length > LINE_LIMIT and not (fixup_or_squash or type_ == 'revert'):`
	`158`	`+ if length > LINE_LIMIT and not (fixup_or_squash or type_ == 'revert'ortype_=='Revert'):`
`158`	`159`	`print_error_msg(ErrorEnum.LINE_OVERLONG, length=length, line=header)`
`159`	`160`	`return False`
`160`	`161`

Comments

(0)