Commit 4f011a6

committed

Address comments

1 parent 389e868 commit 4f011a6Copy full SHA for 4f011a6

File tree

-5

lines changed

-5

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,7 @@ export abstract class PackageManagerOptionsConfigurationBase implements IPackage`
`265`	`265`	`export class NpmOptionsConfiguration extends PackageManagerOptionsConfigurationBase {`
`266`	`266`	`/** @internal */`
`267`	`267`	`public constructor(json: INpmOptionsJson) {`
`268`		`- super(json.environmentVariables);`
	`268`	`+ super(json);`
`269`	`269`	`}`
`270`	`270`	`}`
`271`	`271`
`@@ -327,7 +327,7 @@ export class PnpmOptionsConfiguration extends PackageManagerOptionsConfiguration`
`327`	`327`
`328`	`328`	`/** @internal */`
`329`	`329`	`public constructor(json: IPnpmOptionsJson, commonTempFolder: string) {`
`330`		`- super(json.environmentVariables);`
	`330`	`+ super(json);`
`331`	`331`	`this.pnpmStore = json.pnpmStore \|\| 'local';`
`332`	`332`	`if (EnvironmentConfiguration.pnpmStorePathOverride) {`
`333`	`333`	`this.pnpmStorePath = EnvironmentConfiguration.pnpmStorePathOverride;`
`@@ -362,7 +362,7 @@ export class YarnOptionsConfiguration extends PackageManagerOptionsConfiguration`
`362`	`362`
`363`	`363`	`/** @internal */`
`364`	`364`	`public constructor(json: IYarnOptionsJson) {`
`365`		`- super(json.environmentVariables);`
	`365`	`+ super(json);`
`366`	`366`	`this.ignoreEngines = !!json.ignoreEngines;`
`367`	`367`	`}`
`368`	`368`	`}`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -268,9 +268,9 @@ export abstract class PackageManager {`
`268`	`268`	`export type PackageManagerName = 'pnpm' \| 'npm' \| 'yarn';`
`269`	`269`
`270`	`270`	`// @public`
`271`		`-export class PackageManagerOptionsConfigurationBase implements IPackageManagerOptionsJsonBase {`
	`271`	`+export abstractclass PackageManagerOptionsConfigurationBase implements IPackageManagerOptionsJsonBase {`
`272`	`272`	`// @internal`
`273`		`- protected constructor(environmentVariables?:IConfigurationEnvironment);`
	`273`	`+ protected constructor(json:IPackageManagerOptionsJsonBase);`
`274`	`274`	`readonly environmentVariables?: IConfigurationEnvironment;`
`275`	`275`	`}`
`276`	`276`

Comments

(0)