Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 6feb032

Browse files
Change jshint to eslint and fix code
1 parent 4fd458d commit 6feb032

File tree

4 files changed

+180
-13
lines changed

4 files changed

+180
-13
lines changed

‎.eslintrc.yml

Lines changed: 173 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,173 @@
1+
env:
2+
es6: true
3+
node: true
4+
extends: 'eslint:recommended'
5+
globals:
6+
api: false
7+
rules:
8+
indent:
9+
- error
10+
- 2
11+
- SwitchCase: 1
12+
VariableDeclarator:
13+
var: 2
14+
let: 2
15+
const: 3
16+
MemberExpression: 1
17+
linebreak-style:
18+
- error
19+
- unix
20+
quotes:
21+
- error
22+
- single
23+
semi:
24+
- error
25+
- always
26+
eqeqeq:
27+
- error
28+
- always
29+
no-loop-func:
30+
- error
31+
strict:
32+
- error
33+
- global
34+
block-spacing:
35+
- error
36+
- always
37+
brace-style:
38+
- error
39+
- 1tbs
40+
- allowSingleLine: true
41+
camelcase:
42+
- error
43+
comma-style:
44+
- error
45+
- last
46+
comma-spacing:
47+
- error
48+
- before: false
49+
after: true
50+
eol-last:
51+
- error
52+
func-call-spacing:
53+
- error
54+
- never
55+
key-spacing:
56+
- error
57+
- beforeColon: false
58+
afterColon: true
59+
mode: minimum
60+
keyword-spacing:
61+
- error
62+
- before: true
63+
after: true
64+
overrides:
65+
function:
66+
after: false
67+
max-len:
68+
- error
69+
- code: 80
70+
ignoreUrls: true
71+
max-nested-callbacks:
72+
- error
73+
- max: 7
74+
new-cap:
75+
- error
76+
- newIsCap: true
77+
capIsNew: true
78+
properties: true
79+
new-parens:
80+
- error
81+
no-lonely-if:
82+
- error
83+
no-trailing-spaces:
84+
- error
85+
no-unneeded-ternary:
86+
- error
87+
no-whitespace-before-property:
88+
- error
89+
object-curly-spacing:
90+
- error
91+
- always
92+
operator-assignment:
93+
- error
94+
- always
95+
operator-linebreak:
96+
- error
97+
- after
98+
semi-spacing:
99+
- error
100+
- before: false
101+
after: true
102+
space-before-blocks:
103+
- error
104+
- always
105+
space-before-function-paren:
106+
- error
107+
- never
108+
space-in-parens:
109+
- error
110+
- never
111+
space-infix-ops:
112+
- error
113+
space-unary-ops:
114+
- error
115+
- words: true
116+
nonwords: false
117+
overrides:
118+
typeof: false
119+
no-unreachable:
120+
- error
121+
no-global-assign:
122+
- error
123+
no-self-compare:
124+
- error
125+
no-unmodified-loop-condition:
126+
- error
127+
no-constant-condition:
128+
- error
129+
- checkLoops: false
130+
no-console:
131+
- off
132+
no-useless-concat:
133+
- error
134+
no-useless-escape:
135+
- error
136+
no-shadow-restricted-names:
137+
- error
138+
no-use-before-define:
139+
- error
140+
- functions: false
141+
arrow-body-style:
142+
- error
143+
- as-needed
144+
arrow-spacing:
145+
- error
146+
no-confusing-arrow:
147+
- error
148+
- allowParens: true
149+
no-useless-computed-key:
150+
- error
151+
no-useless-rename:
152+
- error
153+
no-var:
154+
- error
155+
object-shorthand:
156+
- error
157+
- always
158+
prefer-arrow-callback:
159+
- error
160+
prefer-const:
161+
- error
162+
prefer-numeric-literals:
163+
- error
164+
prefer-rest-params:
165+
- error
166+
prefer-spread:
167+
- error
168+
rest-spread-spacing:
169+
- error
170+
- never
171+
template-curly-spacing:
172+
- error
173+
- never

‎.jshintrc

Lines changed: 0 additions & 4 deletions
This file was deleted.

‎JavaScript/badServer.js

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
11
'use strict';
22

33
// Dependencies
4-
global.api = {};
5-
api.http = require('http');
6-
api.fs = require('fs');
4+
const http = require('http');
5+
const fs = require('fs');
76

87
// Cache
98
const cache = {};
109

1110
// HTTP Server
12-
api.http.createServer((req, res) => {
11+
http.createServer((req, res) => {
1312

1413
// Parse cookies
1514
const cookie = req.headers.cookie;
@@ -44,7 +43,7 @@ api.http.createServer((req, res) => {
4443
if (req.method === 'GET') {
4544

4645
// Some business logic
47-
api.fs.readFile('./person.json', (err, data) => {
46+
fs.readFile('./person.json', (err, data) => {
4847
if (!err) {
4948
const obj = JSON.parse(data);
5049
obj.birth = new Date(obj.birth);
@@ -75,7 +74,7 @@ api.http.createServer((req, res) => {
7574
if (obj.name) obj.name = obj.name.trim();
7675
data = JSON.stringify(obj);
7776
cache[req.url] = data;
78-
api.fs.writeFile('./person.json', data, (err) => {
77+
fs.writeFile('./person.json', data, (err) => {
7978
if (!err) {
8079
res.writeHead(200);
8180
res.end('File saved');

‎JavaScript/goodServer.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
'use strict';
22

3-
global.api = {};
4-
api.http = require('http');
3+
const http = require('http');
54

65
const me = { name: 'jura', age: 22 };
76

@@ -19,7 +18,7 @@ const types = {
1918
function: (fn, req, res) => fn(req, res) + '',
2019
};
2120

22-
api.http.createServer((req, res) => {
21+
http.createServer((req, res) => {
2322
const data = routing[req.url];
2423
const result = types[typeof(data)](data, req, res);
2524
res.end(result);

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /