Skip to content

Navigation Menu

Sign in
Sign up

Claude/pr 389 type issue vtky29 - #391

Merged
Han5991 merged 1 commit into
renovate/major-js-unit-test-packages from
claude/pr-389-type-issue-vtky29
Sep 6, 2026
Merged

Claude/pr 389 type issue vtky29 #391
Han5991 merged 1 commit into
renovate/major-js-unit-test-packages from
claude/pr-389-type-issue-vtky29

Conversation

@Han5991

@Han5991 Han5991 commented Sep 6, 2026

Copy link
Copy Markdown
Owner

No description provided.

github-actions[bot] reacted with thumbs up emoji
Han5991 force-pushed the claude/pr-389-type-issue-vtky29 branch from fb802ac to 2381771 Compare September 6, 2026 21:56

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

🔍 Cloudflare 프리뷰

브랜치 프리뷰 (고정) https://claude-pr-389-type-issue-vtky29-blog.rewq5991.workers.dev
이 커밋 https://2f716875-blog.rewq5991.workers.dev
커밋 SHA 23817715bcdeec587effa1dd229ba0655f761e49

브랜치 프리뷰 주소는 커밋마다 바뀌지 않으니 리뷰 내내 그대로 쓰시면 됩니다.

프로덕션(blog.sangwook.dev)은 그대로입니다 — 이 단계는 버전만 올리고
트래픽을 옮기지 않습니다. Admin 로그인은 프리뷰에서 동작하지 않을 수 있습니다.

apps/react's test setup imported the root `@testing-library/jest-dom`
entry, which only pulls in `types/jest.d.ts` — that file augments the
global `jest.Matchers` interface, not vitest's `Assertion`.
This worked by accident: vitest 4 declared a global `jest` namespace and
chained its assertions through it (`@vitest/expect`:
`interface JestAssertion<T> extends jest.Matchers<void, T>`), so the
jest-only augmentation leaked into `expect`. vitest 5 removes that
bridge — `JestAssertion<R, T>` now extends `CustomMatcher<R>` and no
`jest` namespace is shipped — leaving every jest-dom matcher untyped
(56 TS2339 errors across the app's test files).
Import `@testing-library/jest-dom/vitest` instead, which augments the
`vitest` module directly. This is what apps/next.js already does, so the
three apps using jest-dom now share one convention.
The change is valid on both majors, so it lands independently of the
vitest 5 bump: full check-types + test + lint pass on vitest 4.1.11
(20/20) and on vitest 5.0.0 (20/20, 88 react tests green).
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01U8NHR2C6Fd82H1XBBme51p 
Han5991 force-pushed the claude/pr-389-type-issue-vtky29 branch from 2381771 to 1a6ea0e Compare September 6, 2026 21:59

claude Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

리뷰 요약

@testing-library/jest-domcatalog:(^7.0.1)로 올리는 renovate 브랜치 위에서, apps/react의 vitest setup import를 '@testing-library/jest-dom'에서 '@testing-library/jest-dom/vitest'로 바꾸는 1줄짜리 타입 수정입니다. apps/next.js/vitest.setup.ts·apps/blog/web/vitest.setup.ts가 이미 같은 서브패스로 import하고 있어 이번 변경이 그 컨벤션과 일치합니다. CI(CI, Claude Code Review)는 아직 진행 중이라 결과를 반영하지 못했습니다.

코드

지적 사항 없음.

확인했으나 문제 없음

  • import 경로가 major 버전(v7)의 vitest 서브패스 컨벤션과 일치하는지 — apps/next.js·apps/blog/web의 기존 setup 파일과 대조해 확인함
  • 워크스페이스 내 다른 jest-dom 참조(apps/react/package.jsoncatalog: 선언)와 충돌 없음
  • 변경 범위가 1개 파일·1줄로, 사이드 이펙트나 회귀 가능 지점 없음

확인하지 못한 범위: CI가 진행 중이라 최종 통과 여부는 확인하지 못했습니다.

Han5991 merged commit c42b148 into renovate/major-js-unit-test-packages Sep 6, 2026
3 checks passed
Han5991 deleted the claude/pr-389-type-issue-vtky29 branch September 6, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /