Commit 1a0c4d3

committed

fix: fixed potential error when hook suspends and error is accessed

1 parent 3b45b4d commit 1a0c4d3Copy full SHA for 1a0c4d3

File tree

+13

-1

lines changed

+13

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ function resultContainer<TValue>() {`
`19`	`19`	`return value as TValue`
`20`	`20`	`},`
`21`	`21`	`get error() {`
`22`		`- const { error } = results[results.length - 1]`
	`22`	`+ const { error } = results[results.length - 1]??{}`
`23`	`23`	`return error`
`24`	`24`	`}`
`25`	`25`	`}`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -52,4 +52,10 @@ describe('suspense hook tests', () => {`
`52`	`52`
`53`	`53`	`expect(result.current).toBe(undefined)`
`54`	`54`	`})`
	`55`	`+`
	`56`	`+ test('should return undefined if error is requested before suspension has resolved', async () => {`
	`57`	`+ const { result } = renderHook(() => useFetchName(true))`
	`58`	`+`
	`59`	`+ expect(result.error).toBe(undefined)`
	`60`	`+ })`
`55`	`61`	`})`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -52,4 +52,10 @@ describe('suspense hook tests', () => {`
`52`	`52`
`53`	`53`	`expect(result.current).toBe(undefined)`
`54`	`54`	`})`
	`55`	`+`
	`56`	`+ test('should return undefined if error is requested before suspension has resolved', async () => {`
	`57`	`+ const { result } = renderHook(() => useFetchName(true))`
	`58`	`+`
	`59`	`+ expect(result.error).toBe(undefined)`
	`60`	`+ })`
`55`	`61`	`})`

Comments

(0)