Commit bab38d9

committed

fix: stop appending container elements to document body

1 parent 4f2dd80 commit bab38d9Copy full SHA for bab38d9

File tree

-10

lines changed

-10

lines changed

Lines changed: 0 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,12 +11,10 @@ function createDomRenderer<TProps, TResult>(`
`11`	`11`	`{ wrapper }: RendererOptions<TProps>`
`12`	`12`	`) {`
`13`	`13`	`const container = document.createElement('div')`
`14`		`-`
`15`	`14`	`const testHarness = createTestHarness(rendererProps, wrapper)`
`16`	`15`
`17`	`16`	`return {`
`18`	`17`	`render(props?: TProps) {`
`19`		`- document.body.appendChild(container)`
`20`	`18`	`act(() => {`
`21`	`19`	`ReactDOM.render(testHarness(props), container)`
`22`	`20`	`})`
`@@ -30,7 +28,6 @@ function createDomRenderer<TProps, TResult>(`
`30`	`28`	`act(() => {`
`31`	`29`	`ReactDOM.unmountComponentAtNode(container)`
`32`	`30`	`})`
`33`		`- document.body.removeChild(container)`
`34`	`31`	`},`
`35`	`32`	`act`
`36`	`33`	`}`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,6 @@ function createNativeRenderer<TProps, TResult>(`
`10`	`10`	`{ wrapper }: RendererOptions<TProps>`
`11`	`11`	`) {`
`12`	`12`	`let container: ReactTestRenderer`
`13`		`-`
`14`	`13`	`const testHarness = createTestHarness(rendererProps, wrapper)`
`15`	`14`
`16`	`15`	`return {`

Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -11,12 +11,10 @@ function createServerRenderer<TProps, TResult>(`
`11`	`11`	`rendererProps: RendererProps<TProps, TResult>,`
`12`	`12`	`{ wrapper }: RendererOptions<TProps>`
`13`	`13`	`) {`
`14`		`- const container = document.createElement('div')`
`15`		`-`
`16`		`- const testHarness = createTestHarness(rendererProps, wrapper, false)`
`17`		`-`
`18`	`14`	`let renderProps: TProps \| undefined`
`19`	`15`	`let hydrated = false`
	`16`	`+ const container = document.createElement('div')`
	`17`	`+ const testHarness = createTestHarness(rendererProps, wrapper, false)`
`20`	`18`
`21`	`19`	`return {`
`22`	`20`	`render(props?: TProps) {`
`@@ -30,7 +28,6 @@ function createServerRenderer<TProps, TResult>(`
`30`	`28`	`if (hydrated) {`
`31`	`29`	`throw new Error('The component can only be hydrated once')`
`32`	`30`	`} else {`
`33`		`- document.body.appendChild(container)`
`34`	`31`	`act(() => {`
`35`	`32`	`ReactDOM.hydrate(testHarness(renderProps), container)`
`36`	`33`	`})`
`@@ -49,7 +46,6 @@ function createServerRenderer<TProps, TResult>(`
`49`	`46`	`if (hydrated) {`
`50`	`47`	`act(() => {`
`51`	`48`	`ReactDOM.unmountComponentAtNode(container)`
`52`		`- document.body.removeChild(container)`
`53`	`49`	`})`
`54`	`50`	`}`
`55`	`51`	`},`

Comments

(0)