Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 13b329e

Browse files
committed
Consistent use of quotename instead of concatenating in brackets
1 parent 18cb6f6 commit 13b329e

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

‎ExtractDB/Schema.sql

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ BEGIN
144144
FROM #ColumnData
145145
Order by column_id
146146

147-
SET @SQL = @SQL + @FirstColumn + ' [' + @ColumnName + '] '
147+
SET @SQL = @SQL + @FirstColumn + ' ' + QUOTENAME( @ColumnName) + ' '
148148

149149
if @ColIsComputed = 0
150150
BEGIN
@@ -201,7 +201,7 @@ BEGIN
201201
END
202202

203203
SET @SQL = @SQL +
204-
ISNULL((SELECT CHAR(9) + ', CONSTRAINT [' + k.name + '] PRIMARY KEY (' +
204+
ISNULL((SELECT CHAR(9) + ', CONSTRAINT ' + QUOTENAME( k.name) + ' PRIMARY KEY (' +
205205
(SELECT STUFF((
206206
SELECT ', [' + c.name + '] ' + CASE WHEN ic.is_descending_key = 1 THEN 'DESC' ELSE 'ASC' END
207207
FROM sys.index_columns ic WITH (NOWAIT)
@@ -215,7 +215,7 @@ BEGIN
215215
WHERE k.parent_object_id = @TableObjectId
216216
AND k.[type] = 'PK'), '') + ')' + CHAR(13)
217217

218-
SET @SQL = 'CREATE TABLE ' + @SchemaName + '.' + @TableName + ' (' + @SQL ;
218+
SET @SQL = 'CREATE TABLE ' + QUOTENAME( @SchemaName) + '.' + QUOTENAME( @TableName) + ' (' + @SQL ;
219219

220220
IF @DropAndRecreate = 1
221221
INSERT INTO @Scripts
@@ -228,7 +228,7 @@ BEGIN
228228

229229
'Alter',
230230
@TableName,
231-
'DROP TABLE ' + @SchemaName + '.' + @TableName
231+
'DROP TABLE ' + QuoteName( @SchemaName ) + '.' + QUOTENAME( @TableName )
232232
)
233233

234234
INSERT INTO @Scripts
@@ -282,7 +282,7 @@ BEGIN
282282
ELSE ''
283283
END AS [IndexType]
284284
,STUFF((
285-
SELECT ', [' + sc.NAME +']' AS "text()"
285+
SELECT ', ' + quotename( sc.NAME ) AS "text()"
286286
FROM syscolumns AS sc
287287
INNER JOIN sys.index_columns AS ic ON ic.object_id = sc.id
288288
AND ic.column_id = sc.colid
@@ -330,7 +330,7 @@ BEGIN
330330
@IndexIncludedColumns = IncludedColumns
331331
FROM @Indices
332332

333-
SET @SQL = 'CREATE ' + @IndexType + ' INDEX ' + @IndexName + ' ON ' + @SchemaName + '.' + @TableName + ' ( ' + @IndexedColumns + ') '
333+
SET @SQL = 'CREATE ' + @IndexType + ' INDEX ' + QUOTENAME(@IndexName) + ' ON ' + QUOTENAME(@SchemaName) + '.' + QUOTENAME(@TableName) + ' ( ' + @IndexedColumns + ') '
334334

335335
if not @IndexIncludedColumns is null
336336
BEGIN
@@ -371,7 +371,7 @@ END
371371
'ALTER TABLE '
372372
+ QUOTENAME(cs.name) + '.' + QUOTENAME(ct.name)
373373
+ ' ADD CONSTRAINT ' + QUOTENAME(fk.name)
374-
+ ' FOREIGN KEY (' + STUFF((SELECT ',' + QUOTENAME(c.name)
374+
+ ' FOREIGN KEY (' + STUFF((SELECT ',' + QUOTENAME(c.name)+' '
375375
-- get all the columns in the constraint table
376376
FROM sys.columns AS c
377377
INNER JOIN sys.foreign_key_columns AS fkc

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /