Commit 3a5bc3a

committed

constexpr+noexcept PluginLogWriter

1 parent 90606b0 commit 3a5bc3aCopy full SHA for 3a5bc3a

File tree

2 files changed

-8

lines changed

src/utilities/ntrace
- PluginLogWriter.cpp
- PluginLogWriter.h

2 files changed

-8

lines changed

`‎src/utilities/ntrace/PluginLogWriter.cpp`

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ void strerror_r(int err, char* buf, size_t bufSize)`
`53`	`53`	`}`
`54`	`54`	`#endif`
`55`	`55`
`56`		`-void getMappedFileName(PathName& file, PathName& mapFile)`
	`56`	`+void getMappedFileName(constPathName& file, PathName& mapFile)`
`57`	`57`	`{`
`58`	`58`	`const ULONG hash = file.hash(0xFFFFFFFF);`
`59`	`59`	`mapFile.printf("%s_%08x", FB_TRACE_LOG_MUTEX, hash);`
`@@ -239,7 +239,7 @@ FB_SIZE_T PluginLogWriter::write_s(CheckStatusWrapper* status, const void* buf,`
`239`	`239`	`{`
`240`	`240`	`return write(buf, size);`
`241`	`241`	`}`
`242`		`- catch (Exception &ex)`
	`242`	`+ catch (constException &ex)`
`243`	`243`	`{`
`244`	`244`	`ex.stuffException(status);`
`245`	`245`	`}`
`@@ -264,7 +264,7 @@ void PluginLogWriter::checkErrno(const char* operation)`
`264`	`264`	`operation, m_fileName.c_str(), strErr);`
`265`	`265`	`}`
`266`	`266`
`267`		`-void PluginLogWriter::mutexBug(int state, const TEXT* string)`
	`267`	`+void PluginLogWriter::mutexBug(int state, const char* string)`
`268`	`268`	`{`
`269`	`269`	`TEXT msg[BUFFER_TINY];`
`270`	`270`	`snprintf(msg, sizeof(msg), "PluginLogWriter: mutex %s error, status = %d", string, state);`
`@@ -292,11 +292,11 @@ void PluginLogWriter::unlock()`
`292`	`292`	`}`
`293`	`293`
`294`	`294`
`295`		`-const unsigned int IDLE_TIMEOUT = 30; // seconds`
	`295`	`+constexpr unsigned int IDLE_TIMEOUT = 30; // seconds`
`296`	`296`
`297`	`297`	`void PluginLogWriter::setupIdleTimer(bool clear)`
`298`	`298`	`{`
`299`		`- unsigned int timeout = clear ? 0 : IDLE_TIMEOUT;`
	`299`	`+ constunsigned int timeout = clear ? 0 : IDLE_TIMEOUT;`
`300`	`300`	`if (!timeout)`
`301`	`301`	`{`
`302`	`302`	`if (m_idleTimer)`

`‎src/utilities/ntrace/PluginLogWriter.h`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -62,11 +62,11 @@ class PluginLogWriter final :`
`62`	`62`	`~PluginLogWriter();`
`63`	`63`
`64`	`64`	`// TraceLogWriter implementation`
`65`		`- virtualFB_SIZE_T write(const void* buf, FB_SIZE_T size) override;`
`66`		`- virtualFB_SIZE_T write_s(Firebird::CheckStatusWrapper* status, const void* buf, unsigned size) override;`
	`65`	`+ FB_SIZE_T write(const void* buf, FB_SIZE_T size) override;`
	`66`	`+ FB_SIZE_T write_s(Firebird::CheckStatusWrapper* status, const void* buf, FB_SIZE_T size) override;`
`67`	`67`
`68`	`68`	`private:`
`69`		`- const USHORT PLUGIN_LOG_VERSION = 1;`
	`69`	`+ staticconstexpr USHORT PLUGIN_LOG_VERSION = 1;`
`70`	`70`
`71`	`71`	`SINT64 seekToEnd();`
`72`	`72`	`void reopen();`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit 3a5bc3a

File tree

2 files changed

2 files changed

`‎src/utilities/ntrace/PluginLogWriter.cpp`

`‎src/utilities/ntrace/PluginLogWriter.h`

0 commit comments