forked from gitpython-developers/GitPython
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit 965031d
committed
Remove obsolete note in _iter_packed_refs
This removes a comment noting that a try-finally block had been
present (or had been intended), but was removed because some
version of Python had imposed a limitation on yield appearing in
try-finally.
That comment was obsolete as of 58c5b99 (gitpython-developers#326), which wrapped the
relevant code in a with-statement, because:
1. Since then, the cleanup is done in a manner equivaent to
try-finally.
2. It turned out, as noted in that PR, that cleanup had not
always been done automatically. (This was contrary to the
prediction given in the comment.)
3. At some point before that, the limitation that had prevented
the use of try-finally no longer affected any supported version
of Python.
Specifically, it appears the only limitation that this could be
was the limitation lifted in Python 2.5, where along with the
addition of the close() method which causes try-finally to be
called (and is itself called when a generator object is
finalized), yield in a try-block with an associated
finally-block became permitted, since the call to close() was
sufficient to run the finally-block (by raising GeneratorExit).
For details, see:
https://docs.python.org/3/whatsnew/2.5.html#pep-342-new-generator-features
(This obsolete comment was one of the things I discovered while
working on gitpython-developers#1725, but I didn't include this change there, having
not yet looked into the history of the code enough to be sure.)1 parent 1755b1d commit 965031d
1 file changed
+0
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
149 | 149 | | |
150 | 150 | | |
151 | 151 | | |
152 | - | ||
153 | - | ||
154 | - | ||
155 | - | ||
156 | 152 | | |
157 | 153 | | |
158 | 154 | | |
| |||
0 commit comments