Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 708fedc

Browse files
Merge pull request clearloop#11 from hulufei/master
Improve `pick` command to display more html entities properly
2 parents b5d0ea5 + faf2169 commit 708fedc

File tree

2 files changed

+7
-18
lines changed

2 files changed

+7
-18
lines changed

‎Cargo.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,12 @@ serde_derive = "1.0.104"
3131
serde_json = "1.0.44"
3232
pyo3 = "0.8.5"
3333
toml = "0.5.5"
34+
escaper = "0.1.0"
3435

3536
[dependencies.diesel]
3637
version = "1.4.3"
3738
features = ["sqlite"]
3839

3940
[dependencies.reqwest]
4041
version = "0.10.3"
41-
features = ["blocking", "gzip", "json"]
42+
features = ["blocking", "gzip", "json"]

‎src/helper.rs

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ mod filter {
9494
mod html {
9595
// use crate::Error;
9696
use colored::Colorize;
97+
use escaper::decode_html;
9798
pub enum Token {
9899
Plain(String),
99100
Bold(String),
@@ -109,15 +110,7 @@ mod html {
109110
impl HTML for String {
110111
fn ser(&self) -> Vec<Token> {
111112
// empty tags
112-
let mut tks = self.to_string();
113-
114-
// converting symbols
115-
tks = tks
116-
.replace(r#"&amp;"#, "&")
117-
.replace(r#"&quot;"#, "\"")
118-
.replace(r#"&nbsp;"#, " ")
119-
.replace(r#"&#39;"#, "'");
120-
113+
let tks = self.to_string();
121114
let res: Vec<Token>;
122115
// styled
123116
{
@@ -180,14 +173,9 @@ mod html {
180173
}
181174

182175
// post replace
183-
let mut tks = tks.join("");
184-
tks = tks
185-
.replace(r#"&lt;"#, "<")
186-
.replace(r#"&gt;"#, ">")
187-
.replace(r#"&ge;"#, ">=")
188-
.replace(r#"&le;"#, "<=");
189-
190-
tks
176+
let tks = tks.join("");
177+
178+
decode_html(&tks).unwrap_or(tks)
191179
}
192180
}
193181
}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /