-
Notifications
You must be signed in to change notification settings - Fork 5
Upgrade @databiosphere/findable-ui to v53.1.0 #4843
Description
Summary
Upgrade @databiosphere/findable-ui from 52.2.0 → ^53.1.0 and adopt the breaking changes from the v53.0.0 release.
Breaking changes from v53.0.0
Two breaking changes since 52.2.0 (per the findable-ui changelog):
- Keep recent matrix service requests in local storage and list for users #914 — Removed deprecated
Markdowncomponent andisomorphic-dompurifypeer dependency. Consumers should migrate toMarkdownRenderer(unified/remark/rehype-react, sanitised at the AST stage viarehype-sanitize). - Allow creation of full manifest for any selection, as we do for compact ones #912 — Filter popover placement flip when bottom-anchored. UI-only behaviour change, no consumer code change required.
Changes for this consumer (data-biosphere)
- Bump dep —
"@databiosphere/findable-ui": "^53.1.0". - Remove
isomorphic-dompurifyfromdependencies— no longer a findable-ui peer, and no direct usages inapp/,pages/, orsite-config/. - Migrate
Markdown→MarkdownRendererin three places (the only usages in the repo):app/components/index.tsx(barrel re-export)app/viewModelBuilders/catalog/anvil-catalog/common/viewModelBuilders.ts(buildStudyDescription, prop namecontent→value)site-config/anvil-catalog/dev/detail/study/overviewMainColumn.ts(component config reference)
Peer-dependency audit
All other findable-ui peer dependencies (emotion, MUI v7, tanstack, ky, next, react 19, rehype/remark/unified, yup, etc.) are already satisfied by data-biosphere's current dependencies. next-auth is optional in findable-ui and not used here.
react-gtm-module was removed as a findable-ui peer in v52.0.0, but data-biosphere imports it directly in pages/_app.tsx, so it stays in this repo's dependencies as consumer-owned.
Acceptance criteria
-
package.jsonbumped to^53.1.0 -
isomorphic-dompurifyremoved fromdependencies -
Markdown→MarkdownRenderermigration in the three files above -
npx tsc --noEmitpasses -
npm run lintandnpm run check-formatpass - Build succeeds for at least one config (e.g.
npm run build:anvil-cmg) - Manual smoke test: open the anvil-catalog study detail page in
dev:anvil-catalogand verify the Description section still renders correctly (the new renderer applies MUI Typography styles; visual output may shift slightly)
Out of scope
The collapsible Terra info work (#4816, branch fran/4816-collapsable-terra-info) depends on findable-ui v53 features but is tracked separately. After this upgrade lands, that branch should rebase onto main.