Commit 909426e

committed

Make ImageVolumeSource.Reference required via OpenAPI

OpenAPI validation does not count toward the CRD XValidation CEL budget.

1 parent da69a57 commit 909426eCopy full SHA for 909426e

File tree

5 files changed

+153

-90

lines changed

config/crd/bases
- postgres-operator.crunchydata.com_pgadmins.yaml
- postgres-operator.crunchydata.com_postgresclusters.yaml
internal/crd
- post-process.jq
pkg/apis/postgres-operator.crunchydata.com/v1beta1
- postgrescluster_types.go
- shared_types.go

5 files changed

+153

-90

lines changed

`‎config/crd/bases/postgres-operator.crunchydata.com_pgadmins.yaml‎`

Lines changed: 9 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -2629,6 +2629,11 @@ spec:`
`2629`	`2629`	`Never: the kubelet never pulls the reference and only uses a local image or artifact. Container creation will fail if the reference isn't present.`
`2630`	`2630`	`IfNotPresent: the kubelet pulls if the reference isn't already present on disk. Container creation will fail if the reference isn't present and the pull fails.`
`2631`	`2631`	`Defaults to Always if :latest tag is specified, or IfNotPresent otherwise.`
	`2632`	`+ enum:`
	`2633`	`+ - Always`
	`2634`	`+ - Never`
	`2635`	`+ - IfNotPresent`
	`2636`	`+ maxLength: 12`
`2632`	`2637`	`type: string`
`2633`	`2638`	`reference:`
`2634`	`2639`	`description: \|-`
`@@ -2638,7 +2643,10 @@ spec:`
`2638`	`2643`	`More info: https://kubernetes.io/docs/concepts/containers/images`
`2639`	`2644`	`This field is optional to allow higher level config management to default or override`
`2640`	`2645`	`container images in workload controllers like Deployments and StatefulSets.`
	`2646`	`+ minLength: 1`
`2641`	`2647`	`type: string`
	`2648`	`+ required:`
	`2649`	`+ - reference`
`2642`	`2650`	`type: object`
`2643`	`2651`	`name:`
`2644`	`2652`	`description: \|-`
`@@ -2659,11 +2667,8 @@ spec:`
`2659`	`2667`	`x-kubernetes-validations:`
`2660`	`2668`	`- message: you must set only one of image or claimName`
`2661`	`2669`	`rule: has(self.claimName) != has(self.image)`
`2662`		`- - message: readOnly cannot be set false when using an ImageVolumeSource`
	`2670`	`+ - message: image volumes must be readOnly`
`2663`	`2671`	`rule: '!has(self.image) \|\| !has(self.readOnly) \|\| self.readOnly'`
`2664`		`- - message: if using an ImageVolumeSource, you must set a reference`
`2665`		`- rule: '!has(self.image) \|\| (self.?image.reference.hasValue()`
`2666`		`- && self.image.reference.size() > 0)'`
`2667`	`2672`	`maxItems: 10`
`2668`	`2673`	`type: array`
`2669`	`2674`	`x-kubernetes-list-map-keys:`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 909426e

File tree

5 files changed

5 files changed

`‎config/crd/bases/postgres-operator.crunchydata.com_pgadmins.yaml‎`

0 commit comments