Commit abc8991

dimrocmattn

authored and

committed

column types text, varchar, *char return as strings:

As opposed to []byte arrays. This brings sqlite closer in line with other dbs like postgres, allowing downstream consumers to assume the scanned value is string across underlying dbs.

1 parent 3fa1c55 commit abc8991Copy full SHA for abc8991

File tree

1 file changed

-2

lines changed

sqlite3.go

1 file changed

-2

lines changed

`‎sqlite3.go`

Lines changed: 8 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -223,6 +223,7 @@ var SQLiteTimestampFormats = []string{`
`223`	`223`	`const (`
`224`	`224`	`columnDate string = "date"`
`225`	`225`	`columnDatetime string = "datetime"`
	`226`	`+ columnText string = "text"`
`226`	`227`	`columnTimestamp string = "timestamp"`
`227`	`228`	`)`
`228`	`229`
`@@ -2061,10 +2062,15 @@ func (rc *SQLiteRows) Next(dest []driver.Value) error {`
`2061`	`2062`	`t = t.In(rc.s.c.loc)`
`2062`	`2063`	`}`
`2063`	`2064`	`dest[i] = t`
	`2065`	`+ case columnText:`
	`2066`	`+ dest[i] = s`
`2064`	`2067`	`default:`
`2065`		`- dest[i] = []byte(s)`
	`2068`	`+ if strings.Contains(strings.ToLower(rc.decltype[i]), "char") {`
	`2069`	`+ dest[i] = s`
	`2070`	`+ } else {`
	`2071`	`+ dest[i] = []byte(s)`
	`2072`	`+ }`
`2066`	`2073`	`}`
`2067`		`-`
`2068`	`2074`	`}`
`2069`	`2075`	`}`
`2070`	`2076`	`return nil`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit abc8991

File tree

1 file changed

1 file changed

`‎sqlite3.go`

0 commit comments