Commit d869054

authored

Allow empty header values (yhirose#1965)

1 parent 0cc1ca9 commit d869054Copy full SHA for d869054

File tree

+10

-1

lines changed

+10

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4115,7 +4115,7 @@ inline bool parse_header(const char beg, const char end, T fn) {`
`4115`	`4115`	`p++;`
`4116`	`4116`	`}`
`4117`	`4117`
`4118`		`- if (p < end) {`
	`4118`	`+ if (p <= end) {`
`4119`	`4119`	`auto key_len = key_end - beg;`
`4120`	`4120`	`if (!key_len) { return false; }`
`4121`	`4121`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4922,6 +4922,15 @@ TEST(ServerRequestParsingTest, InvalidFieldValueContains_CR_LF_NUL) {`
`4922`	`4922`	`EXPECT_EQ("HTTP/1.1 400 Bad Request", out.substr(0, 24));`
`4923`	`4923`	`}`
`4924`	`4924`
	`4925`	`+TEST(ServerRequestParsingTest, EmptyFieldValue) {`
	`4926`	`+ std::string out;`
	`4927`	`+`
	`4928`	`+ test_raw_request("GET /header_field_value_check HTTP/1.1\r\n"`
	`4929`	`+ "Test: \r\n\r\n",`
	`4930`	`+ &out);`
	`4931`	`+ EXPECT_EQ("HTTP/1.1 200 OK", out.substr(0, 15));`
	`4932`	`+}`
	`4933`	`+`
`4925`	`4934`	`TEST(ServerStopTest, StopServerWithChunkedTransmission) {`
`4926`	`4935`	`Server svr;`
`4927`	`4936`

Comments

(0)