Commit 766dd9d

authored

Fix a null pointer crash in cJSON_ReplaceItemViaPointer (DaveGamble#726)

If the parent passed in cJSON_ReplaceItemViaPointer has not a child, which means parent->child is null, a null pointer dereference crash will be happened inside cJSON_ReplaceItemViaPointer. This commit adds the NULL check of `parent->child` beforehand to inform user such incorrect usage. Signed-off-by: hopper-vul <hopper.vul@gmail.com>

1 parent b45f48e commit 766dd9dCopy full SHA for 766dd9d

File tree

1 file changed

-1

lines changed

cJSON.c

1 file changed

-1

lines changed

`‎cJSON.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2291,7 +2291,7 @@ CJSON_PUBLIC(cJSON_bool) cJSON_InsertItemInArray(cJSON *array, int which, cJSON`
`2291`	`2291`
`2292`	`2292`	`CJSON_PUBLIC(cJSON_bool) cJSON_ReplaceItemViaPointer(cJSON * const parent, cJSON * const item, cJSON * replacement)`
`2293`	`2293`	`{`
`2294`		`- if ((parent == NULL) \|\| (replacement == NULL) \|\| (item == NULL))`
	`2294`	`+ if ((parent == NULL) \|\| (parent->child==NULL) \|\| (replacement == NULL) \|\| (item == NULL))`
`2295`	`2295`	`{`
`2296`	`2296`	`return false;`
`2297`	`2297`	`}`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 766dd9d

File tree

1 file changed

1 file changed

`‎cJSON.c`

0 commit comments