Commit 19396a4

committed

update comments and add tests for cJSON_SetValuestring

1 parent 5671646 commit 19396a4Copy full SHA for 19396a4

File tree

-1

lines changed

-1

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -397,6 +397,7 @@ CJSON_PUBLIC(double) cJSON_SetNumberHelper(cJSON *object, double number)`
`397`	`397`	`return object->valuedouble = number;`
`398`	`398`	`}`
`399`	`399`
	`400`	`+/* Note: when passing a NULL valuestring, cJSON_SetValuestring treats this as an error and return NULL */`
`400`	`401`	`CJSON_PUBLIC(char) cJSON_SetValuestring(cJSON object, const char *valuestring)`
`401`	`402`	`{`
`402`	`403`	`char *copy = NULL;`
`@@ -405,7 +406,7 @@ CJSON_PUBLIC(char) cJSON_SetValuestring(cJSON object, const char *valuestring)`
`405`	`406`	`{`
`406`	`407`	`return NULL;`
`407`	`408`	`}`
`408`		`- /* return NULL if the object is corrupted */`
	`409`	`+ /* return NULL if the object is corrupted or valuestring is NULL */`
`409`	`410`	`if (object->valuestring == NULL \|\| valuestring == NULL)`
`410`	`411`	`{`
`411`	`412`	`return NULL;`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -444,6 +444,7 @@ static void cjson_functions_should_not_crash_with_null_pointers(void)`
`444`	`444`	`TEST_ASSERT_FALSE(cJSON_Compare(NULL, item, false));`
`445`	`445`	`TEST_ASSERT_NULL(cJSON_SetValuestring(NULL, "test"));`
`446`	`446`	`TEST_ASSERT_NULL(cJSON_SetValuestring(corruptedString, "test"));`
	`447`	`+ TEST_ASSERT_NULL(cJSON_SetValuestring(item, NULL));`
`447`	`448`	`cJSON_Minify(NULL);`
`448`	`449`	`/* skipped because it is only used via a macro that checks for NULL */`
`449`	`450`	`/* cJSON_SetNumberHelper(NULL, 0); */`

Comments

(0)