Commit b3cffa3

authored

Remove unchecked indexed set on normal arrays (#2586)

1 parent 378659a commit b3cffa3Copy full SHA for b3cffa3

File tree

+4636

-2521

lines changed

+4636

-2521

lines changed

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -131,10 +131,6 @@ export class Array<T> {`
`131`	`131`	`ensureCapacity(changetype<usize>(this), index + 1, alignof<T>());`
`132`	`132`	`this.length_ = index + 1;`
`133`	`133`	`}`
`134`		`- this.__uset(index, value);`
`135`		`- }`
`136`		`-`
`137`		`- @unsafe @operator("{}=") private __uset(index: i32, value: T): void {`
`138`	`134`	`store<T>(this.dataStart + (<usize>index << alignof<T>()), value);`
`139`	`135`	`if (isManaged<T>()) {`
`140`	`136`	`__link(changetype<usize>(this), changetype<usize>(value), true);`

Lines changed: 7 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -2840,18 +2840,6 @@`
`2840`	`2840`	`i32.store 0ドル offset=8`
`2841`	`2841`	`end`
`2842`	`2842`	`)`
`2843`		`- (func $~lib/array/Array<i32>#__uset (type $i32_i32_i32_=>_none) (param $this i32) (param $index i32) (param $value i32)`
`2844`		`- local.get $this`
`2845`		`- call $~lib/array/Array<i32>#get:dataStart`
`2846`		`- local.get $index`
`2847`		`- i32.const 2`
`2848`		`- i32.shl`
`2849`		`- i32.add`
`2850`		`- local.get $value`
`2851`		`- i32.store 0ドル`
`2852`		`- i32.const 0`
`2853`		`- drop`
`2854`		`- )`
`2855`	`2843`	`(func $~lib/array/Array<i32>#__set (type $i32_i32_i32_=>_none) (param $this i32) (param $index i32) (param $value i32)`
`2856`	`2844`	`local.get $index`
`2857`	`2845`	`local.get $this`
`@@ -2883,9 +2871,15 @@`
`2883`	`2871`	`call $~lib/array/Array<i32>#set:length_`
`2884`	`2872`	`end`
`2885`	`2873`	`local.get $this`
	`2874`	`+ call $~lib/array/Array<i32>#get:dataStart`
`2886`	`2875`	`local.get $index`
	`2876`	`+ i32.const 2`
	`2877`	`+ i32.shl`
	`2878`	`+ i32.add`
`2887`	`2879`	`local.get $value`
`2888`		`- call $~lib/array/Array<i32>#__uset`
	`2880`	`+ i32.store 0ドル`
	`2881`	`+ i32.const 0`
	`2882`	`+ drop`
`2889`	`2883`	`)`
`2890`	`2884`	`(func $bindings/esm/PlainObject#set:a (type $i32_i32_=>_none) (param $this i32) (param $a i32)`
`2891`	`2885`	`local.get $this`

Lines changed: 7 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -2843,18 +2843,6 @@`
`2843`	`2843`	`i32.store 0ドル offset=8`
`2844`	`2844`	`end`
`2845`	`2845`	`)`
`2846`		`- (func $~lib/array/Array<i32>#__uset (type $i32_i32_i32_=>_none) (param $this i32) (param $index i32) (param $value i32)`
`2847`		`- local.get $this`
`2848`		`- call $~lib/array/Array<i32>#get:dataStart`
`2849`		`- local.get $index`
`2850`		`- i32.const 2`
`2851`		`- i32.shl`
`2852`		`- i32.add`
`2853`		`- local.get $value`
`2854`		`- i32.store 0ドル`
`2855`		`- i32.const 0`
`2856`		`- drop`
`2857`		`- )`
`2858`	`2846`	`(func $~lib/array/Array<i32>#__set (type $i32_i32_i32_=>_none) (param $this i32) (param $index i32) (param $value i32)`
`2859`	`2847`	`local.get $index`
`2860`	`2848`	`local.get $this`
`@@ -2886,9 +2874,15 @@`
`2886`	`2874`	`call $~lib/array/Array<i32>#set:length_`
`2887`	`2875`	`end`
`2888`	`2876`	`local.get $this`
	`2877`	`+ call $~lib/array/Array<i32>#get:dataStart`
`2889`	`2878`	`local.get $index`
	`2879`	`+ i32.const 2`
	`2880`	`+ i32.shl`
	`2881`	`+ i32.add`
`2890`	`2882`	`local.get $value`
`2891`		`- call $~lib/array/Array<i32>#__uset`
	`2883`	`+ i32.store 0ドル`
	`2884`	`+ i32.const 0`
	`2885`	`+ drop`
`2892`	`2886`	`)`
`2893`	`2887`	`(func $bindings/esm/PlainObject#set:a (type $i32_i32_=>_none) (param $this i32) (param $a i32)`
`2894`	`2888`	`local.get $this`

Comments

(0)