Commit 7ccadf0

authored

fix: Diagnose not yet implemented 'in' operator (#2629)

1 parent 4535263 commit 7ccadf0Copy full SHA for 7ccadf0

File tree

+25

-1

lines changed

+25

-1

lines changed

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -4662,6 +4662,14 @@ export class Compiler extends DiagnosticEmitter {`
`4662`	`4662`	`}`
`4663`	`4663`	`break;`
`4664`	`4664`	`}`
	`4665`	`+ case Token.In: {`
	`4666`	`+ this.error(`
	`4667`	`+ DiagnosticCode.Not_implemented_0,`
	`4668`	`+ expression.range, "'in' operator"`
	`4669`	`+ );`
	`4670`	`+ this.currentType = Type.bool;`
	`4671`	`+ return module.unreachable();`
	`4672`	`+ }`
`4665`	`4673`	`default: {`
`4666`	`4674`	`assert(false);`
`4667`	`4675`	`expr = this.module.unreachable();`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4311,7 +4311,8 @@ export class Parser extends DiagnosticEmitter {`
`4311`	`4311`	`case Token.Bar:`
`4312`	`4312`	`case Token.Caret:`
`4313`	`4313`	`case Token.Ampersand_Ampersand:`
`4314`		`- case Token.Bar_Bar: {`
	`4314`	`+ case Token.Bar_Bar:`
	`4315`	`+ case Token.In: {`
`4315`	`4316`	`let next = this.parseExpression(tn, nextPrecedence + 1);`
`4316`	`4317`	`if (!next) return null;`
`4317`	`4318`	`expr = Node.createBinaryExpression(token, expr, next, tn.range(startPos, tn.pos));`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -2054,6 +2054,12 @@ export class Resolver extends DiagnosticEmitter {`
`2054`	`2054`	`return Type.bool;`
`2055`	`2055`	`}`
`2056`	`2056`
	`2057`	`+ // in operator`
	`2058`	`+`
	`2059`	`+ case Token.In: {`
	`2060`	`+ return Type.bool;`
	`2061`	`+ }`
	`2062`	`+`
`2057`	`2063`	`// arithmetics: result is common type of LHS and RHS, preferring overloads`
`2058`	`2064`
`2059`	`2065`	`case Token.Plus:`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,6 @@`
	`1`	`+{`
	`2`	`+ "stderr": [`
	`3`	`+ "AS100: Not implemented: 'in' operator", "\"log\" in console",`
	`4`	`+ "EOF"`
	`5`	`+ ]`
	`6`	`+}`

Lines changed: 3 additions & 0 deletions

Comments

(0)