Commit 1ff71e5

authored

fix: Support trailing comma in function type parameters (#2608)

1 parent 4b3b390 commit 1ff71e5Copy full SHA for 1ff71e5

File tree

-0

lines changed

-0

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -797,6 +797,7 @@ export class Parser extends DiagnosticEmitter {`
`797`	`797`	`}`
`798`	`798`	`} else {`
`799`	`799`	`if (isSignature) {`
	`800`	`+ if (tn.peek() == Token.CloseParen) break; // allow trailing comma`
`800`	`801`	`this.error(`
`801`	`802`	`DiagnosticCode.Identifier_expected,`
`802`	`803`	`tn.range()`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,3 +3,4 @@ var b: (a: i32, b: i32) => void;`
`3`	`3`	`var c: (a: i32, b: i32) => (a: i32, b: i32) => void;`
`4`	`4`	`var d: (a: i32, a: i32) => void; // NOTE: duplicates in type signatures doesn't in TypeScript`
`5`	`5`	`var e: (a) => void; // TS1110`
	`6`	`+var f: (a: i32, b: i32,) => (a: i32, b: i32,) => void;`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,4 +3,5 @@ var b: (a: i32, b: i32) => void;`
`3`	`3`	`var c: (a: i32, b: i32) => (a: i32, b: i32) => void;`
`4`	`4`	`var d: (a: i32, a: i32) => void;`
`5`	`5`	`var e: (a) => void;`
	`6`	`+var f: (a: i32, b: i32) => (a: i32, b: i32) => void;`
`6`	`7`	`// ERROR 1110: "Type expected." in function-type.ts(5,10+0)`

Comments

(0)