Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Commit 33a136d

Browse files
Report compile errors in shared library (#327)
Properly report compile error in shared library (fix #325).
1 parent 2a68c83 commit 33a136d

File tree

14 files changed

+100
-19
lines changed

14 files changed

+100
-19
lines changed

‎.github/workflows/linux.yaml‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,3 +61,13 @@ jobs:
6161
bundle exec ensure_arduino_installation.rb
6262
sh ./scripts/install.sh
6363
bundle exec arduino_ci.rb
64+
65+
SharedLibrary:
66+
runs-on: ubuntu-latest
67+
steps:
68+
- uses: actions/checkout@v2
69+
- uses: ruby/setup-ruby@v1
70+
with:
71+
ruby-version: 2.6
72+
- name: Test SharedLibrary should fail
73+
run: ./SampleProjects/SharedLibrary/test.sh

‎.github/workflows/macos.yaml‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,3 +61,13 @@ jobs:
6161
bundle exec ensure_arduino_installation.rb
6262
sh ./scripts/install.sh
6363
bundle exec arduino_ci.rb
64+
65+
SharedLibrary:
66+
runs-on: macos-latest
67+
steps:
68+
- uses: actions/checkout@v2
69+
- uses: ruby/setup-ruby@v1
70+
with:
71+
ruby-version: 2.6
72+
- name: Test SharedLibrary should fail
73+
run: ./SampleProjects/SharedLibrary/test.sh

‎.github/workflows/windows.yaml‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,3 +50,13 @@ jobs:
5050
bundle exec ensure_arduino_installation.rb
5151
bash -x ./scripts/install.sh
5252
bundle exec arduino_ci.rb
53+
54+
SharedLibrary:
55+
runs-on: windows-latest
56+
steps:
57+
- uses: actions/checkout@v2
58+
- uses: ruby/setup-ruby@v1
59+
with:
60+
ruby-version: 2.6
61+
- name: Test SharedLibrary should fail
62+
run: ./SampleProjects/SharedLibrary/test.sh

‎CHANGELOG.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
3232
- Fix copy/paste error to allow additional warnings for a platform
3333
- Apply "rule of three" to Client copy constructor and copy assignment operator
3434
- Run Windows tests on Windows not Ubuntu
35+
- Properly report error in building shared library
3536

3637
### Security
3738

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
unittest:
2+
platforms:
3+
- mega2560
4+
5+
compile:
6+
platforms:
7+
- mega2560
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
.bundle

‎SampleProjects/SharedLibrary/Gemfile‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
source 'https://rubygems.org'
2+
gem 'arduino_ci', path: '../../'
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# SharedLibrary
2+
3+
This is an example of a shared library with a compile error (see https://github.com/Arduino-CI/arduino_ci/issues/325).
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
name=SharedLibrary
2+
version=0.1.0
3+
author=James Foster <arduino@jgfoster.net>
4+
maintainer=James Foster <arduino@jgfoster.net>
5+
sentence=Sample shared library to validate that we catch compile errors
6+
paragraph=Sample shared library to validate that we catch compile errors
7+
category=Other
8+
url=https://github.com/Arduino-CI/arduino_ci/SampleProjects/SharedLibrary
9+
architectures=avr,esp8266
10+
includes=SharedLibrary.h
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
#include "SharedLibrary.h"
2+
3+
int main() {
4+
return foo; // 'foo' was not declared in this scope
5+
}

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /