-
Notifications
You must be signed in to change notification settings - Fork 5
fix(hermes): harden start-hermes-chrome.ps1 error handling #83
Open
Description
Summary
The PowerShell script container/.devcontainer/scripts/start-hermes-chrome.ps1 works for the happy path but lacks error handling for common failure modes.
Improvements Needed
- Port validation — validate the port argument is in 1-65535 range
- Chrome version check — verify Chrome is installed before attempting launch
- Port-in-use detection — check if the CDP port is already bound before starting Chrome
- Cleanup on CDP verification failure — remove portproxy/firewall rules if Chrome fails to start or CDP verification times out
- Better error messages — distinguish "port in use" from "Chrome failed to start" from "portproxy setup failed"
Context
This script launches Chrome with remote debugging on Windows and sets up a netsh portproxy so the Docker container can reach it. Currently, if any step fails silently, the user gets no actionable feedback.
Low priority — Hermes/CDP is a secondary feature. The basic flow works; this is about resilience.
Activity
Metadata
Metadata
Assignees
Labels
No labels