Commit 7d7d716

authored

style: include needless_for_each (TheAlgorithms#917)

1 parent d9e579f commit 7d7d716Copy full SHA for 7d7d716

File tree

+21

-11

lines changed

+21

-11

lines changed

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,6 @@ used_underscore_binding = { level = "allow", priority = 1 }`
`68`	`68`	`ref_option = { level = "allow", priority = 1 }`
`69`	`69`	`unnecessary_semicolon = { level = "allow", priority = 1 }`
`70`	`70`	`ignore_without_reason = { level = "allow", priority = 1 }`
`71`		`-needless_for_each = { level = "allow", priority = 1 }`
`72`	`71`	`# restriction-lints:`
`73`	`72`	`absolute_paths = { level = "allow", priority = 1 }`
`74`	`73`	`arithmetic_side_effects = { level = "allow", priority = 1 }`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -42,9 +42,9 @@ pub fn transposition(decrypt_mode: bool, msg: &str, key: &str) -> String {`
`42`	`42`
`43`	`43`	`key_ascii.sort_by_key(\|&(index, _)\| index);`
`44`	`44`
`45`		`- key_ascii`
`46`		`- .into_iter()`
`47`		`- .for_each(\|(_, key)\| key_order.push(key.into()));`
	`45`	`+ for(_, key)inkey_ascii{`
	`46`	`+ key_order.push(key.into());`
	`47`	`+ }`
`48`	`48`
`49`	`49`	`// Determines whether to encrypt or decrypt the message,`
`50`	`50`	`// and returns the result`

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -153,8 +153,9 @@ impl<T: Clone + Copy + Ord> HuffmanDictionary<T> {`
`153`	`153`	`}`
`154`	`154`	`pub fn encode(&self, data: &[T]) -> HuffmanEncoding {`
`155`	`155`	`let mut result = HuffmanEncoding::new();`
`156`		`- data.iter()`
`157`		`- .for_each(\|value\| result.add_data(self.alphabet[value]));`
	`156`	`+ for value in data.iter() {`
	`157`	`+ result.add_data(self.alphabet[value]);`
	`158`	`+ }`
`158`	`159`	`result`
`159`	`160`	`}`
`160`	`161`	`}`
`@@ -237,7 +238,9 @@ mod tests {`
`237`	`238`	`use super::*;`
`238`	`239`	`fn get_frequency(bytes: &[u8]) -> Vec<(u8, u64)> {`
`239`	`240`	`let mut cnts: Vec<u64> = vec![0; 256];`
`240`		`- bytes.iter().for_each(\|&b\| cnts[b as usize] += 1);`
	`241`	`+ for &b in bytes.iter() {`
	`242`	`+ cnts[b as usize] += 1;`
	`243`	`+ }`
`241`	`244`	`let mut result = vec![];`
`242`	`245`	`cnts.iter()`
`243`	`246`	`.enumerate()`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,9 @@ mod tests {`
`41`	`41`	`let mut result = enumerate_graph(&graph);`
`42`	`42`	`let expected = vec![vec![], vec![2, 3], vec![1, 3, 4], vec![1, 2], vec![2]];`
`43`	`43`
`44`		`- result.iter_mut().for_each(\|v\| v.sort_unstable());`
	`44`	`+ for v in result.iter_mut() {`
	`45`	`+ v.sort_unstable();`
	`46`	`+ }`
`45`	`47`	`assert_eq!(result, expected);`
`46`	`48`	`}`
`47`	`49`
`@@ -55,7 +57,9 @@ mod tests {`
`55`	`57`	`let mut result = enumerate_graph(&graph);`
`56`	`58`	`let expected = vec![vec![], vec![2, 3], vec![1, 3, 4], vec![1, 2], vec![2]];`
`57`	`59`
`58`		`- result.iter_mut().for_each(\|v\| v.sort_unstable());`
	`60`	`+ for v in result.iter_mut() {`
	`61`	`+ v.sort_unstable();`
	`62`	`+ }`
`59`	`63`	`assert_eq!(result, expected);`
`60`	`64`	`}`
`61`	`65`	`}`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,9 @@ mod tests {`
`192`	`192`	`polynomial.append(&mut vec![0.0; 4]);`
`193`	`193`	`let permutation = fast_fourier_transform_input_permutation(polynomial.len());`
`194`	`194`	`let mut fft = fast_fourier_transform(&polynomial, &permutation);`
`195`		`- fft.iter_mut().for_each(\|num\| num = *num);`
	`195`	`+ for num in fft.iter_mut() {`
	`196`	`+ num = *num;`
	`197`	`+ }`
`196`	`198`	`let ifft = inverse_fast_fourier_transform(&fft, &permutation);`
`197`	`199`	`let expected = [1.0, 2.0, 1.0, 4.0, 4.0, 0.0, 4.0, 0.0, 0.0];`
`198`	`200`	`for (x, y) in ifft.iter().zip(expected.iter()) {`
`@@ -210,7 +212,9 @@ mod tests {`
`210`	`212`	`polynomial.append(&mut vec![0.0f64; n]);`
`211`	`213`	`let permutation = fast_fourier_transform_input_permutation(polynomial.len());`
`212`	`214`	`let mut fft = fast_fourier_transform(&polynomial, &permutation);`
`213`		`- fft.iter_mut().for_each(\|num\| num = *num);`
	`215`	`+ for num in fft.iter_mut() {`
	`216`	`+ num = *num;`
	`217`	`+ }`
`214`	`218`	`let ifft = inverse_fast_fourier_transform(&fft, &permutation);`
`215`	`219`	`let expected = (0..((n << 1) - 1)).map(\|i\| std::cmp::min(i + 1, (n << 1) - 1 - i) as f64);`
`216`	`220`	`for (&x, y) in ifft.iter().zip(expected) {`

Comments

(0)