Commit d548caa

committed

use memcpy to avoid misaligned pointer UB

compiles to the same thing before/after at any optimization level

1 parent 6353deb commit d548caaCopy full SHA for d548caa

File tree

-1

lines changed

-1

lines changed

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`#include "BMPParser.h"`
`2`	`2`
`3`	`3`	`#include <cassert>`
	`4`	`+#include <cstring>`
`4`	`5`
`5`	`6`	`using namespace std;`
`6`	`7`	`using namespace BMPParser;`
`@@ -384,7 +385,8 @@ string Parser::getErrMsg() const{`
`384`	`385`	`template <typename T, bool check> inline T Parser::get(){`
`385`	`386`	`if(check)`
`386`	`387`	`CHECK_OVERRUN(ptr, sizeof(T), T);`
`387`		`- T val = (T)ptr;`
	`388`	`+ T val;`
	`389`	`+ std::memcpy(&val, ptr, sizeof(T));`
`388`	`390`	`ptr += sizeof(T);`
`389`	`391`	`return val;`
`390`	`392`	`}`

Comments

(0)