Commit 1817109

committed

add missing DOMMatrixInit and DOMPointInit types

this was accidentally relying on people importing ambient DOM declarations

1 parent 8346512 commit 1817109Copy full SHA for 1817109

File tree

+13

-0

lines changed

+13

-0

lines changed

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,6 +10,7 @@ project adheres to [Semantic Versioning](http://semver.org/).`
`10`	`10`	`### Changed`
`11`	`11`	`### Added`
`12`	`12`	`### Fixed`
	`13`	`+* Fixed accidental depenency on ambient DOM types`
`13`	`14`
`14`	`15`
`15`	`16`	`3.0.0`

Lines changed: 10 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -395,6 +395,16 @@ export class JPEGStream extends Readable {}`
`395`	`395`	/** This class must not be constructed directly; use `canvas.createPDFStream()`. */
`396`	`396`	`export class PDFStream extends Readable {}`
`397`	`397`
	`398`	`+// TODO: this is wrong. See matrixTransform in lib/DOMMatrix.js`
	`399`	`+type DOMMatrixInit = DOMMatrix \| string \| number[];`
	`400`	`+`
	`401`	`+interface DOMPointInit {`
	`402`	`+ w?: number;`
	`403`	`+ x?: number;`
	`404`	`+ y?: number;`
	`405`	`+ z?: number;`
	`406`	`+}`
	`407`	`+`
`398`	`408`	`export class DOMPoint {`
`399`	`409`	`w: number;`
`400`	`410`	`x: number;`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,8 @@ class DOMPoint {`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`matrixTransform(init) {`
	`22`	`+ // TODO: this next line is wrong. matrixTransform is supposed to only take`
	`23`	`+ // an object with the DOMMatrix properties called DOMMatrixInit`
`22`	`24`	`const m = init instanceof DOMMatrix ? init : new DOMMatrix(init)`
`23`	`25`	`return m.transformPoint(this)`
`24`	`26`	`}`

Comments

(0)