Commit 5e7a115

authored

Merge pull request #72 from kiddopro/14-Loop-dictionary

I have modified the tests, now the search is done with regex

2 parents 18e2a2c + 8e277cc commit 5e7a115Copy full SHA for 5e7a115

File tree

2 files changed

+10

-16

lines changed

exercises/14-Loop-dictionary
- app.py
- test.py

2 files changed

+10

-16

lines changed

`‎exercises/14-Loop-dictionary/app.py`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`		`-`
`2`	`1`	`spanish_translations = { "dog": "perro", "house": "casa", "cat": "gato" }`
	`2`	`+# Your code here`
`3`	`3`
`4`	`4`
`5`		`-`
	`5`	`+# Don't touch the code below`
`6`	`6`	`print("Translation", spanish_translations["dog"])`
`7`		`-print("All", spanish_translations)`
	`7`	`+print(spanish_translations)`
`8`	`8`

`‎exercises/14-Loop-dictionary/test.py`

Lines changed: 7 additions & 13 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,31 +5,25 @@`
`5`	`5`	`def test_love():`
`6`	`6`	`f = open(os.path.dirname(os.path.abspath(__file__))+'/app.py')`
`7`	`7`	`content = f.read()`
`8`		`- value = False`
`9`		`- if(content.find("spanish_translations['love'] = 'amor'") > 0 or content.find('spanish_translations["love"] = "amor"') > 0):`
`10`		`- value = True`
`11`		`- assert value == True`
	`8`	`+ regex = re.compile(r"spanish_translations\[\s[\'\"]love[\'\"]\s\]\s\=\s[\'\"]amor[\'\"]")`
	`9`	`+ assert bool(regex.search(content)) == True`
`12`	`10`
`13`	`11`	@pytest.mark.it("You should add `code` programatically to the dictionary")
`14`	`12`	`def test_code():`
`15`	`13`	`f = open(os.path.dirname(os.path.abspath(__file__))+'/app.py')`
`16`	`14`	`content = f.read()`
`17`		`- value = False`
`18`		`- if(content.find("spanish_translations['code'] = 'codigo'") > 0 or content.find('spanish_translations["code"] = "codigo"') > 0):`
`19`		`- value = True`
`20`		`- assert value == True`
	`15`	`+ regex = re.compile(r"spanish_translations\[\s[\'\"]code[\'\"]\s\]\s\=\s[\'\"]codigo[\'\"]")`
	`16`	`+ assert bool(regex.search(content)) == True`
`21`	`17`
`22`	`18`	@pytest.mark.it("You should add `smart` programatically to the dictionary")
`23`	`19`	`def test_smart():`
`24`	`20`	`f = open(os.path.dirname(os.path.abspath(__file__))+'/app.py')`
`25`	`21`	`content = f.read()`
`26`		`- value = False`
`27`		`- if(content.find("spanish_translations['smart'] = 'inteligente'") > 0 or content.find('spanish_translations["smart"] = "inteligente"') > 0):`
`28`		`- value = True`
`29`		`- assert value == True`
	`22`	`+ regex = re.compile(r"spanish_translations\[\s[\'\"]smart[\'\"]\s\]\s\=\s[\'\"]inteligente[\'\"]")`
	`23`	`+ assert bool(regex.search(content)) == True`
`30`	`24`
`31`	`25`	`@pytest.mark.it("You should print in the console the dictionary with proper translations")`
`32`	`26`	`def test_multp(capsys, app):`
`33`	`27`	`import app`
`34`	`28`	`captured = capsys.readouterr()`
`35`		`- assert "All {'dog': 'perro', 'house': 'casa', 'cat': 'gato', 'love': 'amor', 'code': 'codigo', 'smart': 'inteligente'}" in captured.out`
	`29`	`+ assert "{'dog': 'perro', 'house': 'casa', 'cat': 'gato', 'love': 'amor', 'code': 'codigo', 'smart': 'inteligente'}" in captured.out`

0 commit comments

Comments

(0)

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit 5e7a115

File tree

2 files changed

2 files changed

`‎exercises/14-Loop-dictionary/app.py`

`‎exercises/14-Loop-dictionary/test.py`

0 commit comments