git.postgresql.org Git - postgresql.git/commit

git projects / postgresql.git / commit

Rearrange "add column" logic to merge columns at exec time.

author Robert Haas <rhaas@postgresql.org>

Mon, 4 Apr 2011 01:52:47 +0000 (21:52 -0400)

committer Robert Haas <rhaas@postgresql.org>

Mon, 4 Apr 2011 01:53:32 +0000 (21:53 -0400)

commit 6c5723998594dffa5d47c3cf8c96ccf89c033aae

tree 2b1ac2c585d2df36a20ecd2d3aefc4573a21691d tree

parent cabf5d84b6d1a92ab97492d7e3d650548a9992cd commit | diff

Rearrange "add column" logic to merge columns at exec time.

The previous coding set attinhcount too high in some cases, resulting in
an undumpable, undroppable column. Per bug #5856, reported by Naoya
Anzai. See also commit 31b6fc06d83c6de3644c8f2921eb7de0eb92fac3, which
fixes a similar bug in ALTER TABLE .. ADD CONSTRAINT.

Patch by Noah Misch.

src/backend/commands/tablecmds.c diff | blob | blame | history

src/include/nodes/parsenodes.h diff | blob | blame | history

src/test/regress/expected/alter_table.out diff | blob | blame | history

src/test/regress/sql/alter_table.sql diff | blob | blame | history

This is the main PostgreSQL git repository.

RSS Atom