git.postgresql.org Git - postgresql.git/commit

git projects / postgresql.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 5ac9c43) | patch
Remove read_page callback from XLogReader.
Thu, 8 Apr 2021 11:03:23 +0000 (23:03 +1200)
Thu, 8 Apr 2021 11:20:42 +0000 (23:20 +1200)
commit 323cbe7c7ddcf18aaf24b7f6d682a45a61d4e31b
Remove read_page callback from XLogReader.

Previously, the XLogReader module would fetch new input data using a
callback function. Redesign the interface so that it tells the caller
to insert more data with a special return value instead. This API suits
later patches for prefetching, encryption and maybe other future
projects that would otherwise require continually extending the callback
interface.

As incidental cleanup work, move global variables readOff, readLen and
readSegNo inside XlogReaderState.

Author: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Author: Heikki Linnakangas <hlinnaka@iki.fi> (parts of earlier version)
Reviewed-by: Antonin Houska <ah@cybertec.at>
Reviewed-by: Alvaro Herrera <alvherre@2ndquadrant.com>
Reviewed-by: Takashi Menjo <takashi.menjo@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Reviewed-by: Thomas Munro <thomas.munro@gmail.com>
Discussion: https://postgr.es/m/20190418.210257.43726183.horiguchi.kyotaro%40lab.ntt.co.jp
13 files changed:
src/backend/access/transam/twophase.c diff | blob | blame | history
src/backend/access/transam/xlog.c diff | blob | blame | history
src/backend/access/transam/xlogreader.c diff | blob | blame | history
src/backend/access/transam/xlogutils.c diff | blob | blame | history
src/backend/replication/logical/logical.c diff | blob | blame | history
src/backend/replication/logical/logicalfuncs.c diff | blob | blame | history
src/backend/replication/slotfuncs.c diff | blob | blame | history
src/backend/replication/walsender.c diff | blob | blame | history
src/bin/pg_rewind/parsexlog.c diff | blob | blame | history
src/bin/pg_waldump/pg_waldump.c diff | blob | blame | history
src/include/access/xlogreader.h diff | blob | blame | history
src/include/access/xlogutils.h diff | blob | blame | history
src/include/replication/logical.h diff | blob | blame | history
This is the main PostgreSQL git repository.
RSS Atom

AltStyle によって変換されたページ (->オリジナル) /