git.postgresql.org Git - postgresql.git/log
Check for ERANGE in exp() as well.
Improve release docs for ecpg regression tests.
Improve dpow() check for ERANGE overflow for HPPA.
Tom Lane [Sat, 6 Jan 2007 02:28:38 +0000 (02:28 +0000)]
Put back ERANGE test in dpow(). There are platforms that need this,
like my HPPA ...
Document that we need to update the ecpg regression files when we update
the library version number.
Update ecpg regresison output for new library version number.
Tom Lane [Fri, 5 Jan 2007 22:34:35 +0000 (22:34 +0000)]
Minor copy-editing for release note updates.
Update CVS HEAD for 2007 copyright. Back branches are typically not
back-stamped for this.
Update copyright script, report year used
Modify copyright script to pull current year from `date`.
Update Japanese FAQ.
Stamp major release 8.3.0, and increment library version numbers.
Update for release 8.2.1.
Create release notes for all back-branch relases on 2007年01月08日.
Call setrlimit if possible in pg_regress to allow core file generation, and provide a switch for similar behaviour in pg_ctl.
Update float dpow() comment about whick platforms had issues with Nan.
Stefan Kaltenbrunner
Tom Lane [Fri, 5 Jan 2007 01:18:59 +0000 (01:18 +0000)]
Add missing reference to pg_shdescription. Greg Mullane
Fix tab to space mention in FAQ_DEV.
Tom Lane [Thu, 4 Jan 2007 17:58:19 +0000 (17:58 +0000)]
Fix AddDefine to handle quotes properly. Magnus
Tom Lane [Thu, 4 Jan 2007 17:49:37 +0000 (17:49 +0000)]
Tweak pg_dumpall to add GRANT CONNECT ON DATABASE ... TO PUBLIC when dumping
database privileges from a pre-8.2 server. This ensures that the reloaded
database will maintain the same behavior it had in the previous installation,
ie, everybody has connect privilege. Per gripe from L Bayuk.
Tom Lane [Thu, 4 Jan 2007 16:29:42 +0000 (16:29 +0000)]
Fix some small typos in comments. Greg Stark
Simplify assignment of Inf for pow Nan (don't worry about the sign).
Tom Lane [Thu, 4 Jan 2007 00:57:51 +0000 (00:57 +0000)]
Fix erroneous implementation of -s in postc (the switch doesn't take
an optarg). Add some comments noting that code in three different files has
to be kept in sync. Fix erroneous description of -S switch (it sets work_mem
not silent_mode), and do some light copy-editing elsewhere in postgres-ref.
Tom Lane [Wed, 3 Jan 2007 22:39:26 +0000 (22:39 +0000)]
Fix regex_fixed_prefix() to cope reasonably well with regex patterns of the
form '^(foo)$'. Before, these could never be optimized into indexscans.
The recent changes to make psql and pg_dump generate such patterns (for \d
commands and -t and related switches, respectively) therefore represented
a big performance hit for people with large pg_class catalogs, as seen in
recent gripe from Erik Jones. While at it, be more paranoid about
case-sensitivity checking in multibyte encodings, and fix some other
corner cases in which a regex might be interpreted too liberally.
Update pow() tests to check for both errno==EDOM _and_ result==Nan, and
document why this happens. Remove exp() errno check because not needed.
Tom Lane [Wed, 3 Jan 2007 19:34:23 +0000 (19:34 +0000)]
Fix erroneous error tests in pow/exp.
Tom Lane [Wed, 3 Jan 2007 18:57:19 +0000 (18:57 +0000)]
Fix btree_gist for new larger money type.
Tom Lane [Wed, 3 Jan 2007 18:11:01 +0000 (18:11 +0000)]
Clean up smgr.c/md.c APIs as per discussion a couple months ago. Instead of
having md.c return a success/failure boolean to smgr.c, which was just going
to elog anyway, let md.c issue the elog messages itself. This allows better
error reporting, particularly in cases such as "short read" or "short write"
which Peter was complaining of. Also, remove the kluge of allowing mdread()
to return zeroes from a read-beyond-EOF: this is now an error condition
except when InRecovery or zero_damaged_pages = true. (Hash indexes used to
require that behavior, but no more.) Also, enforce that mdwrite() is to be
used for rewriting existing blocks while mdextend() is to be used for
extending the relation EOF. This restriction lets us get rid of the old
ad-hoc defense against creating huge files by an accidental reference to
a bogus block number: we'll only create new segments in mdextend() not
mdwrite() or mdread(). (Again, when InRecovery we allow it anyway, since
we need to allow updates of blocks that were later truncated away.)
Also, clean up the original makeshift patch for bug #2737: move the
responsibility for padding relation segments to full length into md.c.
Attempt to return proper overflow/underflow messages for platforms that
only return Nan and set errno for pow/exp overflow/underflow.
For float4/8, remove errno checks for pow() and exp() because only some
platforms set errno, and we already have a check macro that detects
under/overflow, so there is no reason for platform-specific code
anymore.
Widen the money type to 64 bits.
Update expected result for new inet error message wording.
Adjust network errmsg("result is out of range") message to be consistent
with other places.
Some platforms set errno on pow(), exp() overflow, some do not, so if
isinf(), fall through to our own infinity checks.
Tom Lane [Tue, 2 Jan 2007 21:43:36 +0000 (21:43 +0000)]
Add a regression test for ALTER SET TABLESPACE; this is a whole separate
code path in tablecmds.c that wasn't exercised at all before.
finite() no longer used; remove finite() platform-specific
infrastructure.
Add n_live_tuples and n_dead_tuples to pg_stat_all_tables.
The purpose is to allow autovacuum-esq conditional vacuuming and
clustering using SQL to discover the required stats.
No documentation updates required. Catalog version updated.
Glen Parker
Add #include <float.h> for platforms that still need it.
Fix float4/8 to handle Infinity and Nan consistently, e.g. Infinity is a
valid result from a computation if one of the input values was infinity.
The previous code assumed an operation that returned infinity was an
overflow.
Handle underflow/overflow consistently, and add checks for aggregate
overflow.
Consistently prevent Inf/Nan from being cast to integer data types.
Fix INT_MIN % -1 to prevent overflow.
Update regression results for new error text.
Per report from Roman Kononov.
Tom Lane [2006年12月31日 20:32:04 +0000 (20:32 +0000)]
Found the problem with my operator-family changes: by fetching from
pg_opclass during LookupOpclassInfo(), I'd turned pg_opclass_oid_index
into a critical system index. However the problem could only manifest
during a backend's first attempt to load opclass data, and then only
if it had successfully loaded pg_internal.init and subsequently received
a relcache flush; which made it impossible to reproduce in sequential
tests and darn hard even in parallel tests. Memo to self: when
exercising cache flush scenarios, must disable LookupOpclassInfo's
internal cache too.
Tom Lane [2006年12月30日 21:21:56 +0000 (21:21 +0000)]
Support type modifiers for user-defined types, and pull most knowledge
about typmod representation for standard types out into type-specific
typmod I/O functions. Teodor Sigaev, with some editorialization by
Tom Lane.
Clarify wording on when ctid is modified by VACUUM FULL.
Tom Lane [2006年12月29日 16:49:02 +0000 (16:49 +0000)]
Add support for XML build option to MSVC build scripts.
Magnus Hagander
Tom Lane [2006年12月29日 16:44:28 +0000 (16:44 +0000)]
Fix multiple breakages in last XML patch.
De-escape XML names when reverse-compiling XML expressions.
Tom Lane [2006年12月28日 23:16:39 +0000 (23:16 +0000)]
Fix up btree's initial scankey processing to be able to detect redundant
or contradictory keys even in cross-data-type scenarios. This is another
benefit of the opfamily rewrite: we can find the needed comparison
operators now.
Add TLS thread URL:
> http://archives.postgresql.org/pgsql-hackers/2006-12/msg01213.php
Remove:
< * Add a GUC to control whether BEGIN inside a transcation should abort
< the transaction.
Tom Lane [2006年12月28日 20:02:38 +0000 (20:02 +0000)]
Remove caveat about avoiding cross-type operators in constraints intended
for use with constraint exclusion. We can prove those cases now...
Tom Lane [2006年12月28日 19:53:05 +0000 (19:53 +0000)]
Enable btree_predicate_proof() to make proofs involving cross-data-type
predicate operators. The hard stuff turns out to be already done in the
previous commit, we need merely open the floodgates...
Done:
< * Move some /contrib modules out to their own project sites
<
< Particularly, move GPL-licensed /contrib/userlock and
< /contrib/dbmirror/clean_pending.pl.
<
Add send and recv functions for xml type.
Handle content and document options in xmlparse() correctly.
Tom Lane [2006年12月28日 01:09:01 +0000 (01:09 +0000)]
Add a defense to prevent core dumps if 8.2 version of rank_cd() is used with
the 8.1 SQL function definition for it. Per report from Rajesh Kumar Mallah,
such a DBA error doesn't seem at all improbable, and the cost of checking for
it is not very high compared to the cost of running this function. (It would
have been better to change the C name of the function so it wouldn't be called
by the old SQL definition, but it's too late for that now in the 8.2 branch.)
Tom Lane [2006年12月28日 00:29:13 +0000 (00:29 +0000)]
fflush the \o file, if any, after each backslash command. We already
do this for ordinary SQL commands, so it seems consistent to do it for
backslash commands too. Per gripe from Rajesh Kumar Mallah.
Tom Lane [2006年12月28日 00:01:05 +0000 (00:01 +0000)]
Revert exports.list change pending closer study.
Tom Lane [2006年12月27日 23:53:13 +0000 (23:53 +0000)]
Use a more backward-compatible syntax for exports.list on Linux.
Per Thorkil Olesen.
Clean up pgindent handling of comments after 'else' by only moving
multi-line comments to the next line.
Tom Lane [2006年12月27日 22:31:54 +0000 (22:31 +0000)]
Modify local buffer management to request memory for local buffers in blocks
of increasing size, instead of one at a time. This reduces the memory
management overhead when num_temp_buffers is large: in the previous coding
we would actually waste 50% of the space used for temp buffers, because aset.c
would round the individual requests up to 16K. Problem noted while studying
a performance issue reported by Steven Flatt.
Back-patch as far as 8.1 --- older versions used few enough local buffers
that the issue isn't significant for them.
Tom Lane [2006年12月27日 22:30:48 +0000 (22:30 +0000)]
Improve memory management code to avoid inefficient behavior when a context
has a small maxBlockSize: the maximum request size that we will treat as a
"chunk" needs to be limited to fit in maxBlockSize. Otherwise we will round
up the request size to the next power of 2, wasting space, which is a bit
pointless if we aren't going to make the blocks big enough to fit additional
stuff in them. The example motivating this is local buffer management, which
makes repeated allocations of 8K (one BLCKSZ buffer) in TopMemoryContext,
which has maxBlockSize = 8K because for the most part allocations there are
small. This leads to each local buffer actually eating 16K of space, which
adds up when there are thousands of them. I intend to change localbuf.c to
aggregate its requests, which will prevent this particular misbehavior, but
it seems likely that similar scenarios could arise elsewhere, so fixing the
core problem seems wise as well.
Tom Lane [2006年12月27日 19:45:36 +0000 (19:45 +0000)]
Print combining characters (those reported as having zero width by
PQdsplen()) normally, instead of replacing them by \uXXXX sequences.
Assume that they in fact occupy zero screen space for formatting purposes.
Per gripe from Michael Fuhr and ensuing discussion.
Tom Lane [2006年12月27日 16:07:36 +0000 (16:07 +0000)]
Use FROM clause in example UPDATE commands where appropriate. Also
remove long-obsolete statement that there isn't a check for infinite
recursion in view rules.
Use "dead" rather than "expired" for vacuumable rows.
Tom Lane [2006年12月26日 21:37:20 +0000 (21:37 +0000)]
Fix failure due to accessing an already-freed tuple descriptor in a plan
involving HashAggregate over SubqueryScan (this is the known case, there
may well be more). The bug is only latent in releases before 8.2 since they
didn't try to access tupletable slots' descriptors during ExecDropTupleTable.
The least bogus fix seems to be to make subqueries share the parent query's
memory context, so that tupdescs they create will have the same lifespan as
those of the parent query. There are comments in the code envisioning going
even further by not having a separate child EState at all, but that will
require rethinking executor access to range tables, which I don't want to
tackle right now. Per bug report from Jean-Pierre Pelletier.
Tom Lane [2006年12月26日 19:26:46 +0000 (19:26 +0000)]
Repair bug #2839: the various ExecReScan functions need to reset
ps_TupFromTlist in plan nodes that make use of it. This was being done
correctly in join nodes and Result nodes but not in any relation-scan nodes.
Bug would lead to bogus results if a set-returning function appeared in the
targetlist of a subquery that could be rescanned after partial execution,
for example a subquery within EXISTS(). Bug has been around forever :-(
... surprising it wasn't reported before.
Tom Lane [2006年12月26日 16:56:18 +0000 (16:56 +0000)]
Repair bug #2836: SPI_execute_plan returned zero if none of the querytrees
were marked canSetTag. While it's certainly correct to return the result
of the last one that is marked canSetTag, it's less clear what to do when
none of them are. Since plpgsql will complain if zero is returned, the
8.2.0 behavior isn't good. I've fixed it to restore the prior behavior of
returning the physically last query's result code when there are no
canSetTag queries.
Tom Lane [2006年12月26日 16:14:58 +0000 (16:14 +0000)]
Remove incorrect semicolon in example. Joachim Wieland
Fix memory reallocation condition
Call srandom() instead of srand().
pgbench calls random() later, so it should have called srandom().
On most platforms except Windows srandom() is actually identical
to srand(), so the bug only bites Windows users.
per bug report from Akio Ishida.
Tom Lane [2006年12月24日 19:14:28 +0000 (19:14 +0000)]
Make HISTCONTROL=ignoredups work again (broken by misordering of
operations during recent code refactoring). Per bug #2840 from Ned Crigler.
Tom Lane [2006年12月24日 18:25:58 +0000 (18:25 +0000)]
Bring some order and sanity to error handling in the xml patch.
Use a TRY block instead of (inadequate) ad-hoc coding to ensure that
libxml is cleaned up after a failure. Report the intended SQLCODE
instead of defaulting to XX000. Avoid risking use of a dangling
pointer by keeping the persistent error buffer in TopMemoryContext.
Be less trusting that error messages don't contain %.
This patch doesn't do anything about changing the way the messages
are put together --- this is just about mechanism.
Tom Lane [2006年12月24日 00:57:48 +0000 (00:57 +0000)]
Fix machine-dependent crash in sqlchar_to_unicode(). Get rid of
bletcherous and unsafe manipulation of global encoding setting.
Clean up libxml reporting mechanism a bit (it still looks like a
dangling-pointer crash waiting to happen, though, not to mention
being far less than sane from a localization standpoint).
Tom Lane [2006年12月24日 00:29:20 +0000 (00:29 +0000)]
Code review for XML patch. Instill a bit of sanity in the location of
the XmlExpr code in various lists, use a representation that has some hope
of reverse-listing correctly (though it's still a de-escaping function
shy of correctness), generally try to make it look more like Postgres
coding conventions.
Tom Lane [2006年12月23日 04:56:50 +0000 (04:56 +0000)]
Suppress various compiler warnings in new xml code.
Remove unnecessary parentheses in if() statements.
Change a VACUUM manual page word from 'deleted' to 'expired', so DELETE
and UPDATE are clearly covered by the term.
Document that CREATE TYPE names should not begin with an underscore,
rather than being disallowed.
For GUC values, check for partial string matches on 'on' and 'off', but
require at least two characters for uniqueness. This now matches the
behavior of other boolean strings we support, per report from Gurjeet
Singh.
Tom Lane [2006年12月23日 00:43:13 +0000 (00:43 +0000)]
Restructure operator classes to allow improved handling of cross-data-type
cases. Operator classes now exist within "operator families". While most
families are equivalent to a single class, related classes can be grouped
into one family to represent the fact that they are semantically compatible.
Cross-type operators are now naturally adjunct parts of a family, without
having to wedge them into a particular opclass as we had done originally.
This commit restructures the catalogs and cleans up enough of the fallout so
that everything still works at least as well as before, but most of the work
needed to actually improve the planner's behavior will come later. Also,
there are not yet CREATE/DROP/ALTER OPERATOR FAMILY commands; the only way
to create a new family right now is to allow CREATE OPERATOR CLASS to make
one by default. I owe some more documentation work, too. But that can all
be done in smaller pieces once this infrastructure is in place.
Add a link to the developer's FAQ for my article about how companies can
work effectively with open source communities.
Slight adjustments to xml documentation to reflect functionality just
added.
Fix expected file.
Catalog version bump for SQL/XML changes.
Fix convertion for 'PFX flag N num'
Initial SQL/XML support: xml data type and initial set of functions.
8.3 release schedule is year 2007, not 2006.
Add timeline for next release to developer's FAQ.
Item done.
< o Improve xid wraparound detection by recording per-table rather
< than per-database
Interpret a dbName param to PQsetdbLogin as a conninfo string if it contains an = sign. Tom Lane and Andrew Dunstan.
Tom Lane [2006年12月18日 18:56:29 +0000 (18:56 +0000)]
Set pg_am.amstrategies to zero for index AMs that don't have fixed
operator strategy numbers, ie, GiST and GIN. This is almost cosmetic
enough to not need a catversion bump, but since the opr_sanity regression
test has to change in sync with the catalog entry, I figured I'd better
do one.
fix thinko in placement of TimeValStruct typedef in Windows case, as reported by Magnus.
Fix typo:
< While PostgreSQL clients runs fine limited-resource environments, the
> While PostgreSQL clients runs fine in limited-resource environments, the
Move entry into CLUSTER section:
< * Make CLUSTER preserve recently-dead tuples per MVCC requirements
> o Make CLUSTER preserve recently-dead tuples per MVCC requirements
enable \timing oputput for \copy commands
Tom Lane [2006年12月15日 18:42:26 +0000 (18:42 +0000)]
Fix some planner bugs exposed by reports from Arjen van der Meijden. These
are all in new-in-8.2 logic associated with indexability of ScalarArrayOpExpr
(IN-clauses) or amortization of indexscan costs across repeated indexscans
on the inside of a nestloop. In particular:
Fix some logic errors in the estimation for multiple scans induced by a
ScalarArrayOpExpr indexqual.
Include a small cost component in bitmap index scans to reflect the costs of
manipulating the bitmap itself; this is mainly to prevent a bitmap scan from
appearing to have the same cost as a plain indexscan for fetching a single
tuple.
Also add a per-index-scan-startup CPU cost component; while prior releases
were clearly too pessimistic about the cost of repeated indexscans, the
original 8.2 coding allowed the cost of an indexscan to effectively go to zero
if repeated often enough, which is overly optimistic.
Pay some attention to index correlation when estimating costs for a nestloop
inner indexscan: this is significant when the plan fetches multiple heap
tuples per iteration, since high correlation means those tuples are probably
on the same or adjacent heap pages.
Tom Lane [2006年12月15日 16:54:43 +0000 (16:54 +0000)]
Put JST back into the default set of timezone abbreviations;
was removed in an unexplainable moment of brain fade.
Back out double-run of PDF/PS output. Requires building bookindex.sgml
properly.
Remove SGML docs about openjade performance patch, and instead add
comment in style sheet where indenting code is commented out.
Backpatch to 8.2.X.
TODO item not wanted:
>
> * Embedded server (not wanted)
>
> While PostgreSQL clients runs fine limited-resource environments, the
> server requires multiple processes and a stable pool of resources to
> run reliabily and efficiently. Stripping down the PostgreSQL server
> to run in the same process address space as the client application
> would add too much complexity and failure cases.
Link to summary XML email, rather than thread top:
< * Consider changing documentation from SGML to XML
> * Consider changing documentation format from SGML to XML
< http://archives.postgresql.org/pgsql-docs/2006-12/msg00033.php
> http://archives.postgresql.org/pgsql-docs/2006-12/msg00152.php
Document issues for SGML and XML:
>
> * Consider changing documentation from SGML to XML
>
> http://archives.postgresql.org/pgsql-docs/2006-12/msg00033.php
>
Document patch needed to get PDF and PS output in a reasonable amount of
time.
This is the main PostgreSQL git repository.
RSS
Atom