git.postgresql.org Git - postgresql.git/log
Fix DROP OWNED BY to correctly consider the implicitly-deleted objects list for
each object to be deleted, instead of the previous hack that just skipped
INTERNAL dependencies, which didn't really work. Per report from Tom Lane.
To do this, introduce a new performMultipleDeletions entry point in
dependency.c to delete multiple objects at once. The dependency code then has
the responsability of tracking INTERNAL and AUTO dependencies as needed.
Along the way, change ObjectAddresses so that we can allocate an ObjectAddress
list from outside dependency.c and not have to export the internal
representation.
Fixed a few trivial memory leaks reported by Coverity just to test my setup.
Added another test
More SoC stuff
Tom Lane [2006年8月19日 02:48:53 +0000 (02:48 +0000)]
Suppress subquery pullup/pushdown when a subquery contains volatile
functions in its targetlist, to avoid introducing multiple evaluations
of volatile functions that textually appear only once. This is a
slightly tighter version of Jaime Casanova's recent patch.
Tom Lane [2006年8月19日 01:36:34 +0000 (01:36 +0000)]
Add a 'waiting' column to pg_stat_activity to carry the same information
that ps_status provides by appending 'waiting' to the PS display. This
completes the project of making it feasible to turn off process title
updates and instead rely on pg_stat_activity. Per my suggestion a few
weeks ago.
Add installcheck-parallel target to top level makefiles.
Tom Lane [2006年8月18日 19:52:39 +0000 (19:52 +0000)]
Add PQdescribePrepared, PQdescribePortal, and related functions to libpq
to allow obtaining information about previously prepared statements and
open cursors. Volkan Yazici
Fixed a buffer overrun that was masked on Linux systems.
Add space before SP4.
Update Win2000SP4 mention.
Tom Lane [2006年8月18日 16:09:13 +0000 (16:09 +0000)]
Now that we've rearranged relation open to get a lock before touching
the rel, it's easy to get rid of the narrow race-condition window that
used to exist in VACUUM and CLUSTER. Did some minor code-beautification
work in the same area, too.
Changed lexer to no longer use the default rule.
Synced parser and keyword list.
Fixed parsing of CONNECT statement so it accepts a C string again.
Mention only Windows 2000SP4 works.
Update Win32 CMD quoting rules information location, CMD /?, from
Magnus.
Tom Lane [2006年8月17日 23:04:10 +0000 (23:04 +0000)]
Implement archive_timeout feature to force xlog file switches to occur no more
than N seconds apart. This allows a simple, if not very high performance,
means of guaranteeing that a PITR archive is no more than N seconds behind
real time. Also make pg_current_xlog_location return the WAL Write pointer,
add pg_current_xlog_insert_location to return the Insert pointer, and fix
pg_xlogfile_name_offset to return its results as a two-element record instead
of a smashed-together string, as per recent discussion.
Simon Riggs
Produce a clean failure in configure when dtrace is selected but cannot be
found. Besides stopping those early who have no dtrace installed
whatsoever, this will also alert those who have dtrace in /usr/sbin, which
might not be in the path, which would produce confusing failures much later
in the build process.
Add documentation about pointing configure to find dtrace.
Tom Lane [2006年8月17日 17:06:37 +0000 (17:06 +0000)]
Fix an oversight in mergejoin planning: the planner would reject a
mergejoin possibility where the inner rel was less well sorted than
the outer (ie, it matches some but not all of the merge clauses that
can work with the outer), if the inner path in question is also the
overall cheapest path for its rel. This is an old bug, but I'm not
sure it's worth back-patching, because it's such a corner case.
Noted while investigating a test case from Peter Hardman.
Tom Lane [2006年8月17日 17:02:49 +0000 (17:02 +0000)]
Teach convert_subquery_pathkeys() to handle the case where the
subquery's pathkey is a RelabelType applied to something that appears
in the subquery's output; for example where the subquery returns a
varchar Var and the sort order is shown as that Var coerced to text.
This comes up because varchar doesn't have its own sort operator.
Per example from Peter Hardman.
Add:
< * Add support for arrays of domains
> o Add support for arrays of domains
> o Add support for arrays of complex types
Add:
> * Support a data type with specific enumerated values (ENUM)
>
> http://archives.postgresql.org/pgsql-hackers/2006-08/msg00979.php
Add:
> * Add support for arrays of domains
Put probes.o file in right directory, fixes dtrace compilation
Tom Lane [2006年8月16日 04:32:49 +0000 (04:32 +0000)]
Seems some C compilers think 'restrict' is a fully reserved word.
Per buildfarm results from warthog.
Tom Lane [2006年8月15日 22:36:17 +0000 (22:36 +0000)]
Add a hack so that get_type_io_data() can work from bootstrap.c's
internal TypInfo table in bootstrap mode. This allows array_in and
array_out to be used during early bootstrap, which eliminates the
former obstacle to giving OUT parameters to built-in functions.
Tom Lane [2006年8月15日 19:01:17 +0000 (19:01 +0000)]
Add hooks to allow debugging and performance measurement plugins
to instrument PL/pgSQL. Korry Douglas
Tom Lane [2006年8月15日 18:26:59 +0000 (18:26 +0000)]
Add server support for "plugin" libraries that can be used for add-on tasks
such as debugging and performance measurement. This consists of two features:
a table of "rendezvous variables" that allows separately-loaded shared
libraries to communicate, and a new GUC setting "local_preload_libraries"
that allows libraries to be loaded into specific sessions without explicit
cooperation from the client application. To make local_preload_libraries
as flexible as possible, we do not restrict its use to superusers; instead,
it is restricted to load only libraries stored in $libdir/plugins/. The
existing LOAD command has also been modified to allow non-superusers to
LOAD libraries stored in this directory.
This patch also renames the existing GUC variable preload_libraries to
shared_preload_libraries (after a suggestion by Simon Riggs) and does some
code refactoring in dfmgr.c to improve clarity.
Korry Douglas, with a little help from Tom Lane.
Fix pgbench to handle empty lines in script files as documented.
patches contributed by Itagaki Takahiro.
Fixed a typo and made two mallocs Coverity friendly.
Sorry, forgot the new files.
Added lots of SoC stuff made by Joachim.
Fixed broken newline on Windows.
Fixed a nasty buffer underrun that only occured when using Informix
no_indicator NULL setting on timestamps and intervals.
Tom Lane [2006年8月14日 23:39:32 +0000 (23:39 +0000)]
Cause '*' and 'foo.*' notations to mark the referenced RTE(s) as
requiring read permissions. Up till now there was no possible case
in which the RTEs wouldn't already have ACL_SELECT set ... but now that
you can say something like 'INSERT INTO foo ... RETURNING *' this is
an essential step. With this commit, a RETURNING clause adds the
requirement for SELECT permissions on the target table if and only if
the clause actually reads the value of at least one target-table column.
Tom Lane [2006年8月14日 22:57:15 +0000 (22:57 +0000)]
Fix oversight in initial implementation of PORTAL_ONE_RETURNING mode: we
cannot assume that there's exactly one Query in the Portal, as we can for
ONE_SELECT mode, because non-SELECT queries might have extra queries added
during rule rewrites. Fix things up so that we'll use ONE_RETURNING mode
when a Portal contains one primary (canSetTag) query and that query has
a RETURNING list. This appears to be a second showstopper reason for running
the Portal to completion before we start to hand anything back --- we want
to be sure that the rule-added queries get run too.
Tom Lane [2006年8月14日 21:14:42 +0000 (21:14 +0000)]
Support INSERT/UPDATE/DELETE RETURNING in plpgsql, with rowcount checking
as per yesterday's proposal. Also make things a tad more orthogonal by
adding the recent STRICT addition to EXECUTE INTO.
Jonah Harris and Tom Lane
Tom Lane [2006年8月14日 13:40:18 +0000 (13:40 +0000)]
When executing a list of queries derived from rule expansion,
_SPI_execute_plan's return code should reflect the type of the query
that is marked canSetTag, not necessarily the last one in the list.
This is arguably a bug fix, but I'm hesitant to back-patch it because
it's the sort of subtle change that might break someone's code, and it's
best not to do that kind of thing in point releases.
Tom Lane [2006年8月14日 12:39:55 +0000 (12:39 +0000)]
Remove hash_destroy calls in hash_create's failure paths. As noted by
a Coverity warning, these are risky since the hashtable isn't necessarily
fully set up yet. They're unnecessary anyway: a deletable hashtable
should be in a memory context that will be cleared following elog(ERROR).
Per report from Martijn van Oosterhout.
Revert (again) GUC patch to return commented fields to their default
values, due to concern about the patch.
Tom Lane [2006年8月14日 00:46:53 +0000 (00:46 +0000)]
Get rid of "lookahead" functionality in plpgsql's yylex() function,
and instead make the grammar production for the RETURN statement do the
heavy lifting. The lookahead idea was copied from the main parser, but
it does not work in plpgsql's parser because here gram.y looks explicitly
at the scanner's yytext variable, which will be out of sync after a
failed lookahead step. A minimal example is
create or replace function foo() returns void language plpgsql as '
begin
perform return foo bar;
end';
which can be seen by testing to deliver "foo foo bar" to the main parser
instead of the expected "return foo bar". This isn't a huge bug since
RETURN is not found in the main grammar, but it could bite someone who
tried to use "return" as an identifier.
Back-patch to 8.1. Bug exists further back, but HEAD patch doesn't apply
cleanly, and given the lack of field complaints it doesn't seem worth
the effort to develop adjusted patches.
Tom Lane [2006年8月13日 22:18:08 +0000 (22:18 +0000)]
Fix core dump in duration logging for a V3-protocol Execute message
when what's being executed is a COMMIT or ROLLBACK. Per report from
Sergey Koposov. Backpatch to 8.1; 8.0 and before don't have the bug
due to lack of any logging at all here.
Tom Lane [2006年8月13日 21:10:04 +0000 (21:10 +0000)]
Cause psql to report both the returned data and the command status tag
for INSERT/UPDATE/DELETE RETURNING. Per discussion.
Tom Lane [2006年8月13日 20:39:07 +0000 (20:39 +0000)]
If test postmaster fails to start within 60 seconds, try to kill -9 it
so that it won't interfere with later trials. Per recent buildfarm
experience. Anyone know how to do this on Windows?
Tom Lane [2006年8月13日 19:31:06 +0000 (19:31 +0000)]
Extend 'guc' regression test to check manipulations of datestyle as
well as vacuum_cost_delay. Since datestyle is a string variable,
this exercises memory allocation issues that might not appear when
modifying an integer GUC variable. Also, we can observe the side
effects of changing datestyle to check that assign hooks are called
at the right times.
Tom Lane [2006年8月13日 17:58:49 +0000 (17:58 +0000)]
Original coding of 'returning' regression test inadvertently chose a
nonunique join value, leading to plan-choice-dependent results ... and
it seems some platforms will choose a different plan. Tweak the test
so that it has well-defined results. Per report from Olivier Prenant.
Back out plperl OUT hash/array parameter patch, again.
Fix recent guc comment-to-default patch for custom variables.
Applied patch for VPATH builds by Alvaro Herrera <alvherre@commandprompt.com>
Merged dyntest.pgc and dyntest2.pgc.
Hopefully fixed the last Coverity reports (finally)
Re-apply plperl patch that allows OUT parameters to be placed into Perl
hash and array variables. (regression output updated)
Recommit patch to allow commented GUC variables to return to their
default values.
Re-apply guc cleanup patch, with memory allocation bugs fixed.
Tom Lane [2006年8月12日 20:05:56 +0000 (20:05 +0000)]
Tweak SPI_cursor_open to allow INSERT/UPDATE/DELETE RETURNING; this was
merely a matter of fixing the error check, since the underlying Portal
infrastructure already handles it. This in turn allows these statements
to be used in some existing plpgsql and plperl contexts, such as a
plpgsql FOR loop. Also, do some marginal code cleanup in places that
were being sloppy about distinguishing SELECT from SELECT INTO.
Tom Lane [2006年8月12日 18:58:54 +0000 (18:58 +0000)]
Remove ancient, obsolete comment.
Back out patch for plperl to handle OUT paramaters into arrays and
hashes. Was causing regression failures.
Back out patch to reorganize guc processing. Was causing regression
failures.
Back out patch that allowed commented guc variables to return to their
default values. Was causing regression failures.
Done:
< o Allow INSERT/UPDATE ... RETURNING new.col or old.col
<
< This is useful for returning the auto-generated key for an INSERT.
< One complication is how to handle rules that run as part of
< the insert.
< http://archives.postgresql.org/pgsql-patches/2005-07/msg00568.php
> o -Allow INSERT/UPDATE ... RETURNING new.col or old.col
Fix wording, per Neil.
Tom Lane [2006年8月12日 02:52:06 +0000 (02:52 +0000)]
Add INSERT/UPDATE/DELETE RETURNING, with basic docs and regression tests.
plpgsql support to come later. Along the way, convert execMain's
SELECT INTO support into a DestReceiver, in order to eliminate some ugly
special cases.
Jonah Harris and Tom Lane
Set Win32 server-size socket buffer to 32k, for performance reasons.
Yoshiyuki Asaba
Done:
< o %Allow commenting of variables in postgresql.conf to restore them
> o -Allow commenting of variables in postgresql.conf to restore them
Revert undesired FAQ_DEV change.
Allow commenting of variables in postgresql.conf to restore them to
defaults.
Zdenek Kotala
Refactor GUC set_config_option function:
The main reason for refactoring was that set_config_option() was too
overloaded function and its behavior did not consistent. Old version of
set_config_function hides some messages. For example if you type:
tcp_port = 5432.1
then old implementation ignore this error without any message to log
file in the signal context (configuration reload). Main problem was that
semantic analysis of postgresql.conf is not perform in the
ProcessConfigFile function, but in the set_config_options *after*
context check. This skipped check for variables with PG_POSTMASTER
context. There was request from Joachim Wieland to add more messages
about ignored changes in the config file as well.
Zdenek Kotala
plperl:
Allow conversion from perl to postgresql array in OUT parameters. Second,
allow hash form output from procedures with one OUT argument.
Pavel Stehule
Make the psql line counter 64-bit so it can handle files > 4gig lines.
David Fetter
Add Neil's presentation to FAQ_DEV.
Fix typo.
Update for company URL.
Ian Barwick
Add URLs
< * Allow encoding on a per-column basis
> * Allow encoding on a per-column basis optionally using the ICU library:
> http://archives.postgresql.org/pgsql-patches/2005-08/msg00309.php
> http://archives.postgresql.org/pgsql-patches/2006-03/msg00233.php
Tom Lane [2006年8月10日 02:36:29 +0000 (02:36 +0000)]
Fix UNION/INTERSECT/EXCEPT so that when two inputs being merged have
same data type and same typmod, we show that typmod as the output
typmod, rather than generic -1. This responds to several complaints
over the past few years about UNIONs unexpectedly dropping length or
precision info.
Return inline to win32.h because code was OK, but keep additional
comment. 8.1.X is not affected by this commit.
Move "#define inline __inline" from port/win32.h to c.h because Win32
interface builds like libpq need it.
Backpatch addition to 8.1.X.
Fix display of log duration so it is milliseconds.microseconds "ms".
Greg Sabino Mullane
Tom Lane [Wed, 9 Aug 2006 22:48:17 +0000 (22:48 +0000)]
Fix inadequate makefile-fu in ecpg regression tests. I think this
will fix current platypus build failure.
Round microseconds on setitimer upwards.
On Win32, make minimum setitimer() sleep be 1ms, so sleeps < 1ms aren't
rounded down to zero.
Backpatch to 8.1.X.
Add URL for typmod:
> http://archives.postgresql.org/pgsql-hackers/2006-08/msg00149.php
Fix statement_timeout on Win32 so that it properly treats micro-seconds
as micro-seconds, rather than as 100 microseconds, as it does now. This
actually fixes all setitimer calls on Win32, but statement_timeout is
the most visible fix.
Backpatch to 8.1.X. 8.0 works as documented.
Formatting improvement.
Add URL:
> http://archives.postgresql.org/pgsql-performance/2004-08/msg00349.php
Add TODO items we don't want (Idea from Josh Berkus)
>
>
> Features We Do _Not_ Want
> =========================
>
> * All backends running as threads in a single process (not want)
>
> This eliminates the process protection we get from the current setup.
> Thread creation is usually the same overhead as process creation on
> modern systems, so it seems unwise to use a pure threaded model.
>
> * Optimizer hints (not want)
>
> Optimizer hints are used to work around problems in the optimizer. We
> would rather have the problems reported and fixed.
> http://archives.postgresql.org/pgsql-hackers/2006-08/msg00506.php
Update packages:
< A package would be a schema with public/private variables,
> A package would be a schema with session-local variables,
> http://archives.postgresql.org/pgsql-hackers/2006-08/msg00384.php
Fixed some memory bugs that somehow reappeared.
Also fixed a new Coverity report.
Fixed error handling in numeric conversion (Joachim).
Further regression cleanup.
Suppress MSVC warnings about weak functions by using
_CRT_SECURE_NO_DEPRECATE.
Hiroshi Saito
Update packages description:
< A package would be a schema with its own variables,
< private functions, and initialization functions. It
> A package would be a schema with public/private variables,
> public/private functions, and initialization functions. It
Update packages:
< private functions, and initialization functions
> private functions, and initialization functions. It
> is also possible to implement these capabilities
> in all schemas and not use a separate "packages"
> syntax at all.
Fix win32.mak for config cleanup.
Hiroshi Saito
Update:
< o COPY FROM STDIN not implemented because not useful?
> o Implement COPY FROM STDIN
Tom Lane [Tue, 8 Aug 2006 19:43:11 +0000 (19:43 +0000)]
Fix 'make clean' for change of regression.diffs file name.
Tom Lane [Tue, 8 Aug 2006 19:15:09 +0000 (19:15 +0000)]
Add a feature for automatic initialization and finalization of dynamically
loaded libraries: call functions _PG_init() and _PG_fini() if the library
defines such symbols. Hence we no longer need to specify an initialization
function in preload_libraries: we can assume that the library used the
_PG_init() convention, instead. This removes one source of pilot error
in use of preloaded libraries. Original patch by Ralf Engelschall,
preload_libraries changes by me.
Reverse order of performance guides so powerpostgresql is first.
Add detail on packages:
>
> A package would be a schema with its own variables,
> private functions, and initialization functions
>
Add package item:
< o Add Oracle-style packages
> o Add Oracle-style packages (Pavel)
> * Pavel is Pavel Stehule <pavel.stehule@hotmail.com>
Fix definition of "errcode" for MSVC.
Hiroshi Saito
Done:
< o Automatically force archiving of partially-filled WAL files when
> o -Automatically force archiving of partially-filled WAL files when
<
< Doing this will allow administrators to know more easily when
< the archive contains all the files needed for point-in-time
< recovery.
< http://archives.postgresql.org/pgsql-patches/2005-04/msg00121.php
<
< o Add reporting of the current WAL file and offset, perhaps as
> o -Add reporting of the current WAL file and offset, perhaps as
<
< The offset allows parts of a WAL file to be archived using
< an external program.
<
Fix bug introduced by last patch, thanks again to Mario Weilguni <mweilguni@sime.com>
Cleaned up log output a little bit more.
Clarified COPY FROM STDIN in ecpg todo
Made parser check for valid copy to/from stdin/stdout combinations.
Lots of small changes in regression test suite
Done:
< * Allow protocol-level BIND parameter values to be logged
<
< http://archives.postgresql.org/pgsql-hackers/2006-02/msg00165.php
> * -Allow protocol-level BIND parameter values to be logged, if text mode
This is the main PostgreSQL git repository.
RSS
Atom