git.postgresql.org Git - postgresql.git/log
I have attached 5 patches (split up for ease of review) to plperl.c.
1. Two minor cleanups:
- We don't need to call hv_exists+hv_fetch; we should just check the
return value of hv_fetch.
- newSVpv("undef",0) is the string "undef", not a real undef.
2. This should fix the bug Andrew Dunstan described in a recent -hackers
post. It replaces three bogus "eval_pv(key, 0)" calls with newSVpv,
and eliminates another redundant hv_exists+hv_fetch pair.
3. plperl_build_tuple_argument builds up a string of Perl code to create
a hash representing the tuple. This patch creates the hash directly.
4. Another minor cleanup: replace a couple of av_store()s with av_push.
5. Analogous to #3 for plperl_trigger_build_args. This patch removes the
static sv_add_tuple_value function, which does much the same as two
other utility functions defined later, and merges the functionality
into plperl_hash_from_tuple.
I have tested the patches to the best of my limited ability, but I would
appreciate it very much if someone else could review and test them too.
(Thanks to Andrew and David Fetter for their help with some testing.)
Abhijit Menon-Sen
This patch clarifies the usage of references in PL/Perl :)
David Fetter
Have log_duration only output when log_statement has printed the query.
This handles the new multiple log_statement values.
Ed L.
Update wording.
Update heading of Cygwin FAQ to be Cygwin-specific.
New wording on the three standards.
> This lets you do something like:
>
> ./configure LDFLAGS=-static-libgcc LDFLAGS_SL=-static-libgcc
>
> to produce binaries that do not depend on libgcc_s.so at all.
Oliver Jowett
Allow psql booleans to use OFF or off.
Michael Paesold
Fix pg_ctl -D handling for Win32:
C:\msys1円.0\home\y-asaba>pg_ctl -D data restart
waiting for postmaster to shut down...LOG: received smart shutdown
request.
LOG: shutting down
LOG: database system is shut down
done
postmaster stopped
postmaster starting
C:\msys1円.0\home\y-asaba>postmaster.exe: invalid argument: "'-D'"
Try "postmaster.exe --help" for more information.
Yoshiyuki Asaba
Add full path in error report for version mismatch of binaries.
psql code cleanup:
- refactor a bunch of code to call a separate function print_msg() which
checks whether "silent mode" is enabled before printing an error
message.
- rename "silence_mode" to "silent_mode", which IMHO makes more sense
- make the error messages we emit in "waiting" mode more consistent; I
believe this fixes a recent error message regression
Update mingw faq.
Update Win32 fAQ.
Add:
> * Allow libpq to access SQLSTATE so pg_ctl can test for connection failure
>
> This would be used for checking if the server is up.
>
Typo cleanup.
Update standards names.
Update 2003 as an official standard.
Add 'int' cast for getpid() because some Solaris releases return long
for getpid().
Add:
<
> * Prevent inet cast to cidr if the unmasked bits are not zero, or
> zero bits
Add "draft".
Reorder links.
More URL updates.
Update markup.
New urls.
Working improvement.
Fix markup.
Add standards URL's.
pg_restore wording improvement, per Peter.
Enable service use by Cygwin of pg_ctl.
Allow compiles for Cygwin /contrib modules.
Reini Urban
Enable static lib builds on Win32 and Cygwin.
Cleanup some unnecessary void * casts when using pfree() in contrib/xml
and contrib/xml2
More minor cosmetic improvements:
- remove another senseless "extern" keyword that was applied to a
function definition
- change a foo more function signatures from "some_type foo()" to
"some_type foo(void)"
- rewrite another K&R style function definition
- make the type of the "action" function pointer in the KeyWord struct
in src/backend/utils/adt/formatting.c more precise
Unbreak regression tests (Peter's recent checkin to executor/spi.c did
not update some error message text).
Add:
> * Add RESET CONNECTION command to reset all session state
329a331,334
> This would include resetting of all variables (RESET ALL), dropping of
> all temporary tables, removal of any NOTIFYs, etc. This could be used
> for connection pooling. We could also change RESET ALL to have this
> functionality.
Clarify pg_restore --help wording.
Update Cygwin build to not use DLLINIT, per Cygwin report from Reini
Urban
Message style revisions
New translation
Translation updates
Translation update
Tom Lane [2004年10月12日 15:44:15 +0000 (15:44 +0000)]
plpgsql EXIT construct forgot to downcase or quote-strip its identifier
argument, leading to label matching failures at run-time. Per report from
Patrick Fiche. Also, fix it so that an unrecognized label argument draws
a more useful error message than 'syntax error'.
Fix vpath build break, induced by Bruce's recent commit.
Fix a copy-and-paste error: give a distinct memory context a distinct
name, mainly for debugging purposes.
Tom Lane [2004年10月12日 01:49:48 +0000 (01:49 +0000)]
Update reference to pgsql-server.
Add some pg_config_path.h dependencies for places that include
pg_config_paths.h outside of /src/port.
Tom Lane [2004年10月11日 23:27:23 +0000 (23:27 +0000)]
Use -fPIC not -fpic for BSDen on Sparc. Also switch from
$(LD) -x -Bshareable to $(CC) -shared on OpenBSD (I suspect this
should be carried over to the other two as well, but will refrain
pending suggestions from people who actually use those platforms).
Per Stefan Kaltenbrunner.
Tom Lane [2004年10月11日 22:57:00 +0000 (22:57 +0000)]
Fix OR-index-scan planner to recognize that a partial index is usable
for scanning one term of an OR clause if the index's predicate is implied
by that same OR clause term (possibly in conjunction with top-level WHERE
clauses). Per recent example from Dawid Kuroczko,
http://archives.postgresql.org/pgsql-performance/2004-10/msg00095.php
Also, fix a very long-standing bug in index predicate testing, namely the
bizarre ordering of decomposition of predicate and restriction clauses.
AFAICS the correct way is to break down the predicate all the way, and
then for each component term see if you can prove it from the entire
restriction set. The original coding had a purely-implementation-artifact
distinction between ANDing at the top level and ANDing below that, and
proceeded to get the decomposition order wrong everywhere below the top
level, with the result that even slightly complicated AND/OR predicates
could not be proven. For instance, given
create index foop on foo(f2) where f1=42 or f1=1
or (f1 = 11 and f2 = 55);
the old code would fail to match this index to the query
select * from foo where f1 = 11 and f2 = 55;
when it obviously ought to match.
Use native Cygwin symlinks so tablespaces work on Win95/98/ME which
don't support junction points. Doesn't affect native Win32.
Tom Lane [2004年10月11日 19:32:19 +0000 (19:32 +0000)]
Another try at making plpython autoconfiguration work correctly. Use a
-L spec rather than assuming libpython is in the standard search path
(this returns to the way 7.4 did it). But check the distutils output
to see if it looks like Python has built a shared library, and if so
link with that instead of the probably-not-shared library found in
configdir.
Tom Lane [2004年10月11日 17:24:41 +0000 (17:24 +0000)]
Fix pg_indexes view so that it shows the index's tablespace not the
parent table's tablespace, as per gripe from Michael Kleiser. Choose
a more plausible column order for this view and pg_tables. Update
documentation of these views, which was missed in original patch.
Fix typo in comment.
Cosmetic improvements/code cleanup:
- replace some function signatures of the form "some_type foo()" with
"some_type foo(void)"
- replace a few instances of a literal 0 being used as a NULL pointer;
there are more instances of this in the code, but I just fixed a few
- in src/backend/utils/mb/wstrncmp.c, replace K&R style function
declarations with ANSI style, remove use of 'register' keyword
- remove an "extern" modifier that was applied to a function definition
(rather than a declaration)
Tom Lane [2004年10月10日 19:07:55 +0000 (19:07 +0000)]
Un-break plpython build for non-Windows platforms.
Tom Lane [2004年10月10日 16:13:03 +0000 (16:13 +0000)]
Remove gratuitous editorialization on rpath.
Tom Lane [Sat, 9 Oct 2004 23:13:22 +0000 (23:13 +0000)]
Adjust configuration-files GUC behavior as per my recent proposal.
The vars are renamed to data_directory, config_file, hba_file, and
ident_file, and are guaranteed to be set to accurate absolute paths
during postmaster startup.
This commit does not yet do anything about hiding path values from
non-superusers.
Translation improvement
Add win32 version information for pg_config Makefile.
Make getpid() use %d consistently for printing.
Add:
>
811a813,814
> o Re-enable timezone output on log_line_prefix '%t' when a
> shorter timezone string is available
Suppress timezone output on log_line_prefix %t on Win32, because it is
too long.
Add newline.
Add MinGW FAQ.
Move Win32 TODO items to main TODO list:
<
> * Win32
> o Remove per-backend parameter file and move into shared memory?
> o Remove configure.in check for link failure when cause is found
> o Remove readdir() errno patch when runtime/mingwex/dirent.c rev
> 1.4 is released
> o Remove psql newline patch when we find out why mingw outputs an
> extra newline
> o Allow psql to use readline once non-US code pages work with
> backslashes
Rename FAQ_MSWIN to FAQ_CYGWIN.
Tom Lane [Fri, 8 Oct 2004 15:03:26 +0000 (15:03 +0000)]
Include schema name in pg_restore -l output, per request from Phil Endecott.
Neil Conway [Fri, 8 Oct 2004 11:24:19 +0000 (11:24 +0000)]
Another minor tweak to psql startup: set the default values for the PROMPT1,
PROMPT2 and PROMPT3 variables before we read any of the settings specified
via the user on the command-line or in psqlrc, so that the latter can
override the former. Per original patch from Ingo van Lil, simpler fix
suggested by Tom Lane.
Tom Lane [Fri, 8 Oct 2004 04:22:59 +0000 (04:22 +0000)]
Tweak HPUX shared-library build flags, per Shinji Teragaito.
Update CIDR regresion tests to test for network masks inside the last
byte being tested, to catch any future breakage.
Tom Lane [Fri, 8 Oct 2004 01:36:36 +0000 (01:36 +0000)]
Whack some sense into the configuration-file-location patch.
Refactor code into something reasonably understandable, cause
use of the feature to not fail in standalone backends or in
EXEC_BACKEND case, fix sloppy guc.c table entries, make the
documentation minimally usable.
Do proper testing of CIDR bits against network mask, e.g. don't allow:
test=# select '204.248.199.1/31'::cidr;
Previous releases erroneously accepted such addresses.
WARN IN RELEASE NOTES
Kevin Brintnall
Pull comment down into its own paragraph.
Add:
* Consider parallel processing a single query
This would involve using multiple threads or processes to do optimization,
sorting, or execution of single query. The major advantage of such a
feature would be to allow multiple CPUs to work together to process a
single query.
Remove benchmark comment.
Tom Lane [Thu, 7 Oct 2004 20:36:52 +0000 (20:36 +0000)]
Change get_rule_expr so that when the input is a List, it displays the
list elements comma-separated instead of barfing. This allows elimination
of half a dozen redundant copies of that behavior, and also makes the
world safe again for pg_get_expr() applied to pg_index.indexprs, per gripe
from Alexander Zhiltsov.
Remove mention of -Q option for bench.
Move -DPLPERL_HAVE_UID_GID to the plperl Makefile, for Win32 only.
Tom Lane [Thu, 7 Oct 2004 18:57:26 +0000 (18:57 +0000)]
Add missing null terminator to escaped string; clean up unnecessarily
obscurantist coding conventions.
Add PLperl workaround for Win32 to the *.xs file.
Tom Lane [Thu, 7 Oct 2004 18:38:51 +0000 (18:38 +0000)]
Fix problems with SQL functions returning rowtypes that have dropped
columns. The returned tuple needs to have appropriate NULL columns
inserted so that it actually matches the declared rowtype. It seemed
convenient to use a JunkFilter for this, so I made some cleanups and
simplifications in the JunkFilter code to allow it to support this
additional functionality. (That in turn exposed a latent bug in
nodeAppend.c, which is that it was returning a tuple slot whose
descriptor didn't match its data.) Also, move check_sql_fn_retval
out of pg_proc.c and into functions.c, where it seems to more naturally
belong.
Add one more byte to malloc for null storage.
Remove unneeded dash.
Update comment to fix nibble mention:
* We are not sure how much precision is in tv_usec, so we
* swap the high and low 16 bits of 'later' and XOR them with
* 'earlier'. On the off chance that the result is 0, we
* loop until it isn't.
Greg Stark
Escape single quotes and backslashes used in locales placed in
postgresql.conf.
Zhong Xubin
Prevent install error message when doing cmp on empty tree.
Adjust comments previously moved to column 1 by pgident.
Back out unindented modification to file.
Indent comment pushed to new line by else so it is indented by BSD
indent.
Add as binary mode
re-add as binary
Improve pgindent processing of comment after 'else'.
Improve comment of pg_dump Win32 link workaround.
Improve comment after 'else' handling of pgindent.
Neil Conway [Thu, 7 Oct 2004 00:08:04 +0000 (00:08 +0000)]
Allow the spinlock test to be compiled successfully in a vpath build.
Tom Lane [Thu, 7 Oct 2004 00:03:15 +0000 (00:03 +0000)]
XOR process PID into a backend's initial random seed, to ensure that
different backends get a reasonably wide set of initial seeds even if
gettimeofday returns tv_usec values with only a few bits of precision.
Per recent discussion.
Neil Conway [Wed, 6 Oct 2004 23:41:59 +0000 (23:41 +0000)]
Document what the "rep; nop" x86 assembler sequence is actually equivalent
to, and what it is intended to do.
Neil Conway [Wed, 6 Oct 2004 23:31:45 +0000 (23:31 +0000)]
Capitalize some SQL keywords the previous commit missed, for consistency.
Say "history is not supported" and remove "on this platform" for lack of
readline.
Suppress psql \s help display for platforms like Win32 that don't
typically install witn readline, and throw an error if they try to
access it.
Add mention of win32ver.rc for update for minor release.
Fix improper defines for uid_t and gid_t. Had them backwards.
This is the main PostgreSQL git repository.
RSS
Atom