git.postgresql.org Git - postgresql.git/log
Tom Lane [2007年2月16日 23:32:08 +0000 (23:32 +0000)]
Teach find_nonnullable_rels to handle OR cases: if every arm of an OR
forces a particular relation nonnullable, then we can say that the OR does.
This is worth a little extra trouble since it may allow reduction of
outer joins to plain joins.
Add:
> o Consider reducing on-disk varlena length from four to two
> because a heap row cannot be more than 64k in length
Tom Lane [2007年2月16日 22:04:02 +0000 (22:04 +0000)]
Fix new RI operator selection code to do the right thing when working with
an opclass for a generic type such as ANYARRAY. The original coding failed
to check that PK and FK columns were of the same array type. Per discussion
with Tom Dunstan. Also, make the code a shade more readable by not trying
to economize on variables.
Reduce the amount of memory "clobbered" for every process title change,
on platforms that need this. This is done by only writing past the
previously stored message, if it was longer.
Tom Lane [2007年2月16日 20:57:19 +0000 (20:57 +0000)]
Adjust the definition of is_pushed_down so that it's always true for INNER
JOIN quals, just like WHERE quals, even if they reference every one of the
join's relations. Now that we can reorder outer and inner joins, it's
possible for such a qual to end up being assigned to an outer join plan node,
and we mustn't have it treated as a join qual rather than a filter qual for
the node. (If it were, the join could produce null-extended rows that it
shouldn't.) Per bug report from Pelle Johansson.
Better fix for determining minimum and maximum int64 values that doesn't
require stdint.h and works for "busted" int64.
Install a more correct fix in the timestamp and timestamptz regression tests:
remove duplicated tests in timestamp, and complete timestamptz with the tests
that were missing to more closely mirror timestamp.
Tom Lane [2007年2月16日 17:07:00 +0000 (17:07 +0000)]
Code review for SSLKEY patch.
Tom Lane [2007年2月16日 16:37:29 +0000 (16:37 +0000)]
Fix markup, spelling, grammar, and explanations for SSLKEY patch.
Fix the timestamptz test problem, by moving the tests that use the
timestamp_tbl table into the timestamp test. Also, restore a test that
used to exist as a valid test in the timestamptz test.
Fix // comment
Add stdint.h include
Functions for mapping table data and table schemas to XML (a.k.a. XML export)
Remove extra character erroneously added.
Remove tabs from SGML files to help tag alingment and improve
detection of tabs are added in the future.
Tom Lane [2007年2月16日 03:49:04 +0000 (03:49 +0000)]
Fix another problem in 8.2 changes that allowed "one-time" qual conditions to
be checked at plan levels below the top; namely, we have to allow for Result
nodes inserted just above a nestloop inner indexscan. Should think about
using the general Param mechanism to pass down outer-relation variables, but
for the moment we need a back-patchable solution. Per report from Phil Frost.
Add two new format fields for use with to_char(), to_date() and
to_timestamp():
- ID for day-of-week
- IDDD for day-of-year
This makes it possible to convert ISO week dates to and from text
fully represented in either week ('IYYY-IW-ID') or day-of-year
('IYYY-IDDD') format.
I have also added an 'isoyear' field for use with extract / date_part.
Brendan Jurd
SSL improvements:
o read global SSL configuration file
o add GUC "ssl_ciphers" to control allowed ciphers
o add libpq environment variable PGSSLKEY to control SSL hardware keys
Victor B. Wagner
Remove useless database name from bootstrap argument processing (including
startup and bgwriter processes), and the -y flag. It's not used anywhere.
Tom Lane [2007年2月16日 00:14:01 +0000 (00:14 +0000)]
Restructure code that is responsible for ensuring that clauseless joins are
considered when it is necessary to do so because of a join-order restriction
(that is, an outer-join or IN-subselect construct). The former coding was a
bit ad-hoc and inconsistent, and it missed some cases, as exposed by Mario
Weilguni's recent bug report. His specific problem was that an IN could be
turned into a "clauseless" join due to constant-propagation removing the IN's
joinclause, and if the IN's subselect involved more than one relation and
there was more than one such IN linking to the same upper relation, then the
only valid join orders involve "bushy" plans but we would fail to consider the
specific paths needed to get there. (See the example case added to the join
regression test.) On examining the code I wonder if there weren't some other
problem cases too; in particular it seems that GEQO was defending against a
different set of corner cases than the main planner was. There was also an
efficiency problem, in that when we did realize we needed a clauseless join
because of an IN, we'd consider clauseless joins against every other relation
whether this was sensible or not. It seems a better design is to use the
outer-join and in-clause lists as a backup heuristic, just as the rule of
joining only where there are joinclauses is a heuristic: we'll join two
relations if they have a usable joinclause *or* this might be necessary to
satisfy an outer-join or IN-clause join order restriction. I refactored the
code to have just one place considering this instead of three, and made sure
that it covered all the cases that any of them had been considering.
Backpatch as far as 8.1 (which has only the IN-clause form of the disease).
By rights 8.0 and 7.4 should have the bug too, but they accidentally fail
to fail, because the joininfo structure used in those releases preserves some
memory of there having once been a joinclause between the inner and outer
sides of an IN, and so it leads the code in the right direction anyway.
I'll be conservative and not touch them.
Restructure autovacuum in two processes: a dummy process, which runs
continuously, and requests vacuum runs of "autovacuum workers" to postmaster.
The workers do the actual vacuum work. This allows for future improvements,
like allowing multiple autovacuum jobs running in parallel.
For now, the code keeps the original behavior of having a single autovac
process at any time by sleeping until the previous worker has finished.
Tom Lane [2007年2月15日 05:05:03 +0000 (05:05 +0000)]
Add ORDER BY to a query on information_schema.views, to avoid possible
platform-specific result ordering. Per buildfarm results.
Tom Lane [2007年2月15日 03:07:13 +0000 (03:07 +0000)]
Repair oversight in 8.2 change that improved the handling of "pseudoconstant"
WHERE clauses. createplan.c is now willing to stick a gating Result node
almost anywhere in the plan tree, and in particular one can wind up directly
underneath a MergeJoin node. This means it had better be willing to handle
Mark/Restore. Fortunately, that's trivial in such cases, since we can just
pass off the call to the input node (which the planner has previously ensured
can handle Mark/Restore). Per report from Phil Frost.
Make it possible to build with integer datetimes in msvc, and enable by default.
Add:
>
> o Use LC_TIME for localized weekday/month names, rather than
> LC_MESSAGES
>
> http://archives.postgresql.org/pgsql-hackers/2006-11/msg00390.php
Tom Lane [2007年2月14日 20:47:15 +0000 (20:47 +0000)]
Add some discussion of sort ordering to indices.sgml, which curiously
had never touched the subject before.
Fix typo
Fix to_date()/to_timestamp() 'D' field for day of week, was off by one.
Converting from char using 'D' doesn't make lots of sense, of course.
Report from Brendan Jurd.
Move fsync method macro defines into /include/access/xlogdefs.h so they
can be used by src/tools/fsync/test_fsync.c.
Tom Lane [2007年2月14日 04:30:26 +0000 (04:30 +0000)]
Minor editorialization on operator-family documentation: put some
copied-and-pasted text in a more useful location.
Add:
> * Clean up casting in /contrib/isn
>
> http://archives.postgresql.org/pgsql-hackers/2006-11/msg00245.php
>
Add:
> * Improve logging of prepared statements recovered during startup
>
> http://archives.postgresql.org/pgsql-hackers/2006-11/msg00092.php
>
Fix capitalization and punctuation of two more GUC description strings.
Add URL for:
* Allow SQL-language functions to return results from RETURNING queries
>
> http://archives.postgresql.org/pgsql-hackers/2006-10/msg00665.php
>
Tom Lane [2007年2月14日 01:58:58 +0000 (01:58 +0000)]
Fix up foreign-key mechanism so that there is a sound semantic basis for the
equality checks it applies, instead of a random dependence on whatever
operators might be named "=". The equality operators will now be selected
from the opfamily of the unique index that the FK constraint depends on to
enforce uniqueness of the referenced columns; therefore they are certain to be
consistent with that index's notion of equality. Among other things this
should fix the problem noted awhile back that pg_dump may fail for foreign-key
constraints on user-defined types when the required operators aren't in the
search path. This also means that the former warning condition about "foreign
key constraint will require costly sequential scans" is gone: if the
comparison condition isn't indexable then we'll reject the constraint
entirely. All per past discussions.
Along the way, make the RI triggers look into pg_constraint for their
information, instead of using pg_trigger.tgargs; and get rid of the always
error-prone fixed-size string buffers in ri_triggers.c in favor of building up
the RI queries in StringInfo buffers.
initdb forced due to columns added to pg_constraint and pg_trigger.
Add URL for:
>
> http://archives.postgresql.org/pgsql-performance/2006-10/msg00222.php
>
Add URL for:
* Update Bonjour to work with newer cross-platform SDK
> http://archives.postgresql.org/pgsql-patches/2006-10/msg00048.php
Add:
> * Improve failure message when DROP DATABASE is used on a database that
> has prepared transactions
Tom Lane [2007年2月13日 19:39:42 +0000 (19:39 +0000)]
Disallow committing a prepared transaction unless we are in the same database
it was executed in. Someday it might be nice to allow cross-DB commits, but
work would be needed in NOTIFY and perhaps other places. Per Heikki.
Tom Lane [2007年2月13日 19:18:54 +0000 (19:18 +0000)]
Improve postmaster's behavior if an accept() call fails. Because the server
socket is still read-ready, the code was a tight loop, wasting lots of CPU.
We can't do anything to clear the failure, other than wait, but we should give
other processes more chance to finish and release FDs; so insert a small sleep.
Also, avoid bogus "close(-1)" in this case. Per report from Jim Nasby.
Add URL for:
* Update Bonjour to work with newer cross-platform SDK
>
> http://archives.postgresql.org/pgsql-hackers/2006-09/msg02238.php
>
Add code so database scans are done in an order consistent with
pg_dumpall.
Update /contrib/fuzzystrmatch error message to mention bytes, not just
'length', which can be characters.
Add ORDER BY to vacummdb so databases are scaned in the same order as
pg_dumpall.
Add:
> * Update our code to handle 64-bit timezone files to match the zic
> source code, which now uses them
Un-break build on ANSI compilers (like msvc) by moving Assert to position
after variable declarations.
Add script to run regression tests under vc++ without mingw. Update
clean script to properly clean up the result of it.
One more fix for makefile := to : change.
Properly parse Makefile after change from := to =.
Tom Lane [2007年2月13日 02:31:03 +0000 (02:31 +0000)]
Repair bug in 8.2's new logic for planning outer joins: we have to allow joins
that overlap an outer join's min_righthand but aren't fully contained in it,
to support joining within the RHS after having performed an outer join that
can commute with this one. Aside from the direct fix in make_join_rel(),
fix has_join_restriction() and GEQO's desirable_join() to consider this
possibility. Per report from Ian Harding.
Add comment to explain why O_EXCL and O_TRUNC can be ignored in
openFlagsToCreateFileFlags() in certain cases.
Add comment that to_char() for broken glibc pt_BR might cause a problem.
Tom Lane [2007年2月12日 17:19:30 +0000 (17:19 +0000)]
Avoid infinite recursion when dumping new planner EquivalenceClass trees.
Fix backend crash in parsing incorrect tsquery.
Per report from Jon Rosebaugh <jon@inklesspen.com>
Add support for optionally escaping periods when converting SQL identifiers
to XML names, which will be required for supporting XML export.
Tom Lane [2007年2月11日 19:31:45 +0000 (19:31 +0000)]
Fix another erroneous =-for-:= substitution.
Fixed multibyte handling as reported by <harada.toshi@oss.ntt.co.jp>.
Fix for early log messages during postmaster startup getting lost when
running as a service on Win32.
Per report from Harald Armin Massa.
Tom Lane [2007年2月10日 20:43:59 +0000 (20:43 +0000)]
Improve documentation for CREATE CONSTRAINT TRIGGER.
Fix pg_standby to build on msvc.
Add proper mapping of boolean type data to XML Schema.
StrNCpy -> strlcpy (not complete)
Tom Lane [2007年2月10日 04:26:24 +0000 (04:26 +0000)]
Put back some not-so-unnecessary-as-all-that := usages. Per buildfarm.
Tom Lane [2007年2月10日 04:18:32 +0000 (04:18 +0000)]
Hm, seems my hack on rowtypes regression test has made its output row
order platform-specific. Add an ORDER BY clause to stop buildfarm
failures.
Neil Conway [Fri, 9 Feb 2007 20:40:13 +0000 (20:40 +0000)]
Unbreak the SGML doc build: ":=" is needed to assign to variables if
the RHS of the assignment expands to a reference to the LHS.
Tom Lane [Fri, 9 Feb 2007 20:17:59 +0000 (20:17 +0000)]
Minor tweak to make rowtypes regression test run faster. We don't
currently have any better strategy for this query than re-running the
sub-select over and over; it seems unlikely that doing so 10000 times
is a more useful test than doing it a few dozen times.
Remove useless CPPFLAGS.
Add $PostgreSQL$ marker to contrib makefiles.
Tom Lane [Fri, 9 Feb 2007 16:12:19 +0000 (16:12 +0000)]
Call pgstat_drop_database during DROP DATABASE, so that any stats file
entries for the victim database go away sooner rather than later. We already
did the equivalent thing at the per-relation level, not sure why it's not
been done for whole databases. With this change, pgstat_vacuum_tabstat
should usually not find anything to do; though we still need it as a backstop
in case DROPDB or TABPURGE messages get lost under load.
Replace useless uses of := by = in makefiles.
Remove blank lines in code.
Update FAQ for new 24-byte header, down from 28.
Add blank line.
Add URL for:
<
> http://archives.postgresql.org/pgsql-hackers/2007-02/msg00435.php
Done!
< * Merge xmin/xmax/cmin/cmax back into three header fields
<
< Before subtransactions, there used to be only three fields needed to
< store these four values. This was possible because only the current
< transaction looks at the cmin/cmax values. If the current transaction
< created and expired the row the fields stored where xmin (same as
< xmax), cmin, cmax, and if the transaction was expiring a row from a
< another transaction, the fields stored were xmin (cmin was not
< needed), xmax, and cmax. Such a system worked because a transaction
< could only see rows from another completed transaction. However,
< subtransactions can see rows from outer transactions, and once the
< subtransaction completes, the outer transaction continues, requiring
< the storage of all four fields. With subtransactions, an outer
< transaction can create a row, a subtransaction expire it, and when the
< subtransaction completes, the outer transaction still has to have
< proper visibility of the row's cmin, for example, for cursors.
<
< One possible solution is to create a phantom cid which represents a
< cmin/cmax pair and is stored in local memory. Another idea is to
< store both cmin and cmax only in local memory.
<
> * -Merge xmin/xmax/cmin/cmax back into three header fields
Tom Lane [Fri, 9 Feb 2007 03:35:35 +0000 (03:35 +0000)]
Combine cmin and cmax fields of HeapTupleHeaders into a single field, by
keeping private state in each backend that has inserted and deleted the same
tuple during its current top-level transaction. This is sufficient since
there is no need to be able to determine the cmin/cmax from any other
transaction. This gets us back down to 23-byte headers, removing a penalty
paid in 8.0 to support subtransactions. Patch by Heikki Linnakangas, with
minor revisions by moi, following a design hashed out awhile back on the
pghackers list.
Remove blank line from C code.
Update:
< * Consider placing all sequences in a single table
> * Consider placing all sequences in a single table, or create a system
> view
Update:
< * Consider placing all sequences in a single table, now that system
< tables are full transactional
> * Consider placing all sequences in a single table
Add:
> * Consider placing all sequences in a single table, now that system
> tables are full transactional
Add URL for:
* Add support for SQL-standard GENERATED/IDENTITY columns
> http://archives.postgresql.org/pgsql-hackers/2006-08/msg00038.php
Tom Lane [Thu, 8 Feb 2007 19:48:28 +0000 (19:48 +0000)]
Add missing #define for mingw, per Magnus.
Tom Lane [Thu, 8 Feb 2007 18:37:30 +0000 (18:37 +0000)]
Fix an ancient logic error in plpgsql's exec_stmt_block: it thought it could
get away with not (re)initializing a local variable if the variable is marked
"isconst" and not "isnull". Unfortunately it makes this decision after having
already freed the old value, meaning that something like
for i in 1..10 loop
declare c constant text := 'hi there';
leads to subsequent accesses to freed memory, and hence probably crashes.
(In particular, this is why Asif Ali Rehman's bug leads to crash and not
just an unexpectedly-NULL value for SQLERRM: SQLERRM is marked CONSTANT
and so triggers this error.)
The whole thing seems wrong on its face anyway: CONSTANT means that you can't
change the variable inside the block, not that the initializer expression is
guaranteed not to change value across successive block entries. Hence,
remove the "optimization" instead of trying to fix it.
Tom Lane [Thu, 8 Feb 2007 18:37:14 +0000 (18:37 +0000)]
Rearrange use of plpgsql_add_initdatums() so that only the parsing of a
DECLARE section needs to know about it. Formerly, everyplace besides DECLARE
that created variables needed to do "plpgsql_add_initdatums(NULL)" to prevent
those variables from being sucked up as part of a subsequent DECLARE block.
This is obviously error-prone, and in fact the SQLSTATE/SQLERRM patch had
failed to do it for those two variables, leading to the bug recently exhibited
by Asif Ali Rehman: a DECLARE within an exception handler tried to reinitialize
SQLERRM.
Although the SQLSTATE/SQLERRM patch isn't in any pre-8.1 branches, and so
I can't point to a demonstrable failure there, it seems wise to back-patch
this into the older branches anyway, just to keep the logic similar to HEAD.
Fix bug when localized to_char() day or month names were incorectly
trnasformed to lower or upper string.
Pavel Stehule
This patch fixes shared_preload_libraries on Windows hosts. It forces
ach backend to re-load all shared_preload_libraries.
Korry Douglas
Add lock matrix to documentation.
Teodor Sigaev
Win32 regression test fixes:
For win32 in general, this makes it possible to run the regression tests
as an admin user by using the same restricted token method that's used
by pg_ctl and initdb.
For vc++, it adds building of pg_regress.exe, adds a resultmap, and
fixes how it runs the install.
Magnus Hagander
Add /contrib/pg_standby:
pg_standby is a production-ready program that can be used to
create a Warm Standby server. Other configuration is required
as well, all of which is described in the main server manual.
Simon Riggs
Add /contrib/pg_standby:
pg_standby is a production-ready program that can be used to
create a Warm Standby server. Other configuration is required
as well, all of which is described in the main server manual.
Simon Riggs
Fix reference-after-free in the new btree page split code, as reported by
the buildfarm via Stefan Kaltenbrunner.
Patch from Heikki Linnakangas.
Normalize fgets() calls to use sizeof() for calculating the buffer size
where possible, and fix some sites that apparently thought that fgets()
will overwrite the buffer by one byte.
Also add some strlcpy() to eliminate some weird memory handling.
Reduce WAL activity for page splits:
> Currently, an index split writes all the data on the split page to
> WAL. That's a lot of WAL traffic. The tuples that are copied to the
> right page need to be WAL logged, but the tuples that stay on the
> original page don't.
Heikki Linnakangas
Check if the role exists before doing more complex ident and Kerberos
authentication checks in the backend.
Gavin Sherry
Update URL for "Generalized Partial Indexes" paper to point to a cached
version.
Backpatch to 8.2.X.
Document that wal_sync_method open_* methods use O_DIRECT, if available.
Backpatch to 8.2.X.
Fix bug in our code when using to_timestamp() or to_date() without "TM".
Assume "TM" when input fields are variable-length, like month or day
names. This matches Oracle behavior.
Tom Lane [Wed, 7 Feb 2007 23:11:30 +0000 (23:11 +0000)]
Add a function pg_stat_clear_snapshot() that discards any statistics snapshot
already collected in the current transaction; this allows plpgsql functions to
watch for stats updates even though they are confined to a single transaction.
Use this instead of the previous kluge involving pg_stat_file() to wait for
the stats collector to update in the stats regression test. Internally,
decouple storage of stats snapshots from transaction boundaries; they'll
now stick around until someone calls pgstat_clear_snapshot --- which xact.c
still does at transaction end, to maintain the previous behavior. This makes
the logic a lot cleaner, at the price of a couple dozen cycles per transaction
exit.
Tom Lane [Wed, 7 Feb 2007 18:34:56 +0000 (18:34 +0000)]
Modify the stats regression test to delay until the stats file actually
changes (with an upper limit of 30 seconds), and record the delay time in
the postmaster log. This should give us some info about what's happening
with the intermittent stats failures in buildfarm. After an idea of
Andrew Dunstan's.
Tom Lane [Wed, 7 Feb 2007 16:44:48 +0000 (16:44 +0000)]
Remove the xlog-centric "database system is ready" message and replace it with
"database system is ready to accept connections", which is issued by the
postmaster when it really is ready to accept connections. Per proposal from
Markus Schiltknecht and subsequent discussion.
This is the main PostgreSQL git repository.
RSS
Atom