git.postgresql.org Git - postgresql.git/log
pgindent run for 9.0
Add pgindent typedefs file to CVS.
Update pgindent instructions to avoid changes to flex output files.
Remove 'emphasis' markup inside literal; not allowed.
Document that after triggers that need to see changed rows should not be
marked stable.
Tom Lane [2010年2月25日 20:59:53 +0000 (20:59 +0000)]
Allow predicate_refuted_by() to deduce that NOT A refutes A.
We had originally made the stronger assumption that NOT A refutes any B
if B implies A, but this fails in three-valued logic, because we need to
prove B is false not just that it's not true. However the logic does
go through if B is equal to A.
Recognizing this limited case is enough to handle examples that arise when
we have simplified "bool_var = true" or "bool_var = false" to just "bool_var"
or "NOT bool_var". If we had not done that simplification then the
btree-operator proof logic would have been able to prove that the expressions
were contradictory, but only for identical expressions being compared to the
constants; so handling identical A and B covers all the same cases.
The motivation for doing this is to avoid unexpected asymmetrical behavior
when a partitioned table uses a boolean partitioning column, as in today's
gripe from Dominik Sander.
Back-patch to 8.2, which is as far back as predicate_refuted_by attempts to
do anything at all with NOTs.
Document clearly the meaning of none/all for log_statements.
Add C comment that do_to_timestamp() lacks error checking.
Clearly document that timestamp alone means timestamp without timezone,
per SQL standard, and mention 7.3 behavior at the end.
Add configuration parameter ssl_renegotiation_limit to control
how often we do SSL session key renegotiation. Can be set to
0 to disable renegotiation completely, which is required if
a broken SSL library is used (broken patches to CVE-2009-3555
a known cause) or when using a client library that can't do
renegotiation.
Fix typos, per Richard Huxton
Clarify that the connection string for primary_conninfo is in the same
format as in PQconnectdb(). As pointed out by Thom Brown.
Fix typo.
Small streaming replication document improvements. Be more explicit that
it's asynchronous.
Fix streaming replication starting at the very first WAL segment.
Per complaint from Greg Stark.
Tom Lane [2010年2月25日 03:08:07 +0000 (03:08 +0000)]
Improve warning about creating nested named subroutines in plperl.
Per discussion.
Tom Lane [2010年2月25日 02:17:50 +0000 (02:17 +0000)]
Make pg_stop_backup's reporting a bit more verbose in hopes of making
error cases less intimidating for novices. Per discussion.
Greg Smith
Tom Lane [2010年2月24日 18:02:24 +0000 (18:02 +0000)]
Allow zero-dimensional (ie, empty) arrays in contrib/ltree operations.
The main motivation for changing this is bug #4921, in which it's pointed out
that it's no longer safe to apply ltree operations to the result of
ARRAY(SELECT ...) if the sub-select might return no rows. Before 8.3,
the ARRAY() construct would return NULL, which might or might not be helpful
but at least it wouldn't result in an error. Now it returns an empty array
which results in a failure for no good reason, since the ltree operations
are all perfectly capable of dealing with zero-element arrays.
As far as I can find, these ltree functions are the only places where zero
array dimensionality is rejected unnecessarily.
Back-patch to 8.3 to prevent behavioral regression of queries that worked
in older releases.
Document that pg_restore -t can use -n for its schema qualification.
Revert removal of pre-7.4 documenation behavior mentions.
Remove stray semicolon, per report from strk
Remove useless codes to initialize TupleDesc from dblink_exec.
Remove pre-7.4 documentaiton mentions, now that 8.0 is the oldest
supported release.
Tom Lane [2010年2月24日 02:42:55 +0000 (02:42 +0000)]
Fix patch for printing backend and pg_dump versions so that it works in
a desirable fashion in archive-dump cases, ie you should get the pg_dump
version not the pg_restore version.
Tom Lane [2010年2月24日 02:15:58 +0000 (02:15 +0000)]
Un-break pg_dump for the case of zero-column tables.
This was evidently broken by the CREATE TABLE OF TYPE patch. It would have
been noticed if anyone had bothered to try dumping and restoring the
regression database ...
Tom Lane [2010年2月24日 01:57:16 +0000 (01:57 +0000)]
Use CREATE OR REPLACE LANGUAGE in pg_dump to avoid the need for a couple of
significantly uglier kluges that were working around the change in plpgsql's
preinstalled status.
Tom Lane [2010年2月24日 01:35:14 +0000 (01:35 +0000)]
Make pg_regress use CREATE OR REPLACE LANGUAGE, so that --load-language
will work whether or not the specified language is preinstalled. This
responds to some complaints about having to change test scripts because
plpgsql is preinstalled as of 9.0.
Tom Lane [2010年2月23日 22:51:43 +0000 (22:51 +0000)]
Add an OR REPLACE option to CREATE LANGUAGE.
This operates in the same way as other CREATE OR REPLACE commands, ie,
it replaces everything but the ownership and ACL lists of an existing
entry, and requires the caller to have owner privileges for that entry.
While modifying an existing language has some use in development scenarios,
in typical usage all the "replaced" values come from pg_pltemplate so there
will be no actual change in the language definition. The reason for adding
this is mainly to allow programs to ensure that a language exists without
triggering an error if it already does exist.
This commit just adds and documents the new option. A followon patch
will use it to clean up some unpleasant cases in pg_dump and pg_regress.
Modify freebsd start script to just exit 0 with message.
Update startup scripts for Linux and FreeBSD.
Kevin Grittner
Have pg_dump (-v) verbose mode output the pg_dump and server versions in
text output mode, like we do in custom output mode.
Jim Cox
Revert recent COPY manual change about encoding; add mention of "server".
Tom Lane [2010年2月23日 18:35:07 +0000 (18:35 +0000)]
Fix configure's regexp for extracting the Perl version number from perl -v
output. Per bug #5339, Perl 5.11 has changed the format of that output
enough to break the previous coding.
Alex Hunsaker
Tom Lane [2010年2月23日 17:28:09 +0000 (17:28 +0000)]
Clarify statements about tar archive format.
Tom Lane [2010年2月23日 16:55:22 +0000 (16:55 +0000)]
Minor style policing for error messages in pg_dump tar code. Notably, change
"dumping data out of order is not supported" to "restoring data out of order
is not supported", because you get that error during pg_restore not pg_dump.
Also fix some comments that didn't look so good after being pgindented as
perhaps they did originally.
Revert recent change of to_char('HH12') handling for intervals; instead
improve documentation, and add C comment.
Secondary patch to fix interval to_char() for "HH" where hours >= 12.
Tom Lane [2010年2月23日 05:44:55 +0000 (05:44 +0000)]
Some platforms reject fsync() on files opened O_RDONLY.
Make documentation more direct about the handling of COPY files based on
the client encoding.
Document that expression indexes that call functions allow function-level
statistics.
Supress convertion of zero hours to '12' for intervals when using
to_char with HH, e.g.
to_char(interval '0d 0h 12m 44s', 'DD HH24 MI SS');
now returns:
00 00 12 44
not:
00 12 12 44
Update pg_restore documentation to show new pg_restore custom listing
format.
Pavel Golub
Remove long-commented-out paragraph in documentation about function
inheritance in create table, per Andrew Dunstan.
Document that pg_ctl cares about the PGHOST environment variable.
Revert configure warning to use "official distribution".
Remove protocol documentation paragraph about environment variable
passing being "covered elsewhere", per Dave Page.
Use the term "bundled distribution" instead of "official distribution" in
configure warnings.
Briefly document in two places that pg_dump and pg_dumpall cannot be
used for continuous archiving.
Tom Lane [2010年2月22日 15:29:46 +0000 (15:29 +0000)]
Let's try forcing errno to zero before issuing fsync. The current buildfarm
results claiming EBADF seem improbable enough that I'm not convinced fsync
is really returning that --- could it be failing to set errno at all?
Tom Lane [2010年2月22日 15:26:14 +0000 (15:26 +0000)]
Adjust pg_fsync_writethrough so that it will set errno when failing
on a platform that doesn't support this operation. The former coding
would allow an unrelated errno to be reported, which would be quite
misleading. Not sure if this has anything to do with the current
buildfarm failures, but it's certainly bogus as-is.
Move documentation of all recovery.conf option to a new chapter.
They used to be scattered between the "backup and restore" and "streaming
replication" chapters.
Tom Lane [2010年2月22日 02:50:10 +0000 (02:50 +0000)]
Fix multiple copy and paste-o's. No wonder this code didn't work.
Greg Stark [2010年2月22日 00:11:05 +0000 (00:11 +0000)]
Oops, don't forget to rewind the directory before scanning it to fsync files in CREATE DATABASE
Adjust sample auto-explain output to reflect query text inclusion.
Tom Lane [2010年2月20日 21:24:02 +0000 (21:24 +0000)]
Clean up handling of XactReadOnly and RecoveryInProgress checks.
Add some checks that seem logically necessary, in particular let's make
real sure that HS slave sessions cannot create temp tables. (If they did
they would think that temp tables belonging to the master's session with
the same BackendId were theirs. We *must* not allow myTempNamespace to
become set in a slave session.)
Change setval() and nextval() so that they are only allowed on temp sequences
in a read-only transaction. This seems consistent with what we allow for
table modifications in read-only transactions. Since an HS slave can't have a
temp sequence, this also provides a nicer cure for the setval PANIC reported
by Erik Rijkers.
Make the error messages more uniform, and have them mention the specific
command being complained of. This seems worth the trifling amount of extra
code, since people are likely to see such messages a lot more than before.
Make 'include_realm' ordering consistent in the docs, to match recent
doc change.
Clarify documentation about username mapping when authenticating with
GSSAPI or Kerberos.
Ian Turner
Document that many solid-state drives have volatile write-back caches.
Copy editing of Hot Standby docs. Some clarifications, addition
of missing items and minor edits.
Tom Lane [2010年2月19日 21:49:10 +0000 (21:49 +0000)]
Reduce the rescan cost estimate for Materialize nodes to cpu_operator_cost per
tuple, instead of the former cpu_tuple_cost. It is sane to charge less than
cpu_tuple_cost because Materialize never does any qual-checking or projection,
so it's got less overhead than most plan node types. In particular, we want
to have the same charge here as is charged for readout in cost_sort. That
avoids the problem recently exhibited by Teodor wherein the planner prefers
a useless sort over a materialize step in a context where a lot of rescanning
will happen. The rescan costs should be just about the same for both node
types, so make their estimates the same.
Not back-patching because all of the current logic for rescan cost estimates
is new in 9.0. The old handling of rescans is sufficiently not-sane that
changing this in that structure is a bit pointless, and might indeed cause
regressions.
Revert version stamping in wrong branch
Version stamp 9.0alpha4
Document --version and --help options for all client applications (they
all support it).
Per report from Josh Kupershmidt
Small corrections to message output targets in pg_ctl
- The message "server stopped" should be affected by the -s option, just
like "server started" already was.
- The message "could not start server" should consistently go to stderr.
Don't use O_DIRECT when writing WAL files if archiving or streaming is
enabled. Bypassing the kernel cache is counter-productive in that case,
because the archiver/walsender process will read from the WAL file
soon after it's written, and if it's not cached the read will cause
a physical read, eating I/O bandwidth available on the WAL drive.
Also, walreceiver process does unaligned writes, so disable O_DIRECT
in walreceiver process for that reason too.
Forbid setval() during recovery. This prevents the PANIC reported by
Erik Rijkers. Patch by Andres Freund.
First pass over client applications documentation proofreading.
gabrielle
Remove mention that binary distributions pre-compile the tutorial files.
Fix STOP WAL LOCATION in backup history files no to return the next
segment of XLOG_BACKUP_END record even if the the record is placed
at a segment boundary. Furthermore the previous implementation could
return nonexistent segment file name when the boundary is in segments
that has "FE" suffix; We never use segments with "FF" suffix.
Backpatch to 8.0, where hot backup was introduced.
Reported by Fujii Masao.
Translation updates for 9.0alpha4
Preliminary release notes for 9.0alpha4
Hot Standby documentation updates
Greg Smith
Tom Lane [2010年2月18日 23:50:06 +0000 (23:50 +0000)]
Volatile-ize all five places where we expect a PG_TRY block to restore
old memory context in plpython. Before only one of them was marked
volatile, but per report from Zdenek Kotala, some compilers do the
wrong thing here.
Tom Lane [2010年2月18日 22:43:31 +0000 (22:43 +0000)]
Provide some rather hokey ways for EXPLAIN to print FieldStore and assignment
ArrayRef expressions that are not in the immediate context of an INSERT or
UPDATE targetlist. Such cases never arise in stored rules, so ruleutils.c
hadn't tried to handle them. However, they do occur in the targetlists of
plans derived from such statements, and now that EXPLAIN VERBOSE tries to
print targetlists, we need some way to deal with the case.
I chose to represent an assignment ArrayRef as "array[subscripts] := source",
which is fairly reasonable and doesn't omit any information. However,
FieldStore is problematic because the planner will fold multiple assignments
to fields of the same composite column into one FieldStore, resulting in a
structure that is hard to understand at all, let alone display comprehensibly.
So in that case I punted and just made it print the source expression(s).
Backpatch to 8.4 --- the lack of functionality exists in older releases,
but doesn't seem to be important for lack of anything that would call it.
Tom Lane [2010年2月18日 18:41:47 +0000 (18:41 +0000)]
Fix ExecEvalArrayRef to pass down the old value of the array element or slice
being assigned to, in case the expression to be assigned is a FieldStore that
would need to modify that value. The need for this was foreseen some time
ago, but not implemented then because we did not have arrays of composites.
Now we do, but the point evidently got overlooked in that patch. Net result
is that updating a field of an array element doesn't work right, as
illustrated if you try the new regression test on an unpatched backend.
Noted while experimenting with EXPLAIN VERBOSE, which has also got some issues
in this area.
Backpatch to 8.3, where arrays of composites were introduced.
Fix pq_getbyte_if_available() function. It was confused on what it
returns if no data is immediately available. Patch by me with numerous
fixes from Fujii Masao and Magnus Hagander.
date_recv should accept infinities.
Reported by James William Pye.
Add missing close tag.
Wordsmithing of HS and SR documentation, with some wording improvements
from Erik Rijkers too.
Tom Lane [2010年2月18日 03:06:46 +0000 (03:06 +0000)]
Force READY portals into FAILED state when a transaction or subtransaction
is aborted, if they were created within the failed xact. This prevents
ExecutorEnd from being run on them, which is a good idea because they may
contain references to tables or other objects that no longer exist.
In particular this is hazardous when auto_explain is active, but it's
really rather surprising that nobody has seen an issue with this before.
I'm back-patching this to 8.4, since that's the first version that contains
auto_explain or an ExecutorEnd hook, but I wonder whether we shouldn't
back-patch further.
Tom Lane [2010年2月18日 01:29:10 +0000 (01:29 +0000)]
Fix up pg_dump's treatment of large object ownership and ACLs. We now emit
a separate archive entry for each BLOB, and use pg_dump's standard methods
for dealing with its ownership, ACL if any, and comment if any. This means
that switches like --no-owner and --no-privileges do what they're supposed
to. Preliminary testing says that performance is still reasonable even
with many blobs, though we'll have to see how that shakes out in the field.
KaiGai Kohei, revised by me
Tom Lane [2010年2月17日 16:54:06 +0000 (16:54 +0000)]
Take care to reprocess an uncommitted notify message.
Oversight in my changes to cope with possible errors during message
processing; spotted by Joachim Wieland.
Another typo fix.
Thom Brown
Use a fatal warning check with what looks like a more portable error message. Error noticed by Tom and buildfarm member kite.
Tom Lane [2010年2月17日 04:19:41 +0000 (04:19 +0000)]
Stamp HEAD as 9.0devel, and update various places that were referring to 8.5
(hope I got 'em all). Per discussion, this release will be 9.0 not 8.5.
Support new syntax and improve handling of parentheses in psql tab-completion.
Newly supported syntax are:
- ALTER {TABLE|INDEX|TABLESPACE} {SET|RESET} with options
- ALTER TABLE ALTER COLUMN {SET|RESET} with options
- ALTER TABLE ALTER COLUMN SET STORAGE
- CREATE INDEX CONCURRENTLY
- CREATE INDEX ON (without name)
- CREATE INDEX ... USING with pg_am.amname instead of hard-corded names
- CREATE TRIGGER with events
- DROP AGGREGATE function with arguments
Tom Lane [2010年2月17日 03:10:33 +0000 (03:10 +0000)]
When updating ShmemVariableCache from a checkpoint record, be sure to set
all the values derived from oldestXid, not just that field. Brain fade in
one of my patches associated with flat file removal, exposed by a report
from Fujii Masao.
With this change, xidVacLimit should always be valid, so remove a couple of
bits of complexity associated with the previous assumption that sometimes
it wouldn't get set right away.
Tom Lane [2010年2月17日 01:48:45 +0000 (01:48 +0000)]
Prevent #option dump from crashing on FORI statement with null step. Reported by Pavel.
Tom Lane [2010年2月17日 01:39:35 +0000 (01:39 +0000)]
log_error_verbosity is now LOGGING_WHAT category.
Tom Lane [2010年2月17日 00:57:06 +0000 (00:57 +0000)]
Tweak description of payload parameter.
Tom Lane [2010年2月17日 00:52:09 +0000 (00:52 +0000)]
Make NOTIFY_PAYLOAD_MAX_LENGTH depend explicitly on BLCKSZ and
NAMEDATALEN, so this code doesn't go nuts with smaller than default
BLCKSZ or larger than default NAMEDATALEN. The standard value is
still exactly 8000.
Tom Lane [2010年2月16日 22:34:57 +0000 (22:34 +0000)]
Replace the pg_listener-based LISTEN/NOTIFY mechanism with an in-memory queue.
In addition, add support for a "payload" string to be passed along with
each notify event.
This implementation should be significantly more efficient than the old one,
and is also more compatible with Hot Standby usage. There is not yet any
facility for HS slaves to receive notifications generated on the master,
although such a thing is possible in future.
Joachim Wieland, reviewed by Jeff Davis; also hacked on by me.
Add query text to auto_explain output.
Still to be done: fix docs and fix regression failures under auto_explain.
Clean up package namespace use and use of Safe in plperl.
Prevent use of another buggy version of Safe.pm.
Only register the exit handler if we have successfully created an interpreter.
Change log level of perl warnings from NOTICE to WARNING.
The infrastructure is there if in future we decide to allow
DBAs to specify extra modules that will be allowed in trusted code.
However, for now the relevant variables are declared as lexicals
rather than as package variables, so that they are not (or should not be)
accessible.
Mostly code from Tim Bunce, reviewed by Alex Hunsaker, with some
tweaks by me.
Move log_error_verbosity GUC setting to "What to log" section, and
document the behavior of terse and verbose output options.
Honor to_char() "FM" specification in YYY, YY, and Y; it was already
honored by YYYY. Also document Oracle "toggle" FM behavior.
Per report from Guy Rouillier
Prevent psql version banner from being printed by the \c command if the
versions match, per report from Peter.
Have SELECT and CREATE TABLE AS queries return a row count. While this
is invisible in psql, other interfaces, like libpq, make this value
visible.
Boszormenyi Zoltan
Remove personal copyright now that file has been rewritten using
existing *.pl conversion script.
Andreas 'ads' Scherbaum
Clarify documentation on the behavior of unnamed bind queries.
This is the main PostgreSQL git repository.
RSS
Atom