git.postgresql.org Git - postgresql.git/log
Tom Lane [Fri, 3 Apr 2009 23:38:19 +0000 (23:38 +0000)]
Add missing help output for \ef option. Andrew Gierth
Tom Lane [Fri, 3 Apr 2009 23:27:17 +0000 (23:27 +0000)]
Use (unsigned char) cast in argument of pg_tolower(). Maybe it works on
Windows without that, but we shouldn't put bad examples where people might
copy them. Also, reformat slightly to improve the odds that pgindent
won't go nuts on this.
Tom Lane [Fri, 3 Apr 2009 18:17:43 +0000 (18:17 +0000)]
Add a comment documenting the question of whether PrefetchBuffer should
try to protect an already-existing buffer from being evicted. This was
left as an open issue when the posix_fadvise patch was committed. I'm
not sure there's any evidence to justify more work in this area, but we
should have some record about it in the source code.
Tom Lane [Fri, 3 Apr 2009 16:59:43 +0000 (16:59 +0000)]
Defend against possible crash if a plpython function does not specify names
for its arguments. Also add a regression test, since someone apparently
changed every single plpython test case to use only named parameters; else
we'd have noticed this sooner.
Euler Taveira de Oliveira, per a report from Alvaro
Make directory name comparisons on Win32 case insensitive.
This method will not catch all different ways since the locale
handling in NTFS doesn't provide an easy way to do that, but it
will hopefully solve the most common cases causing startup
problems when the backend is found in the system PATH.
Attempts to fix bug #4694.
Document that Solaris can't use effective_io_concurrency because of an
ineffective posix_fadvise().
Tom Lane [Thu, 2 Apr 2009 22:39:30 +0000 (22:39 +0000)]
Refactor ExecProject and associated routines so that fast-path code is used
for simple Var targetlist entries all the time, even when there are other
entries that are not simple Vars. Also, ensure that we prefetch attributes
(with slot_getsomeattrs) for all Vars in the targetlist, even those buried
within expressions. In combination these changes seem to significantly
reduce the runtime for cases where tlists are mostly but not exclusively
Vars. Per my proposal of yesterday.
Revert DTrace patch from Robert Lor
Tom Lane [Thu, 2 Apr 2009 20:16:30 +0000 (20:16 +0000)]
Minor code beautification/consolidation.
Give a better error message when trying to change
"effective_io_concurrency" on systems without posix_fadvise().
Have PL/pgSQL FETCH set DIAGNOSTICS ROW_COUNT.
Andrew Gierth
Add support for additional DTrace probes.
Robert Lor
Fix memory allocation for output of hstore type.
Per "maosen.zhang" <maosen.zhang@alibaba-inc.com> report.
Do not show information_schema in \d* commands, unless 'S' or pattern is
specified.
Martin Pihlak
Tom Lane [Thu, 2 Apr 2009 17:30:53 +0000 (17:30 +0000)]
Fix SetClientEncoding() to maintain a cache of previously selected encoding
conversion functions. This allows transaction rollback to revert to a
previous client_encoding setting without doing fresh catalog lookups.
I believe that this explains and fixes the recent report of "failed to commit
client_encoding" failures.
This bug is present in 8.3.x, but it doesn't seem prudent to back-patch
the fix, at least not till it's had some time for field testing in HEAD.
In passing, remove SetDefaultClientEncoding(), which was used nowhere.
Change psql \d* display so 'S' _or_ a pattern include system objects.
Tom Lane [Thu, 2 Apr 2009 03:51:43 +0000 (03:51 +0000)]
Fix GUC's reports of assign_hook failure to always include the parameter value
we failed to assign, even in "can't happen" cases. Motivated by wondering
what's going on in a recent trouble report where "failed to commit" did
happen.
Tom Lane [Thu, 2 Apr 2009 01:16:11 +0000 (01:16 +0000)]
plpgsql's exec_simple_cast_value() mistakenly supposed that it could bypass
casting effort whenever the input value was NULL. However this prevents
application of not-null domain constraints in the cases that use this
function, as illustrated in bug #4741. Since this function isn't meant
for use in performance-critical paths anyway, this certainly seems like
another case of "premature optimization is the root of all evil".
Back-patch as far as 8.2; older versions made no effort to enforce
domain constraints here anyway.
Tom Lane [Wed, 1 Apr 2009 18:54:27 +0000 (18:54 +0000)]
Improve pg_dump's query for retrieving BLOB comments to be more efficient
when there are many blobs and not so many comments. Tamas Vincze
Update comment to reflect that LC_COLLATE and LC_CTYPE are now
per-database settings.
Tom Lane [Wed, 1 Apr 2009 03:32:29 +0000 (03:32 +0000)]
Index some array functions, per Mario Splivalo.
Tom Lane [Wed, 1 Apr 2009 03:23:50 +0000 (03:23 +0000)]
Remove last references to the crypt auth method, per Andreas Scherbaum.
Tom Lane [2009年3月31日 22:54:31 +0000 (22:54 +0000)]
Fix contrib/pgstattuple and contrib/pageinspect to prevent attempts to read
temporary tables of other sessions; that is unsafe because of the way our
buffer management works. Per report from Stuart Bishop.
This is redundant with the bufmgr.c checks in HEAD, but not at all redundant
in the back branches.
Remove some "Other" sections in the release notes by putting the items
at the top of their sections.
Tom Lane [2009年3月31日 22:12:48 +0000 (22:12 +0000)]
Modify the relcache to record the temp status of both local and nonlocal
temp relations; this is no more expensive than before, now that we have
pg_class.relistemp. Insert tests into bufmgr.c to prevent attempting
to fetch pages from nonlocal temp relations. This provides a low-level
defense against bugs-of-omission allowing temp pages to be loaded into shared
buffers, as in the contrib/pgstattuple problem reported by Stuart Bishop.
While at it, tweak a bunch of places to use new relcache tests (instead of
expensive probes into pg_namespace) to detect local or nonlocal temp tables.
Don't crash initdb when we fail to get the current username.
Give an error message and exit instead, like we do elsewhere...
Per report from Wez Furlong and Robert Treat.
Tom Lane [2009年3月31日 17:59:56 +0000 (17:59 +0000)]
Add a "relistemp" boolean column to pg_class, which is true for temporary
relations (including a temp table's indexes and toast table/index), and
false for normal relations. For ease of checking, this commit just adds
the column and fills it correctly --- revising the relation access machinery
to use it will come separately.
Fix a rare race condition when commit_siblings > 0 and a transaction commits
at the same instant as a new backend is spawned. Since CountActiveBackends()
doesn't hold ProcArrayLock, it needs to be prepared for the case that a
pointer at the end of the proc array is still NULL even though numProcs says
it should be valid, since it doesn't hold ProcArrayLock. Backpatch to 8.1.
8.0 and earlier had this right, but it was broken in the split of PGPROC and
sinval shared memory arrays.
Per report and proposal by Marko Kreen.
Update release note introductory description.
Tom Lane [2009年3月31日 01:41:27 +0000 (01:41 +0000)]
Add PQinitOpenSSL() function to support applications that use libcrypto
but not OpenSSL (or perhaps vice versa, if that's possible).
Andrew Chernow, with minor editorialization by me.
More new subsections in release notes.
More release note changes, including a lower level of subsections.
More release note adjustments, reordering.
More release note wording improvements; section order adjustments.
Reorder release note sections.
Tom Lane [2009年3月30日 17:30:44 +0000 (17:30 +0000)]
Fix window function plan generation to cope with volatile sort expressions.
(Not clear how useful these really are, but failing is no good...)
Per report from David Fetter and Robert Treat.
Update URL to Python bug tracker. Backpatch to 8.3; doesn't seem worthy of
further backpatch.
Tom Lane [2009年3月30日 04:08:43 +0000 (04:08 +0000)]
Fix an oversight in the support for storing/retrieving "minimal tuples" in
TupleTableSlots. We have functions for retrieving a minimal tuple from a slot
after storing a regular tuple in it, or vice versa; but these were implemented
by converting the internal storage from one format to the other. The problem
with that is it invalidates any pass-by-reference Datums that were already
fetched from the slot, since they'll be pointing into the just-freed version
of the tuple. The known problem cases involve fetching both a whole-row
variable and a pass-by-reference value from a slot that is fed from a
tuplestore or tuplesort object. The added regression tests illustrate some
simple cases, but there may be other failure scenarios traceable to the same
bug. Note that the added tests probably only fail on unpatched code if it's
built with --enable-cassert; otherwise the bug leads to fetching from freed
memory, which will not have been overwritten without additional conditions.
Fix by allowing a slot to contain both formats simultaneously; which turns out
not to complicate the logic much at all, if anything it seems less contorted
than before.
Back-patch to 8.2, where minimal tuples were introduced.
More release note markup.
More release note markup.
Add SGML markup for commands/literal/application/etc in release notes;
still more work to do.
Consistent 8.4 release note naming for Itagaki Takahiro
Clarify variable naming: pq_initssllib -> pq_init_ssl_lib
Update release notes to say citext is multi-byte aware, per suggestion
from patch author:
Add /contrib/citext as a case-insensitive, multibyte-capable
text data type (David Wheeler)
Better document that SET ROLE does not uset ALTER ROLE SET settings;
suggested wording from Josh Berkus.
Better document PQinitSSL(0) behavior in regards to libcrypto.
Tom Lane [2009年3月28日 00:10:23 +0000 (00:10 +0000)]
Add documentation of the fact that dtrace probes evaluate their parameters
even when not active. Explain how to prevent that with an ENABLED() check.
Document in release notes that NOT IN is only for NOT EXIST clauses.
Andrew Gierth
Tom Lane [2009年3月27日 19:58:11 +0000 (19:58 +0000)]
On Solaris, we should only force use of our own getopt(); it's okay to use
the system's getopt_long(). The previous coding was the result of a sloppy
discussion that failed to draw this distinction. The result was that PG
programs don't handle options as users of that platform expect. Per
gripe from Chuck McDevitt.
Although this is a pre-existing bug, I'm not backpatching since I think we
could do with a bit of beta testing before concluding this is really OK.
Fix markup, per Devrim
Tom Lane [2009年3月27日 18:56:57 +0000 (18:56 +0000)]
Add an errdetail explaining why we reject infinite dates and timestamps
while converting to XML. Bernd Helmle
Tom Lane [2009年3月27日 18:30:21 +0000 (18:30 +0000)]
Fix possible failures when a tuplestore switches from in-memory to on-disk
mode while callers hold pointers to in-memory tuples. I reported this for
the case of nodeWindowAgg's primary scan tuple, but inspection of the code
shows that all of the calls in nodeWindowAgg and nodeCtescan are at risk.
For the moment, fix it with a rather brute-force approach of copying
whenever one of the at-risk callers requests a tuple. Later we might
think of some sort of reference-count approach to reduce tuple copying.
Tom Lane [2009年3月27日 15:57:11 +0000 (15:57 +0000)]
Teach reindex_index() to clear pg_index.indcheckxmin when possible.
Greg Stark, slightly modified by me.
Fix tab completion of ANALYZE VERBOSE <tab>. It was previously confused
with EXPLAIN ANALYZE VERBOSE.
Greg Sabino Mullane, reformatted by myself. Backpatch to 8.1, where the
bug was introduced.
Clearify new SSL certificate verification in libpq
Fix release notes about pg_hba changes
Updated release wording, per Greg Stark:
Previously EXPLAIN VERBOSE had output an internal
representation of the
Second batch of release note fixes by Guillaume Smet
Mark Greg as the instigator of the statistics target increase:
Increase the default value of default_statistics_target from 10 to 100
(Greg Sabino Mullane, Tom)
First round of release note changes from Guillaume Smet.
Fix release note attribution:
Support the IS0 8601 time interval syntax (Tom, Kevin
Grittner)
per Ron Mayer
Improved release notes interval wording:
Made interval seconds rounding more consistent across output
formats (Ron Mayer)
Ron Mayer
Remove duplicate interval (fractional seconds) items; Ron Mayer
Document that Datestyle no longer controls interval output, per
suggestion from Ron Mayer
Tom Lane [2009年3月26日 22:29:13 +0000 (22:29 +0000)]
Make pg_standby's maxretries option do what one would expect. Fujii Masao
Gettext plural support
In the backend, I changed only a handful of exemplary or important-looking
instances to make use of the plural support; there is probably more work
there. For the rest of the source, this should cover all relevant cases.
Tom Lane [2009年3月26日 20:55:49 +0000 (20:55 +0000)]
Fix a couple of places that still claimed LC_COLLATE and LC_CTYPE can't
be changed after initdb.
Tom Lane [2009年3月26日 19:24:54 +0000 (19:24 +0000)]
Adjust phrasing of complaints about multi-byte COPY delimiter strings.
Per pgsql-hackers discussion of 2009年02月17日.
Tom Lane [2009年3月26日 17:15:35 +0000 (17:15 +0000)]
If we expect a hash join to be performed in multiple batches, suppress
"physical tlist" optimization on the outer relation (ie, force a projection
step to occur in its scan). This avoids storing useless column values when
the outer relation's tuples are written to temporary batch files.
Modified version of a patch by Michael Henderson and Ramon Lawrence.
Correction: ansi-join ->anti-join.
Tom Lane [2009年3月26日 03:46:14 +0000 (03:46 +0000)]
Fix markup so that 'make HISTORY' works. A couple very minor
editorial improvements.
Reorder 8.4 release note sections.
Re-add release notes for release 8.3.7.
Adjust AS OF release notes markup.
Mention release note items current as of 2009年03月16日.
First version of 8.4 release notes; markup/cleanup/reorganization still
required.
Tom Lane [2009年3月25日 23:20:01 +0000 (23:20 +0000)]
Add btree_gin contrib module.
Teodor Sigaev and Oleg Bartunov
Tom Lane [2009年3月25日 22:19:02 +0000 (22:19 +0000)]
Adjust the APIs for GIN opclass support functions to allow the extractQuery()
method to pass extra data to the consistent() and comparePartial() methods.
This is the core infrastructure needed to support the soon-to-appear
contrib/btree_gin module. The APIs are still upward compatible with the
definitions used in 8.3 and before, although *not* with the previous 8.4devel
function definitions.
catversion bump for changes in pg_proc entries (although these are just
cosmetic, since GIN doesn't actually look at the function signature before
calling it...)
Teodor Sigaev and Oleg Bartunov
Tom Lane [2009年3月25日 15:03:13 +0000 (15:03 +0000)]
Fix old thinko in pgp.h: the idea is to declare some named enum types,
not global variables of anonymous enum types. This didn't actually hurt
much because most linkers will just merge the duplicated definitions ...
but some will complain. Per bug #4731 from Ceriel Jacobs.
Backpatch to 8.1 --- the declarations don't exist before that.
Use double quotes instead of single quotes.
Complete list of valid fork names, and use double quotes.
Update line count for \? output (obtained from wc -l)
In the \? output, align the columns consistently.
Polish SQL/MED terminology
No period if it's not a sentence
Tom Lane [2009年3月24日 22:06:03 +0000 (22:06 +0000)]
Install a search tree depth limit in GIN bulk-insert operations, to prevent
them from degrading badly when the input is sorted or nearly so. In this
scenario the tree is unbalanced to the point of becoming a mere linked list,
so insertions become O(N^2). The easiest and most safely back-patchable
solution is to stop growing the tree sooner, ie limit the growth of N. We
might later consider a rebalancing tree algorithm, but it's not clear that
the benefit would be worth the cost and complexity. Per report from Sergey
Burladyan and an earlier complaint from Heikki.
Back-patch to 8.2; older versions didn't have GIN indexes.
Tom Lane [2009年3月24日 21:12:56 +0000 (21:12 +0000)]
Fix stupid parenthesization mistake. Per bug #4728 from Bruce Toll.
Tom Lane [2009年3月24日 20:17:18 +0000 (20:17 +0000)]
Implement "fastupdate" support for GIN indexes, in which we try to accumulate
multiple index entries in a holding area before adding them to the main index
structure. This helps because bulk insert is (usually) significantly faster
than retail insert for GIN.
This patch also removes GIN support for amgettuple-style index scans. The
API defined for amgettuple is difficult to support with fastupdate, and
the previously committed partial-match feature didn't really work with
it either. We might eventually figure a way to put back amgettuple
support, but it won't happen for 8.4.
catversion bumped because of change in GIN's pg_am entry, and because
the format of GIN indexes changed on-disk (there's a metapage now,
and possibly a pending list).
Teodor Sigaev
Fix my typo
Remove munging of xml and xpath params to xpath(). The XML must now be a well formed XML document.
Tom Lane [2009年3月23日 16:36:27 +0000 (16:36 +0000)]
Const-ify the parse table passed to fillRelOptions. The previous coding
meant it had to be built on-the-fly at each entry to default_reloptions.
Update constraint_exclusion docs because parameter is now 3-valued, not
just enable/disable.
Add expected file for locale-enabled installations.
Tom Lane [2009年3月23日 01:52:38 +0000 (01:52 +0000)]
More fixes for 8.4 DTrace probes. Remove useless BUFFER_HIT/BUFFER_MISS
probes --- the BUFFER_READ_DONE probe provides the same information and more
besides. Expand the LOCK_WAIT_START/DONE probe arguments so that there's
actually some chance of telling what is being waited for. Update and
clean up the documentation.
Clarify libpq 'sslverify' documentation wording.
Tom Lane [2009年3月22日 22:39:05 +0000 (22:39 +0000)]
Add isExtend to the parameters of the buffer_read_start and buffer_read_done
DTrace probes, so that ordinary reads can be distinguished from relation
extension operations. Move buffer_read_start probe to before the
smgrnblocks() call that's needed in the isExtend case, since really that step
should be charged as part of the time needed for the extension operation.
(This makes it slightly harder to match the read_start with the associated
read_done, since now you can't match them on blockNumber, but it should still
be possible since isExtend operations on the same relation can never be
interleaved.) Per recent discussion.
In passing, add the page identity (forkNum/blockNum) to the parameters of the
buffer_flush_start/buffer_flush_done probes, which were unaccountably lacking
the info.
Clarify 'cert' authentication documention.
Tom Lane [2009年3月22日 18:06:35 +0000 (18:06 +0000)]
Clean up pg_SSPI_error() coding a little bit: make the messages more
consistent, translate where intended, const-ify declarations.
Resolves a gripe from Alvaro as well as some stuff I didn't like.
Tom Lane [2009年3月22日 16:44:26 +0000 (16:44 +0000)]
Remove the -d and -D options of pg_dump and pg_dumpall. The functionality
is still available, but you must now write the long equivalent --inserts
or --column-inserts. This change is made to eliminate confusion with the
use of -d to specify a database name in most other Postgres client programs.
Original patch by Greg Mullane, modified per subsequent discussion.
Tom Lane [2009年3月22日 01:12:32 +0000 (01:12 +0000)]
Remove the datetime keywords ABSTIME and RELTIME, which we'd been treating as
noise words for the last twelve years, for compatibility with Berkeley-era
output formatting of the special INVALID values for those datatypes.
Considering that the datatypes themselves have been deprecated for awhile,
this is taking backwards compatibility a little far. Per gripe from Josh
Berkus.
This is the main PostgreSQL git repository.
RSS
Atom