git.postgresql.org Git - postgresql.git/log
Tom Lane [2006年6月29日 20:00:08 +0000 (20:00 +0000)]
Remove the separate 'stats buffer' process, letting backend stats messages
be delivered directly to the collector process. The extra process context
swaps required to transfer data through the buffer process seem to outweigh
any value the buffering might have. Per recent discussion and tests.
I modified Bruce's draft patch to use poll() rather than select() where
available (this makes a noticeable difference on my system), and fixed
up the EXEC_BACKEND case.
Tom Lane [2006年6月29日 16:07:29 +0000 (16:07 +0000)]
Change TRUNCATE's method for searching for foreign-key references so that
the order in which it visits tables is not dependent on the physical order
of pg_constraint entries, and neither are the error messages it gives.
This should correct recently-noticed instability in regression tests.
Change URL for SITC:
< http://momjian.us/cgi-bin/pgsitc
> http://archives.postgresql.org/pgsql-hackers/2006-06/msg01534.php
Add:
> * Add 128-bit Universally Unique Identifier (UUID)
Add missing #include directive: pg_constraint.h declares some functions
whose prototypes include the "List" type, so it ought to include the
list header file.
Fix typo in comment.
Editorialization for the additions to the CREATE TABLE reference page
made as part of the recent INCLUDING CONSTRAINTS patch. The text could
stand further improvement, but this is at least a step in the right
direction.
Add URL for SITC
> http://momjian.us/cgi-bin/pgsitc
Tom Lane [2006年6月28日 20:04:38 +0000 (20:04 +0000)]
Improve planner estimates for size of tuple hash tables.
Tom Lane [2006年6月28日 19:40:52 +0000 (19:40 +0000)]
Fix hash aggregation to suppress unneeded columns from being stored in
tuple hash table entries. This addresses the problem previously noted
that use of a 'physical tlist' in the input scan node could bloat the
hash table entries far beyond what the planner expects. It's a better
answer than my previous thought of undoing the physical tlist optimization,
because we can also remove columns that are needed to compute the aggregate
functions but aren't part of the grouping column set.
Tom Lane [2006年6月28日 17:05:49 +0000 (17:05 +0000)]
Adjust TupleHashTables to use MinimalTuple format for contained tuples.
Update:
< o Add support for WITH HOLD cursors
> o Add support for WITH HOLD and SCROLL cursors
>
> PL/pgSQL cursors should support the same syntax as
> backend cursors.
>
Update Russian FAQ.
Viktor Vislobokov
Forget to add new file :((
Changes
* new split algorithm (as proposed in http://archives.postgresql.org/pgsql-hackers/2006-06/msg00254.php)
* possible call pickSplit() for second and below columns
* add spl_(l|r)datum_exists to GIST_SPLITVEC -
pickSplit should check its values to use already defined
spl_(l|r)datum for splitting. pickSplit should set
spl_(l|r)datum_exists to 'false' (if they was 'true') to
signal to caller about using spl_(l|r)datum.
* support for old pickSplit(): not very optimal
but correct split
* remove 'bytes' field from GISTENTRY: in any case size of
value is defined by it's type.
* split GIST_SPLITVEC to two structures: one for using in picksplit
and second - for internal use.
* some code refactoring
* support of subsplit to rtree opclasses
TODO: add support of subsplit to contrib modules
Tom Lane [2006年6月27日 23:25:28 +0000 (23:25 +0000)]
Remove embedded newline in string literal --- seems to make newer gcc
versions very unhappy, and shouldn't be there anyway.
Add GUC update_process_title to control whether 'ps' display is updated
for every command, default to on.
Tom Lane [2006年6月27日 21:31:20 +0000 (21:31 +0000)]
Convert hash join code to use MinimalTuple format in tuple hash table
and batch files. Should reduce memory and I/O demands for such joins.
Default stats_command_string to 'on', now that its overhead is minimal.
Tom Lane [2006年6月27日 18:59:17 +0000 (18:59 +0000)]
Put #ifdef NOT_USED around posix_fadvise call. We may want to resurrect
this someday, but right now it seems that posix_fadvise is immature to
the point of being broken on many platforms ... and we don't have any
benchmark evidence proving it's worth spending time on.
Revert patch, doesn't do what it should:
* %Disallow changing default expression of a SERIAL column
Dhanaraj M
Tom Lane [2006年6月27日 16:53:02 +0000 (16:53 +0000)]
Extend the MinimalTuple concept to tuplesort.c, thereby reducing the
per-tuple space overhead for sorts in memory. I chose to replace the
previous patch that tried to write out the bare minimum amount of data
when sorting on disk; instead, just dump the MinimalTuples as-is. This
wastes 3 to 10 bytes per tuple depending on architecture and null-bitmap
length, but the simplification in the writetup/readtup routines seems
worth it.
Will revert in next patch more cleanly.
> * -Disallow changing DEFAULT expression of a SERIAL column
Not done:
< * -Disallow changing DEFAULT expression of a SERIAL column
> * %Disallow changing DEFAULT expression of a SERIAL column
Clamp last_anl_tuples to n_live_tuples, in case we vacuum a table without
analyzing, so that future analyze threshold calculations don't get confused.
Also, make sure we correctly track the decrease of live tuples cause by
deletes.
Per report from Dylan Hansen, patches by Tom Lane and me.
Add INCLUDING CONSTRAINTS to CREATE TABLE LIKE.
Greg Stark
Done:
< * %Disallow changing DEFAULT expression of a SERIAL column?
<
< This should be done only if the existing SERIAL problems cannot be
< fixed.
<
> * -Disallow changing DEFAULT expression of a SERIAL column
Disallow changing/dropping default expression of a SERIAL column
Dhanaraj M
Fix for recent Win32 pg_dump tar temp file patch.
Hiroshi Saito
Tom Lane [2006年6月27日 02:51:40 +0000 (02:51 +0000)]
Create infrastructure for 'MinimalTuple' representation of in-memory
tuples with less header overhead than a regular HeapTuple, per my
recent proposal. Teach TupleTableSlot code how to deal with these.
As proof of concept, change tuplestore.c to store MinimalTuples instead
of HeapTuples. Future patches will expand the concept to other places
where it is useful.
On Win32, use loop to create pg_dump temporary tar file in the current
directory, not in device root, for permission reasons.
Backpatch to 8.1.X.
Done:
> o -Add PQescapeIdentifier()
Add PQescapeIdentifier() to libpq
Christopher Kings-Lynne
Fix blank line.
Add comment about the use of pg_config_paths.h.
Tom Lane [2006年6月26日 17:24:41 +0000 (17:24 +0000)]
Change the row constructor syntax (ROW(...)) so that list elements foo.*
will be expanded to a list of their member fields, rather than creating
a nested rowtype field as formerly. (The old behavior is still available
by omitting '.*'.) This syntax is not allowed by the SQL spec AFAICS,
so changing its behavior doesn't violate the spec. The new behavior is
substantially more useful since it allows, for example, triggers to check
for data changes with 'if row(new.*) is distinct from row(old.*)'. Per
my recent proposal.
Added missing braces to prevent a segfault after usage of an undeclared cursor.
Use Unix newlines, instead of DOS ones.
Use Unix line endings instead of DOS ones, per Magnus.
Update include files to Unix newline format, per report from Magnus.
Update comment description of geo routines and move comment to more
relevant location.
Added some more coverity report patches send in by Joachim Wieland <joe@mcknight.de>.
Update my info:
> * Bruce is Bruce Momjian <bruce@momjian.us> of EnterpriseDB
Tom Lane [2006年6月25日 18:29:49 +0000 (18:29 +0000)]
Tweak dynahash.c to avoid wasting memory space in non-shared hash tables.
palloc() will normally round allocation requests up to the next power of 2,
so make dynahash choose allocation sizes that are as close to a power of 2
as possible.
Back-patch to 8.1 --- the problem exists further back, but a much larger
patch would be needed and it doesn't seem worth taking any risks.
Add:
< * Reuse index tuples that point to rows that are not visible to anyone?
> * Reuse index tuples that point to heap tuples that are not visible to
> anyone?
Moved some free() calls that coverity correctly complains about.
Our version of getopt_long does not set optarg upon detecting an error, as
opposed to what other versions apparently do, so it's not safe to print an
error message. Besides, getopt_long itself already did, so it's redundant
anyway.
Remove individual user copyright because the code is contributed to
PGDG:
> Yes. In fact the copyright belongs to credativ GmbH the company that
> paid Carsten for his work. As you may or may not know I'm the CEO of
> that company and can assure you that his work was contributed to the
> PostgreSQL project.
Fix GEVHDRSZ for Win32.
Magnus Hagander
Fix Win32/Cygwin problems:
After updating to the latest cvs, and also building most of the addons
(like PLs), the following patch is neededf for win32 + Visual C++.
* Switch to use the new win32 semaphore code
* Rename win32_open to pgwin32_open. win32_open collides with symbols
defined in Perl. MingW didn't detect ig, MSVC did. And it's a bit too
generic a name to export globally, imho...
* Python defines some partially broken #pragmas in the headers when
doing a debug build. Workaround.
Magnus Hagander
Update entry:
< * Allow heap reuse of UPDATEd rows if old and new versions are on the
< same heap page?
> * Allow heap reuse of UPDATEd rows if no indexed columns are changed,
> and old and new versions are on the same heap page?
< This is possible for same-page updates because a single index row
< can point to both old and new values.
> While vacuum handles DELETEs fine, updating of non-indexed columns, like
> counters, are difficult for VACUUM to handle efficiently. This method
> is possible for same-page updates because a single index row can be
> used to point to both old and new values.
Add UPDATE entry for row reuse.
>
> * Allow heap reuse of UPDATEd rows if old and new versions are on the
> same heap page?
>
> This is possible for same-page updates because a single index row
> can point to both old and new values.
> http://archives.postgresql.org/pgsql-hackers/2006-06/msg01305.php
Tom Lane [2006年6月24日 14:52:48 +0000 (14:52 +0000)]
Fix re-inclusion of port header file on Windows, per Magnus.
Clarified copyright notice
Tom Lane [2006年6月22日 23:50:35 +0000 (23:50 +0000)]
Remove dllinit.c; it was only needed for long-obsolete Cygwin versions,
and there was some question about its copyright status.
Tom Lane [2006年6月22日 20:42:57 +0000 (20:42 +0000)]
pg_stop_backup was calling XLogArchiveNotify() twice for the newly created
backup history file. Bug introduced by the 8.1 change to make pg_stop_backup
delete older history files. Per report from Masao Fujii.
Tom Lane [2006年6月22日 14:36:12 +0000 (14:36 +0000)]
Standalone backends need pgstat_bestart() too, per Qingqing Zhou.
Tom Lane [2006年6月21日 19:40:31 +0000 (19:40 +0000)]
Move setup_cancel_handler() up near start of psql main(), where the
setup_win32_locks() call formerly was, to ensure that cancelConnLock is
valid when it needs to be. Per Yoshiyuki Asaba.
Tom Lane [2006年6月21日 18:39:42 +0000 (18:39 +0000)]
Remove ancient kluge that kept nodeAgg.c from crashing on UPDATEs involving
aggregates. We just disallowed that, and AFAICS there should be no other
cases where direct (non-aggregated) references to input columns are allowed
in a query with aggregation and no GROUP BY.
Tom Lane [2006年6月21日 18:30:11 +0000 (18:30 +0000)]
Disallow aggregate functions in UPDATE commands (unless within a sub-SELECT).
This is disallowed by the SQL spec because it doesn't have any very sensible
interpretation. Historically Postgres has allowed it but behaved strangely.
As of PG 8.1 a server crash is possible if the MIN/MAX index optimization gets
applied; rather than try to "fix" that, it seems best to just enforce the
spec restriction. Per report from Josh Drake and Alvaro Herrera.
Tom Lane [2006年6月21日 18:09:53 +0000 (18:09 +0000)]
Eliminate a gratuitously different wording of the 'cannot use aggregate function in check constraint' error message.
Joe Conway [2006年6月21日 16:43:11 +0000 (16:43 +0000)]
- During dblink_open, if transaction state was IDLE, force cursor count to
initially be 0. This is needed as a previous ABORT might have wiped out
an automatically opened transaction without maintaining the cursor count.
- Fix regression test expected file for the correct ERROR message, which
we now get given the above bug fix.
Tom Lane [2006年6月21日 16:05:11 +0000 (16:05 +0000)]
Clean up psql variable code a little: eliminate unnecessary tests in
GetVariable() and be consistent about treatment of the list header.
Motivated by noticing strspn() taking an unreasonable percentage of
runtime --- the call removed from GetVariable() was the only one that
could be in a high-usage path ...
Added some more coverity report patches send in by Martijn van Oosterhout <kleptog@svana.org>.
Fixed small typo in changelog
Added fixed from the coverity report send in by Joachim Wieland <joe@mcknight.de>
Added missing error handling in a few functions in ecpglib
Tom Lane [2006年6月20日 22:52:00 +0000 (22:52 +0000)]
Remove redundant gettimeofday() calls to the extent practical without
changing semantics too much. statement_timestamp is now set immediately
upon receipt of a client command message, and the various places that used
to do their own gettimeofday() calls to mark command startup are referenced
to that instead. I have also made stats_command_string use that same
value for pg_stat_activity.query_start for both the command itself and
its eventual replacement by <IDLE> or <idle in transaction>. There was
some debate about that, but no argument that seemed convincing enough to
justify an extra gettimeofday() call.
Tom Lane [2006年6月20日 19:56:52 +0000 (19:56 +0000)]
Split definitions for md5.c out of crypt.h and into their own header
libpq/md5.h, so that there's a clear separation between backend-only
definitions and shared frontend/backend definitions. (Turns out this
is reversing a bad decision from some years ago...) Fix up references
to crypt.h as needed. I looked into moving the code into src/port, but
the headers in src/include/libpq are sufficiently intertwined that it
seems more work than it's worth to do that.
Tom Lane [2006年6月19日 16:13:01 +0000 (16:13 +0000)]
Some editorial work on the documentation of the current-date/time
functions.
Do not use already free'ed errmsg, bug found by Joachim Wieland
<joachim.wieland@credativ.de>
Tom Lane [2006年6月19日 01:51:22 +0000 (01:51 +0000)]
Take the statistics collector out of the loop for monitoring backends'
current commands; instead, store current-status information in shared
memory. This substantially reduces the overhead of stats_command_string
and also ensures that pg_stat_activity is fully up to date at all times.
Per my recent proposal.
Update my email address.
Tom Lane [2006年6月18日 18:30:21 +0000 (18:30 +0000)]
Don't try to call posix_fadvise() unless <fcntl.h> supplies a declaration
for it. Hopefully will fix core dump evidenced by some buildfarm members
since fadvise patch went in. The actual definition of the function is not
ABI-compatible with compiler's default assumption in the absence of any
declaration, so it's clearly unsafe to try to call it without seeing a
declaration.
Tom Lane [2006年6月18日 17:30:48 +0000 (17:30 +0000)]
Fix saveHistory() to not emit bogus complaint during psql exit when using
Darwin's libedit; per my proposal last August. Also, suppress cast-away-
const warnings.
Tom Lane [2006年6月18日 16:21:23 +0000 (16:21 +0000)]
Increase timeout in statement_timeout test from 1 second to 2 seconds.
We have once or twice seen failures suggesting that control didn't get
to the exception block before the timeout elapsed, which is unlikely
but not impossible in a parallel regression test (with a dozen other
backends competing for cycles). This change doesn't completely prevent
the problem of course, but it should reduce the probability enough that
we don't see it anymore. Per buildfarm results.
Merge postmaster and postgres command into just postgres. postmaster
symlink is kept for now for compatibility. To call single-user mode, use
postgres --single.
Tom Lane [2006年6月16日 23:50:48 +0000 (23:50 +0000)]
Fix a couple of obvious problems in DROP IF EXISTS patch.
Tom Lane [2006年6月16日 23:29:27 +0000 (23:29 +0000)]
Code review for SELECT INTO STRICT patch: use saner choices of error
SQLSTATEs, fix some documentation problems.
Tom Lane [2006年6月16日 22:41:45 +0000 (22:41 +0000)]
Clean up after someone's curious idea that it'd be good to strip
leading zeroes from the SQLSTATE codes. They're strings, people,
not numbers.
docs for DROP ... IF EXISTS for the following cases:
language, tablespace, trigger, rule, opclass, function, aggregate. operator, and cast.
Add:
> o Allow PL/python to composite types and result sets
> once buggy assert-enabled versions of python can be detected
>
> http://archives.postgresql.org/pgsql-patches/2006-04/msg00087.php
Add:
>
> * Fix CREATE CAST on DOMAINs
>
> http://archives.postgresql.org/pgsql-hackers/2006-05/msg00072.php
Document issues with non-default tablespaces and pg_dumpall restores.
Backpatch documentation addition to 8.1.X.
Add URL for ISO dates:
> http://archives.postgresql.org/pgsql-bugs/2006-04/msg00248.php
DROP ... IF EXISTS for the following cases:
language, tablespace, trigger, rule, opclass, function, aggregate. operator, and cast.
Add URL for currency type:
> http://archives.postgresql.org/pgsql-general/2005-08/msg01432.php
Add URL for updatable views:
> http://archives.postgresql.org/pgsql-hackers/2006-03/msg00586.php
Add:
> * Consider shrinking expired tuples to just their headers
> http://archives.postgresql.org/pgsql-patches/2006-03/msg00142.php
Tom Lane [2006年6月16日 18:42:24 +0000 (18:42 +0000)]
Fix problems with cached tuple descriptors disappearing while still in use
by creating a reference-count mechanism, similar to what we did a long time
ago for catcache entries. The back branches have an ugly solution involving
lots of extra copies, but this way is more efficient. Reference counting is
only applied to tupdescs that are actually in caches --- there seems no need
to use it for tupdescs that are generated in the executor, since they'll go
away during plan shutdown by virtue of being in the per-query memory context.
Neil Conway and Tom Lane
Add URL to:
* Auto-fill the free space map by scanning the buffer cache or by
checking pages written by the background writer
Add URL for freespace map filling.
>
> http://archives.postgresql.org/pgsql-hackers/2006-02/msg01125.php
>
>
> * Add support for public SYNONYMS
>
> http://archives.postgresql.org/pgsql-hackers/2006-03/msg00519.php
> o Add PL/Python tracebacks
>
> http://archives.postgresql.org/pgsql-patches/2006-02/msg00288.php
Add:
> o Fix problems with RETURN NEXT on tables with
> dropped/added columns after function creation
>
> http://archives.postgresql.org/pgsql-patches/2006-02/msg00165.php
Add URL for:
> * Allow protocol-level BIND parameter values to be logged
>
> http://archives.postgresql.org/pgsql-hackers/2006-02/msg00165.php
Add to locale TODO.detail.
Add URL for ISO date/time syntax:
>
> http://archives.postgresql.org/pgsql-hackers/2006-01/msg00250.php
>
Add LDAP documentation missed in code patch.
Magnus Hagander
Update preload_library magic block wording.
Test for POSIX_FADV_DONTNEED to use posix_fadvise().
This is the main PostgreSQL git repository.
RSS
Atom