git.postgresql.org Git - postgresql.git/log
Here is the patch with memory leak checker. This checker allow detect
in-chunk leaks, overwrite-next-chunk leaks and overwrite block-freeptr leaks.
A in-chunk leak --- if something overwrite space after wanted (via palloc()
size, but it is still inside chunk. For example
x = palloc(12); /* create 16b chunk */
memset(x, '#', 13);
this leak is in the current source total invisible, because chunk is 16b and
leak is in the "align space".
For this feature I add data_size to StandardChunk, and all memory which go
from AllocSetAlloc() is marked as 0x7F.
The MemoryContextCheck() is compiled '#ifdef USE_ASSERT_CHECKING'.
I add this checking to 'tcop/postgres.c' and is active after each backend
query, but it is probably not sufficient, because some MemoryContext exist
only during memory processing --- will good if someone who known where
it is needful (Tom:-) add it for others contexts;
A problem in the current source is that we have still some malloc()
allocation that is not needful and this allocation is total invisible for
all context routines. For example Dllist in backend (pretty dirty it is in
catcache where values in Dllist are palloc-ed, but list is malloc-ed).
--- and BTW. this Dllist design stand in the way for query cache :-)
Tom, if you agree I start replace some mallocs.
BTW. --- Tom, have you idea for across transaction presistent allocation for
SQL functions? (like regex - now it is via malloc)
I almost forget. I add one if() to AllocSetAlloc(), for 'size' that are
greater than ALLOC_BIGCHUNK_LIMIT is not needful check AllocSetFreeIndex(),
because 'fidx' is always 'ALLOCSET_NUM_FREELISTS - 1'. It a little brisk up
allocation for very large chunks. Right?
Karel
Done. In backend/commands/define.c unused field is set to '-' for the
moment.
A patch for CVS is attached, and I have amended my BLOB dumping version
appropriately.
Philip Warner
Jan Wieck [2000年7月11日 12:32:03 +0000 (12:32 +0000)]
Some security checks that we've found an external value completely
when fetching toasted values.
Jan
Tom Lane [2000年7月10日 04:32:00 +0000 (04:32 +0000)]
Prevent creating a boatload of empty segments when md.c is asked to
access a ridiculously large block number within a relation.
oidvectortypes: use SQL type names and separate by commas
psql \df: use format_type and oidvectortypes
map type REAL to float4, not float8
psql \dd :work around UNION bug
typo
Fix handling of pre-existing LD_LIBRARY_PATH, from Keith Parks
Fix sed invocation, from Keith Parks
Another round of those unportable config/build changes :-/
* Add option to build with OpenSSL out of the box. Fix thusly exposed
bit rot. Although it compiles now, getting this to do something
useful is left as an exercise.
* Fix Kerberos options to defer checking for required libraries until
all the other libraries are checked for.
* Change default odbcinst.ini and krb5.srvtab path to PREFIX/etc.
* Install work around for Autoconf's install-sh relative path anomaly.
Get rid of old INSTL_*_OPTS variables, now that we don't need them
anymore.
* Use `gunzip -c' instead of g?zcat. Reportedly broke on AIX.
* Look for only one of readline.h or readline/readline.h, not both.
* Make check for PS_STRINGS cacheable. Don't test for the header files
separately.
* Disable fcntl(F_SETLK) test on Linux.
* Substitute the standard GCC warnings set into CFLAGS in configure,
don't add it on in Makefile.global.
* Sweep through contrib tree to teach makefiles standard semantics.
... and in completely unrelated news:
* Make postmaster.opts arbitrary options-aware. I still think we need to
save the environment as well.
Tom Lane [Sun, 9 Jul 2000 04:56:32 +0000 (04:56 +0000)]
Make view/rule permission checking behave properly with
subqueries in the rule.
Tom Lane [Sun, 9 Jul 2000 04:17:53 +0000 (04:17 +0000)]
Fix bogus DatumGetInt32 coercion.
Remove reference to tag which is not available to the User's Guide
when built on its own. UG now builds cleanly.
Update TODO list.
Update TODO list.
Tom Lane [Sat, 8 Jul 2000 05:30:33 +0000 (05:30 +0000)]
Seems we need <errno.h> to be included explicitly now...
Tom Lane [Sat, 8 Jul 2000 03:04:41 +0000 (03:04 +0000)]
Remove long-dead support for invoking queries from dynamically loaded
backend functions via backend PQexec(). The SPI interface has long
been our only documented way to do this, and the backend pqexec/portal
code is unused and suffering bit-rot. I'm putting it out of its misery.
Tom Lane [Sat, 8 Jul 2000 02:40:27 +0000 (02:40 +0000)]
Put back separate install-bin target ... I was using that,
thank you ...
Tom Lane [Fri, 7 Jul 2000 21:12:53 +0000 (21:12 +0000)]
Fix misuse of StrNCpy to copy and add null to non-null-terminated data.
Does not work since it fetches one byte beyond the source data, and when
the phase of the moon is wrong, the source data is smack up against the
end of backend memory and you get SIGSEGV. Don't laugh, this is a fix
for an actual user bug report.
- format_type function, in use by psql
- added bigint as synonym of int8
- set typelem of varlen non-array types to 0
Rename cash_words_out to cash_words.
Remove HTML FAQ files that are really just text files.
Update TODO list.
Update TODO list.
|> The Makefile.shlib changes will have to be discussed with other Linux
|> developers so we are sure it will work on all platforms.
The problem with the current settings is that the linker is called
directly. This is wrong, it should always be called through the
compiler
driver (the only exception is `ld -r'). This will make sure that the
necessary libraries like libgcc are linked in.
But there is still a different problem with the setting of LDFLAGS_ODBC.
The psqlodbc module defines the functions _init and _fini which are
reserved for the shared library initialisation. These should be changed
to constructor functions. Then LDFLAGS_ODBC can be changed to be just
`-lm'. Btw, why does it use -Bsymbolic?
Andreas Schwab
Move FAQ source into main cvs tree.
Tom Lane [Thu, 6 Jul 2000 23:03:37 +0000 (23:03 +0000)]
Correct unsafe use of strcmp(). See rant of same date posted to pghackers.
Backend makefile cleanup. make maintainer-clean is now completely
functional.
Handle include file installation in src/include/Makefile
genbki.sh improvements: Don't substitute anything by config.status,
instead pass in AWK and CPP through environment. Change calling
convention to support named output files, so we get to see error
messages on stderr.
Rename bootstrap template files and install them into PREFIX/share.
Update initdb to that effect and other readability improvements
in initdb.
Jan Wieck [Thu, 6 Jul 2000 21:02:07 +0000 (21:02 +0000)]
Added comments about the compression algorithm as requested by Tom
Jan
Jan Wieck [Thu, 6 Jul 2000 18:39:39 +0000 (18:39 +0000)]
Please find attached a patch for the pg_dump directory which addresses:
- The problems Jan reported
- incompatibility with configure (now uses HAVE_LIBZ instead of HAVE_ZLIB)
- a problem in auto-detecting archive file format on piped archives
Philip Warner
Jan Wieck [Thu, 6 Jul 2000 18:22:45 +0000 (18:22 +0000)]
Bugfix. If toasted tuple containted NULLs, DataFill() was handed
a wrong pointer causing the bitmap overwriting the tuple header.
Jan
Tom Lane [Thu, 6 Jul 2000 05:48:31 +0000 (05:48 +0000)]
Functions on 'text' type updated to new fmgr style. 'text' is
now TOAST-able.
Tom Lane [Wed, 5 Jul 2000 23:12:09 +0000 (23:12 +0000)]
Update textin() and textout() to new fmgr style. This is just phase
one of updating the whole text datatype, but there are so dang many
calls of these two routines that it seems worth a separate commit.
Tom Lane [Wed, 5 Jul 2000 23:02:37 +0000 (23:02 +0000)]
Make the regression tests safe for TOAST.
Tom Lane [Wed, 5 Jul 2000 21:10:05 +0000 (21:10 +0000)]
Fix typo (extraneous semicolon) in fd.c patch to avoid excess seeks.
Now it skips useless SEEK_CUR 0 calls too, as intended.
Jan Wieck [Wed, 5 Jul 2000 19:51:03 +0000 (19:51 +0000)]
Enable pg_rewrite to be toasted (unlimited size of views and rules).
Jan
add check for libz compression library for pg_dump
Jan Wieck [Wed, 5 Jul 2000 16:17:43 +0000 (16:17 +0000)]
Changed TOAST relations to have relkind RELKIND_TOASTVALUE.
Special handling of TOAST relations during VACUUM. TOAST relations
are vacuumed while the lock on the master table is still active.
The ANALYZE flag doesn't propagate to their vacuuming because the
toaster access routines allways use index access ignoring stats, so
why compute them at all.
Protection of TOAST relations against normal INSERT/UPDATE/DELETE
while offering SELECT for debugging purposes.
Jan
autoconf
attached to this mail is a patch from a colleague that makes
PostgreSQL-7.0.2 run on Linux for the Intel-IA64 architecture. It also
fixes a bug in the configure scripts that caused configure to fail on
the fcntl(F_SETLK) test.
This fix triggered a bug in the fcntl(F_SETLK) code of the Linux
kernel when used on unix domain sockets resulting in postmaster to
segfault immediately after startup. There is a fix available and
included in the kernel that will be on SuSE Linux 7.0, but kernels <=
2.2.16 still have this bug.
Reinhard Max
Jan Wieck [Wed, 5 Jul 2000 13:50:59 +0000 (13:50 +0000)]
Small fix for ALTER TABLE xxx* ADD COLUMN ...
Inherited child tables must not be open during creation of TOAST table
Jan
Jan Wieck [Wed, 5 Jul 2000 13:22:25 +0000 (13:22 +0000)]
Automatically create toast tables on ALTER TABLE ... ADD COLUMN
and SELECT ... INTO ... too.
Jan
Jan Wieck [Wed, 5 Jul 2000 12:45:31 +0000 (12:45 +0000)]
Bugfix in ALTER TABLE CREATE TOAST TABLE
Automatically create toast table at CREATE TABLE if new table
has toastable attributes.
Jan
Jan Wieck [Wed, 5 Jul 2000 10:09:53 +0000 (10:09 +0000)]
Fixed lztextlen() bug in MULTIBYTE, still thinking that lztext
does compression itself the old way.
Jan
U Re-add flock TODO.detail.
Update TODO list.
New resultmap for Alpha, from Ryan Kirkpatrick
Fix broken pg_dump makefile
Jan Wieck [Tue, 4 Jul 2000 17:11:40 +0000 (17:11 +0000)]
Moving toaster out of NO ELOG area in heap_update().
Jan
make TEMP -> TEMPORARY
Make pgdump_oid a temp table. Rename to pg_dump_oid.
Expand secondary password file feature, so that you can use these
files to restrict the set of users that can connect to a database
but can still use the pg_shadow password. (You just leave off the
password field in the secondary file.)
Fix thinko in my last pg_dumpall change
Makefile cleanup from Karel.
Jan Wieck [Tue, 4 Jul 2000 14:37:32 +0000 (14:37 +0000)]
Added CVS header
Jan
Jan Wieck [Tue, 4 Jul 2000 14:36:03 +0000 (14:36 +0000)]
New contrib module for statistical mathematics
Jan
pg_dump patch from Philip Warner
Update TODO list.
Tom Lane [Tue, 4 Jul 2000 06:29:27 +0000 (06:29 +0000)]
Now that I look at it, is_stopword() is broken and always has been.
Doesn't anyone remember how to program a binary search??
Tom Lane [Tue, 4 Jul 2000 06:20:14 +0000 (06:20 +0000)]
Result of strcmp() is a signed int. Per bug report
from Paul McGarry.
Tom Lane [Tue, 4 Jul 2000 06:11:54 +0000 (06:11 +0000)]
Make toast-table creation and deletion work somewhat reliably.
Don't go through pg_exec_query_dest(), but directly to the execution
routines. Also, extend parameter lists so that there's no need to
change the global setting of allowSystemTableMods, a hack that was
certain to cause trouble in the event of any error.
Update TODO list.
Remove unused TODO.detail files.
Update tablespaces TODO.detail item.
Update TODO list.
Tom Lane [Tue, 4 Jul 2000 02:40:56 +0000 (02:40 +0000)]
DataFill() has no business resetting xact status bits
in the infomask of the provided tuple.
misc
unlock buffer before releasing in heap_insert
+unlock buffer in heap_fetch under !ItemIdIsUsed().
Tom Lane [Tue, 4 Jul 2000 00:04:03 +0000 (00:04 +0000)]
tuptoaster.h should surely not #include postgres.h.
Tom Lane [Mon, 3 Jul 2000 23:58:32 +0000 (23:58 +0000)]
Add missing #include for TOAST.
Jan Wieck [Mon, 3 Jul 2000 23:19:04 +0000 (23:19 +0000)]
TOAST changes to catalog
Jan
Jan Wieck [Mon, 3 Jul 2000 23:10:14 +0000 (23:10 +0000)]
TOAST
WARNING: This is actually broken - we have self-deadlocks
due to concurrent changes in buffer management.
Vadim and me are working on it.
Jan
Move global internal files to PGDATA/global.
Move PGPORT envar handling to ResetAllOptions(). Improve long options
parsing to not clobber the optarg string -- so that we can bring
SetOptsFile() up to speed.
Have pg_dumpall write CREATE USER and CREATE GROUP commands instead of raw
COPYs of pg_shadow and pg_group.
It also turns out that pg_dumpall was all but broken for multiple servers
running at non-standard port numbers. You might get the users and groups
from one server and the databases from another. Fixed that.
A little user interface and code cleanup along with that. This also takes
care of the portability bug discussed in "[BUGS] pg_dumpall" in March 2000.
Very small changes in the contrib's pg_dumplo in the attache.
And:
Note, Bruce I found in the contrib tree any files that we forget
remove during contrib cleaning. Please remove these files:
contrib/lo/test.sql
contrib/pg_dumplo/Makefile.out
contrib/pgbench/pgbench_jis.doc
contrib/spi/new_example.example
contrib/spi/README.MAX
Thanks.
Karel
In the attache is new (correct) version. I add TZ (timezone) support
for
to_char() too.
Karel
Add a check of HEAP_MARKED_FOR_UPDATE in HeapTupleSatisfiesDirty().
This enables unique constraint check in case of SELECT FOR UPDATEd.
Tom Lane [Mon, 3 Jul 2000 03:57:03 +0000 (03:57 +0000)]
Clean up memory-context stuff, other minor infelicities.
Tom Lane [Mon, 3 Jul 2000 03:27:31 +0000 (03:27 +0000)]
Remove unused variable. (Hey Peter, you use gcc, why didn't you
notice this warning?)
heap' logging
Attached is a new patch which addresses this problem. (oids in
regression tests).
Chris Bitmead
Version number now set in configure, available through Makefile.global
and config.h. Adjusted all referring code.
Scrapped pg_version and changed initdb accordingly. Integrated
src/utils/version.c into src/backend/utils/init/miscinit.c. Changed all
callers.
Set version number to `7.1devel'. (Non-numeric version suffixes now allowed.)
Tom Lane [Sun, 2 Jul 2000 05:38:40 +0000 (05:38 +0000)]
Don't run in CacheMemoryContext more than necessary.
Tom Lane [Sun, 2 Jul 2000 04:46:09 +0000 (04:46 +0000)]
Don't run in CacheMemoryContext longer than necessary.
Tom Lane [Sun, 2 Jul 2000 04:04:09 +0000 (04:04 +0000)]
Remove memory leak from VACUUM parsing.
Tom Lane [Sun, 2 Jul 2000 02:28:38 +0000 (02:28 +0000)]
New memmgr logic in xact.c failed if AbortTransaction() is called when
there is no open transaction.
Back out Karels to_char changes.
We don't need config.status substituting anything into Gen_fmgrtab.sh, we
just pass in CPP and AWK via the environment from the Makefile.
Synchronized integrated documentation with latest admin guide change.
A little bit of clean-up/bug fix in Tcl build. Handle gracefully cases
where someone wants to build these but hasn't configured for Tcl.
In the attache is new to_date()/to_timestamp() version.
Now the to_timestamp() support WW,W,J,SSSS,DDD conversion from strings and
the am/pm bug is fixed, the to_char() use week-of-year (WW) full compatible
with Oracle.
This patch update relevant regress-tests and docs too.
Karel
~
~
Fix select '1--2'; for PEter.
New and revised material for Admin guide, re backup & restore and database
management
Fixes for Solaris/cc suggested by <pgsql-hackers@thewrittenword.com>
Don't use DISABLE_COMPLEX_MACRO on Solaris. Don't define the
replacement function in the header file. Use -KPIC, not -K PIC.
Use CC to link C++ libraries, not ld/ar.
Eliminate file not found warnings in tcl build code.
Tom Lane [2000年6月30日 07:06:05 +0000 (07:06 +0000)]
RemoveView was doing things the hard way...
Tom Lane [2000年6月30日 07:04:23 +0000 (07:04 +0000)]
Use a private memory context to store rule information in each relcache
entry that has rules. This allows us to release the rule parsetrees
on relcache flush without needing a working freeObject() routine.
Formerly, the rule trees were leaked permanently at relcache flush.
Also, clean up handling of rule creation and deletion --- there was
not sufficient locking of the relation being modified, and there was
no reliable notification of other backends that a relcache reload
was needed. Also, clean up relcache.c code so that scans of system
tables needed to load a relcache entry are done in the caller's
memory context, not in CacheMemoryContext. This prevents any
un-pfreed memory from those scans from becoming a permanent memory
leak.
Fix quotes in /* */ comments in psql.
Tom Lane [2000年6月29日 07:35:57 +0000 (07:35 +0000)]
Add test code to copy all parse/plan trees. Repair essential omissions
in copyfuncs and equalfuncs exposed by regression tests. We still have
some work to do: these modules really ought to handle most or all of
the utility statement node types. But it's better than it was.
Tom Lane [2000年6月29日 05:50:29 +0000 (05:50 +0000)]
Rearrange config.h entries into a more sensible order, and add some
documentation. Let's try to keep this file a bit neater in future,
hmm? Also (to get back to the original point) update info about
FUNC_MAX_ARGS, and add additional config symbols for debugging
new memory management changes.
Tom Lane [2000年6月29日 02:26:23 +0000 (02:26 +0000)]
Remove freefuncs.c, which hasn't been used in a long time and is not
worth the effort to continue to maintain. Since freeObject() is not
capable of coping with cases like multiple links to a node, it's
unlikely that it ever will be useful again. We now have memory
context management that offers a faster and more reliable way of
getting rid of arbitrary node trees (at the cost of having to know
in advance of building the tree that you'll want to get rid of it).
This is the main PostgreSQL git repository.
RSS
Atom