git.postgresql.org Git - postgresql.git/log
Add:
>
> * Tighten function permission checks
>
> http://archives.postgresql.org/pgsql-hackers/2006-12/msg00564.php
>
Add:
>
> * Tighten trigger permission checks
>
> http://archives.postgresql.org/pgsql-hackers/2006-12/msg00564.php
>
Neil Conway [Thu, 1 Feb 2007 04:39:33 +0000 (04:39 +0000)]
This patch adds documentation for the long-version parameters --username
and --password for pg_dump, pg_dumpall and pg_restore, per complaint by
Michael Schmidt. Patch from Magnus Hagander.
Add:
>
> * Fix problem when multiple subtransactions of the same outer transaction
> hold different types of locks, and one subtransaction aborts
>
> http://archives.postgresql.org/pgsql-hackers/2006-11/msg01011.php
> http://archives.postgresql.org/pgsql-hackers/2006-12/msg00001.php
Neil Conway [Thu, 1 Feb 2007 04:16:08 +0000 (04:16 +0000)]
Fix a few typos in comments in GiN.
Update CREATE SEQUENCE documentation to show the same sequence being
created and increments. The old docs created the sequence, then showed
a nextval() of 114.
Add URL for:
o Fix RENAME to work on variables other than OLD/NEW
> http://archives.postgresql.org/pgsql-hackers/2007-01/msg01615.php
Consistenly use colons before '<programlisting>' blocks, where
appropriate.
Update reference documentation on may/can/might:
Standard English uses "may", "can", and "might" in different ways:
may - permission, "You may borrow my rake."
can - ability, "I can lift that log."
might - possibility, "It might rain today."
Unfortunately, in conversational English, their use is often mixed, as
in, "You may use this variable to do X", when in fact, "can" is a better
choice. Similarly, "It may crash" is better stated, "It might crash".
Update comment.
Revert error message change for may/can/might --- needs discussion.
Update documentation on may/can/might:
Standard English uses "may", "can", and "might" in different ways:
may - permission, "You may borrow my rake."
can - ability, "I can lift that log."
might - possibility, "It might rain today."
Unfortunately, in conversational English, their use is often mixed, as
in, "You may use this variable to do X", when in fact, "can" is a better
choice. Similarly, "It may crash" is better stated, "It might crash".
Also update two error messages mentioned in the documenation to match.
Add missing Makefile dependencies for the "bigtest" and "bigcheck"
targets, and refactor the tablespace setup code into a separate
Makefile target.
Rewrite uuid input and output routines to avoid dependency on the
nonportable "hh" sprintf(3) length modifier. Instead, do the parsing
and output by hand. The code to do this isn't ideal, but this is
an interim measure anyway: the uuid type should probably use the
in-memory struct layout specified by RFC 4122. For now, this patch
should hopefully rectify the buildfarm failures for the uuid test.
Along the way, re-add pg_cast entries for uuid <-> varchar, which
I mistakenly removed earlier, and bump the catversion.
Tom Lane [2007年1月31日 18:52:49 +0000 (18:52 +0000)]
Fix initdb to not generate misleading error messages when postgres.bki
or other share-directory files are inaccessible for some reason other
than not existing. Inspired by trouble report from Simon Kinsella.
Revert gincostestimate changes.
Update FreeBSD DocBook installation notices
Allow GIN's extractQuery method to signal that nothing can satisfy the query.
In this case extractQuery should returns -1 as nentries. This changes
prototype of extractQuery method to use int32* instead of uint32* for
nentries argument.
Based on that gincostestimate may see two corner cases: nothing will be found
or seqscan should be used.
Per proposal at http://archives.postgresql.org/pgsql-hackers/2007-01/msg01581.php
PS tsearch_core patch should be sightly modified to support changes, but I'm
waiting a verdict about reviewing of tsearch_core patch.
Add URL:
o Fix RENAME to work on variables other than OLD/NEW
>
> http://archives.postgresql.org/pgsql-hackers/2002-03/msg00591.php
>
Document need for periodic REINDEX in VACUUM FULL cases.
Add missing colon.
Add:
>
> * Add REINDEX CONCURRENTLY, like CREATE INDEX CONCURRENTLY
>
> This is difficult because you must upgrade to an exclusive table lock
> to replace the existing index file. CREATE INDEX CONCURRENTLY does not
> have this complication. This would allow index compaction without
> downtime.
Update for VACUUM FULL:
< reindex rather than update the index.
> reindex rather than update the index. Also, index updates can
> bloat the index.
Add:
> o ARRAY[[1,2],[3,4]])[1] should return the same values as
> ARRAY[[1,2],[3,4]])[1:1];
>
Add FAQ item about timezones and daylight savings time.
Update documentation for backslashes to mention escape string syntax
more, and standard_conforming_strings less, because in the future non-E
strings will not treat backslashes specially.
Also use E'' strings where backslashes are used in examples. (The
existing examples would have drawn warnings.)
Backpatch to 8.2.X.
Tom Lane [2007年1月30日 22:05:13 +0000 (22:05 +0000)]
Repair oversights in the mechanism used to store compiled plpgsql functions.
The original coding failed (tried to access deallocated memory) if there were
two active call sites (fn_extra pointers) for the same function and the
function definition was updated. Also, if an update of a recursive function
was detected upon nested entry to the function, the existing compiled version
was summarily deallocated, resulting in crash upon return to the outer
instance. Problem observed while studying a bug report from Sergiy
Vyshnevetskiy.
Bug does not exist before 8.1 since older versions just leaked the memory of
obsoleted compiled functions, rather than trying to reclaim it.
Tom Lane [2007年1月30日 18:02:22 +0000 (18:02 +0000)]
Add SPI_push/SPI_pop calls so that datatype input and output functions called
by plpgsql can themselves use SPI --- possibly indirectly, as in the case
of domain_in() invoking plpgsql functions in a domain check constraint.
Per bug #2945 from Sergiy Vyshnevetskiy.
Somewhat arbitrarily, I've chosen to back-patch this as far as 8.0. Given
the lack of prior complaints, it doesn't seem critical for 7.x.
Update documentation for pg_get_serial_sequence() function.
Tom Lane [2007年1月30日 01:33:36 +0000 (01:33 +0000)]
Add support for cross-type hashing in hash index searches and hash joins.
Hashing for aggregation purposes still needs work, so it's not time to
mark any cross-type operators as hashable for general use, but these cases
work if the operators are so marked by hand in the system catalogs.
Tom Lane [2007年1月29日 23:22:59 +0000 (23:22 +0000)]
Add comment noting that hashm_procid in a hash index's metapage isn't
actually used for anything.
Update wording for minor release upgrades, per Alvaro.
Done:
< * Add Globally/Universally Unique Identifier (GUID/UUID)
> * -Add Globally/Universally Unique Identifier (GUID/UUID)
Use sizeof() for snprintf() buffer length.
Update process termination message to display signal number and name
from exec.c and postmaster.c.
Update documentation on XML functions
Tom Lane [2007年1月28日 23:21:26 +0000 (23:21 +0000)]
Improve hash join to discard input tuples immediately if they can't
match because they contain a null join key (and the join operator is
known strict). Improves performance significantly when the inner
relation contains a lot of nulls, as per bug #2930.
Tom Lane [2007年1月28日 21:17:32 +0000 (21:17 +0000)]
Remove unnecessary checkpoint from PL regression tests. This was once
handy to prevent core dump files from disappearing, but it's useless now
because (a) we don't drop core in individual DB subdirectories anymore,
and (b) CREATE DATABASE forces an internal checkpoint anyway.
Rename the uuid_t type to pg_uuid_t, to avoid a conflict with any
definitions of uuid_t that may be provided by the system headers. This
should hopefully fix the Win32 build problems reported by Magnus.
Fix plpython MSVC build in non-debug mode.
Tom Lane [2007年1月28日 19:05:35 +0000 (19:05 +0000)]
Remove some unnecessary conversion work in build_regtype_array().
Tom Lane [2007年1月28日 18:50:40 +0000 (18:50 +0000)]
Repair oversight in creation of "append relations": we should set up
rel->tuples as well as rel->rows, since some estimation functions expect both
to be valid in every baserel. Per report from Dave Dutcher.
Tom Lane [2007年1月28日 17:58:13 +0000 (17:58 +0000)]
Make some small improvements in the accuracy of plpgsql's error location
reports; inspired by the misleading CONTEXT lines shown in recent bug report
from Stefan Kaltenbrunner. Also, allow statement-type names shown in these
messages to be translated.
Fix path problem in MSVC bison wrapper. per Joachim Wieland.
Add a new builtin type, "uuid". This implements a UUID type, similar to
that defined in RFC 4122. This patch includes the basic implementation,
plus regression tests. Documentation and perhaps some additional
functionality will come later. Catversion bumped.
Patch from Gevik Babakhani; review from Peter, Tom, and myself.
Tom Lane [2007年1月28日 16:15:49 +0000 (16:15 +0000)]
Fix up plpgsql's "simple expression" evaluation mechanism so that it behaves
safely in the presence of subtransactions. To ensure that any ExprContext
shutdown callbacks are called at the right times, we have to have a separate
EState for each level of subtransaction. Per "TupleDesc reference leak" bug
report from Stefan Kaltenbrunner.
Although I'm convinced the code is wrong as far back as 8.0, it doesn't seem
that there are any ways for the problem to really manifest before 8.2: AFAICS,
8.0 and 8.1 only use the ExprContextCallback mechanism to handle set-returning
functions, which cannot usefully be executed in a "simple expression" anyway.
Hence, no backpatch before 8.2 --- the risk of unforeseen breakage seems
to outweigh the chance of fixing something.
Tom Lane [2007年1月28日 07:29:32 +0000 (07:29 +0000)]
Drat, can't fit an additional argument into log_error. Is it worth an
sprintf pushup to be sure we can report something useful for out-of-range
exitstatus?
Tom Lane [2007年1月28日 06:32:03 +0000 (06:32 +0000)]
Clean up broken usage of HAVE_DECL_SYS_SIGLIST and inconsistent/poorly
formatted error messages.
Use autoconf build-in sys_siglist macro AC_DECL_SYS_SIGLIST, rather than
create our own.
Tom Lane [2007年1月28日 03:02:31 +0000 (03:02 +0000)]
Add a delay at the start of the stats test, to let any prior stats
activity quiesce. Possibly this will fix the large increase in
non-reproducible stats test failures we've noted since turning on
stats_row_level by default.
Tom Lane [2007年1月28日 02:53:34 +0000 (02:53 +0000)]
Dept of second thoughts: the IQ of estimate_array_length() needs to be
kept on par with that of scalararraysel(), else estimates that should
track might not. Hence teach it about binary-compatible cases, too.
Add signal.h for sys_siglist reference.
Tom Lane [2007年1月28日 01:37:38 +0000 (01:37 +0000)]
Fix scalararraysel() to cope with binary-compatible cases, such as text[]
versus varchar[]. This oversight probably explains Ryan Holmes' recent
complaint --- he was getting a generic selectivity estimate instead of
anything intelligent.
Use sys_siglist[] to print out signal names for signal exits, rather
than just numbers.
Modify SGML makefile to allow 'gmake draft' to build draft html ('draft'
is now a target, no longer a modifier).
Tom Lane [2007年1月27日 20:53:30 +0000 (20:53 +0000)]
Correct an old logic error in btree page splitting: when considering a split
exactly at the point where we need to insert a new item, the calculation used
the wrong size for the "high key" of the new left page. This could lead to
choosing an unworkable split, resulting in "PANIC: failed to add item to the
left sibling" (or "right sibling") failure. Although this bug has been there
a long time, it's very difficult to trigger a failure before 8.2, since there
was generally a lot of free space on both sides of a chosen split. In 8.2,
where the user-selected fill factor determines how much free space the code
tries to leave, an unworkable split is much more likely. Report by Joe
Conway, diagnosis and fix by Heikki Linnakangas.
Fixed expected files, so they are in sync with tests again.
remove unnecessary and now inaccurate cast which I should have removed with other old code.
Reactivate libxml memory management via palloc, now that I think I've
classified the conditions under which this is safe to do (see source
code comment).
Add trailing zero byte in Unicode codepoint conversion.
Add:
> * Enforce typmod for function inputs, function results and parameters for
> spi_prepare'd statements called from PLs
>
> http://archives.postgresql.org/pgsql-hackers/2007-01/msg01403.php
Add:
> * Consider having the background writer update the transaction status
> hint bits before writing out the page
Add:
>
> * Consider increasing NUM_CLOG_BUFFERS
Allow args to spi_prepare to be standard type aliaes as well as those known in pg_type. Fixes bug #2917. Add some regression tests for these cases.
Update installation wording for an upgrade to state that dump/restore
should not be done, per Peter.
Control openjade draft-mode by variable DRAFT, rather than whether the
version tag is 'devel'.
Update wording of installation when upgrading, to more clearly
distinguish major vs minor release upgrades.
Modify draft SGML instructions to use DRAFT=Y because recursion was
causing html to be called twice --- no way to exit the makefile after
the recursion returns.
Tom Lane [2007年1月26日 20:06:52 +0000 (20:06 +0000)]
On Windows, use pgwin32_waitforsinglesocket() instead of select() to wait for
input in the stats collector. Our select() emulation is apparently buggy
for UDP sockets :-(. This should resolve problems with stats collection
(and hence autovacuum) failing under more than minimal load. Diagnosis
and patch by Magnus Hagander.
Patch probably needs to be back-ported to 8.1 and 8.0, but first let's
see if it makes the buildfarm happy...
Squelch some VC++ compiler warnings. Mark float literals with the "f"
suffix, to distinguish them from doubles. Make some function declarations
and definitions use the "const" qualifier for arguments consistently.
Ignore warning 4102 ("unreferenced label"), because such warnings
are always emitted by bison-generated code. Patch from Magnus Hagander.
Update BSD/OS platform for 8.2.
Add URL for shrinking tuple to just its headers:
> http://archives.postgresql.org/pgsql-hackers/2007-01/msg01025.php
Update Win32 exception comment.
Add a setlocal command to the beginning of build.bat. This is required
to deal with buildenv.bat properly, so that PATH (for example) doesn't
expand infintly. Per report from Joachim Wieland, patch from Magnus.
Removed compiler warning due to unneeded unsigned declaration.
Removed regression test that triggers those libc precision bugs on some archs.
Update pg_dumpall -f option description.
Correction: temp_tablespaces was implemented by Albert Cervera Areny,
with cleanup by Jaime Casanova.
Reverse out use of Py_RETURN_TRUE in plpython, only supported in Python >=
2.3.
Various fixes in the logic of XML functions:
- Add new SQL command SET XML OPTION (also available via regular GUC) to
control the DOCUMENT vs. CONTENT option in implicit parsing and
serialization operations.
- Subtle corrections in the handling of the standalone property in
xmlroot().
- Allow xmlroot() to work on content fragments.
- Subtle corrections in the handling of the version property in
xmlconcat().
- Code refactoring for producing XML declarations.
Done:
> o -Add a GUC variable to control the tablespace for temporary objects
Add GUC temp_tablespaces to provide a default location for temporary
objects.
Jaime Casanova
Properly detoast access to bytea field pg_trigger.tgargs. Old code
might cause server crash.
Backpatch to 8.2.X.
Fix for plpython functions; return true/false for boolean,
rather than 1/0. This helps when creating trigger functions that output
SQL.
Guido Goldstein
Add 'output file' option for pg_dumpall, especially useful for Win32,
where output redirection of child processes (pg_dump) doesn't work.
Dave Page
Remove developers list from TODO list now that we have URLs to reference
discussions.
<
<
< ---------------------------------------------------------------------------
<
<
< Developers who have claimed items are:
< --------------------------------------
< * Alvaro is Alvaro Herrera <alvherre@dcc.uchile.cl>
< * Andrew is Andrew Dunstan <andrew@dunslane.net>
< * Bruce is Bruce Momjian <bruce@momjian.us> of EnterpriseDB
< * Christopher is Christopher Kings-Lynne <chriskl@familyhealth.com.au> of
< Family Health Network
< * D'Arcy is D'Arcy J.M. Cain <darcy@druid.net> of The Cain Gang Ltd.
< * David is David Fetter <david@fetter.org>
< * Fabien is Fabien Coelho <coelho@cri.ensmp.fr>
< * Gavin is Gavin Sherry <swm@linuxworld.com.au> of Alcove Systems Engineering
< * Greg is Greg Sabino Mullane <greg@turnstep.com>
< * Jan is Jan Wieck <JanWieck@Yahoo.com> of Afilias, Inc.
< * Joe is Joe Conway <mail@joeconway.com>
< * Karel is Karel Zak <zakkr@zf.jcu.cz>
< * Magnus is Magnus Hagander <mha@sollentuna.net>
< * Marc is Marc Fournier <scrappy@hub.org> of PostgreSQL, Inc.
< * Matthew T. O'Connor <matthew@zeut.net>
< * Michael is Michael Meskes <meskes@postgresql.org> of Credativ
< * Neil is Neil Conway <neilc@samurai.com>
< * Oleg is Oleg Bartunov <oleg@sai.msu.su>
< * Pavel is Pavel Stehule <pavel.stehule@hotmail.com>
< * Peter is Peter Eisentraut <peter_e@gmx.net>
< * Philip is Philip Warner <pjw@rhyme.com.au> of Albatross Consulting Pty. Ltd.
< * Rod is Rod Taylor <pg@rbt.ca>
< * Simon is Simon Riggs <simon@2ndquadrant.com>
< * Stephan is Stephan Szabo <sszabo@megazone23.bigpanda.com>
< * Tatsuo is Tatsuo Ishii <ishii@sraoss.co.jp> of SRA OSS, Inc. Japan
< * Teodor is Teodor Sigaev <teodor@sigaev.ru>
< * Tom is Tom Lane <tgl@sss.pgh.pa.us> of Red Hat
Done:
< o Add -f to pg_dumpall
> o -Add -f to pg_dumpall
Allow pg_dumpall to specify a database name rather than the default
'template1'.
Dave Page
Add --tablespaces-only and --roles-only options to pg_dumpall.
Dave Page
Prevent WAL logging when COPY is done in the same transation that
created it.
Simon Riggs
When using MSVC, disable the building of ecpg if pthreads is not
specified.
Magnus Hagander
Tom Lane [2007年1月24日 17:12:17 +0000 (17:12 +0000)]
Get pg_utf_mblen(), pg_utf2wchar_with_len(), and utf2ucs() all on the same
page about the maximum UTF8 sequence length we support (4 bytes since 8.1,
3 before that). pg_utf2wchar_with_len never got updated to support 4-byte
characters at all, and in any case had a buffer-overrun risk in that it
could produce multiple pg_wchars from what mblen claims to be just one UTF8
character. The only reason we don't have a major security hole is that most
callers allocate worst-case output buffers; the sole exception in released
versions appears to be pre-8.2 iwchareq() (ie, ILIKE), which can be crashed
due to zeroing out its return address --- but AFAICS that can't be exploited
for anything more than a crash, due to inability to control what gets written
there. Per report from James Russell and Michael Fuhr.
Pre-8.1 the risk is much less, but I still think pg_utf2wchar_with_len's
behavior given an incomplete final character risks buffer overrun, so
back-patch that logic change anyway.
This patch also makes sure that UTF8 sequences exceeding the supported
length (whichever it is) are consistently treated as error cases, rather
than being treated like a valid shorter sequence in some places.
Tom Lane [2007年1月24日 01:25:47 +0000 (01:25 +0000)]
Relax an Assert() that has been found to be too strict in some situations
involving unions of types having typmods. Variants of the failure are known
to occur in 8.1 and up; not sure if it's possible in 8.0 and 7.4, but since
the code exists that far back, I'll just patch 'em all. Per report from
Brian Hurt.
Simplify handling of XML error messages: Just use the string provided by
libxml as the detail message.
As per <http://archives.postgresql.org/pgsql-hackers/2006-12/msg01087.php>.
For converting error codes to messages, we only need to cover those codes
that we raise ourselves now.
Tom Lane [2007年1月23日 20:45:28 +0000 (20:45 +0000)]
Update xindex.sgml to discuss operator families.
Tom Lane [2007年1月23日 17:54:50 +0000 (17:54 +0000)]
Update pg_dump to support dumping operator families.
Add comment about exception lists in both winnt.h and ntstatus.h.
This patch is required for vcbuild to work after the changes to
pg_proc.h (it's the same changes that's in gen_fmgrtab.sh in the unix
build).
Patch from Magnus Hagander.
Tom Lane [2007年1月23日 05:07:18 +0000 (05:07 +0000)]
Add CREATE/ALTER/DROP OPERATOR FAMILY commands, also COMMENT ON OPERATOR
FAMILY; and add FAMILY option to CREATE OPERATOR CLASS to allow adding a
class to a pre-existing family. Per previous discussion. Man, what a
tedious lot of cutting and pasting ...
Remove newline from error message because URL is gone.
Back out use of FormatMessage(), does error values, not exception
values. Point to /include/ntstatus.h for an exception list, rather than
a URL.
This is the main PostgreSQL git repository.
RSS
Atom